Re: Linux 2.4.20-pre4-ac1

Erik Andersen
2002-08-23T14:55:01Z

On Fri Aug 23, 2002 at 06:46:02AM -0400, Alan Cox wrote:
> Once I get a bit of time I'll resync with Marcelo and push him various
> updates.

I'm seeing tons of these type warnings:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.19/include -Wall -Wstrict-prototypes -Wno-trigraphs -Os
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4
-nostdinc -iwithprefix include -DKBUILD_BASENAME=block_dev -c -o block_dev.o block_dev.c
In file included from /usr/src/linux-2.4.19/include/asm/bitops.h:389,
from /usr/src/linux-2.4.19/include/linux/fs.h:26,
from /usr/src/linux-2.4.19/include/linux/capability.h:17,
from /usr/src/linux-2.4.19/include/linux/binfmts.h:5,
from /usr/src/linux-2.4.19/include/linux/sched.h:9,
from /usr/src/linux-2.4.19/include/linux/mm.h:4,
from block_dev.c:10:
/usr/src/linux-2.4.19/include/linux/bitops.h: In function `get_bitmask_order':
/usr/src/linux-2.4.19/include/linux/bitops.h:78: warning: implicit declaration of function `fls'

It appears that linux/bitops.h includes asm/bitops.h, which itself
includes linux/bitops.h prior to the #define fls(x)... Both files
have include guards, therefore the #define never happens....

-Erik

--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--