Re: Linux 2.4.20-pre4-ac1 (this time regarding 2.5.31)

Steven Cole
2002-08-23T14:52:58Z

On Fri, 2002-08-23 at 08:29, Thunder from the hill wrote:
> Hi,
>
> On Sat, 24 Aug 2002, Eyal Lebedinsky wrote:
> > linux/drivers/usb/brlvger.c compile error
> >
> > You would think that gcc, having had the same problem for a while,
> > would have smarted up by now. And they say computers are our
> > future...
>
> Can't believe! In 2.5 we still use concatenation w/__FUNCTION__.
>
> #define dbgprint(args...) \
> ({ printk(KERN_DEBUG "Voyager: " __FUNCTION__ ": " args); \
> printk("\n"); })
>
> Shall we fix it?
>
> #define dbgprint(args...) \
> printk(KERN_DEBUG "Voyager: %s: " args "\n", __FUNCTION__ );
>
> should cut it, but
>
> #define dbgprint(fmt, args...) \
> printk(KERN_DEBUG "Voyager: %s: " fmt "\n", __FUNCTION__ , args);
>
> might be better.
>
> Thunder

While you're at it, there are three other places you might want to
take a look at:

[steven@spc9 linux-2.4.20-pre4-ac1]$ find . -name "*.c" | xargs grep -l "__, ##"
./drivers/video/aty128fb.c
./drivers/usb/brlvger.c
./drivers/ieee1394/sbp2.c
./arch/arm/mach-sa1100/system3.c

Steven

\x01\x01