From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F4813D0BE1 for ; Thu, 2 Jul 2026 22:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783031979; cv=none; b=MXqv8utYr05PEli9ISCEslO53Xlac6GdSfy/ybFMjSG3ZAs4icqcL6GQiDLcvz2JZdiSdKtDQQv/OSwZLPJHSKdM4X5WppnznCc92azp6kzsF5hVXDrF+zINDRhpTBk6eHCbUKdA6v3LnOB3/JOKHjC7Lx4NBPCXVm5LI1bs1K4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783031979; c=relaxed/simple; bh=jUEFO2dYlrUsHq/npRyqqQfPXBIu9PI/KDflitAC56U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Sl6RTmraue+8HMOBF5miH8iPETUMJMuqQjtjqcCPf/AoJA2ap4d0SFs80Ww2bWIkOnMecU0EDm9RSlakzkp6ntlomKU9DJfmGY3YfXGMV8kCEPOd9xoADjDXU96wvy2dttW7P0v+ANbc0+cYBRjzqUidjgk8zcNPs18oBKT1flQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=fY8f0CR1; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="fY8f0CR1" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-493bb510ce4so16854365e9.1 for ; Thu, 02 Jul 2026 15:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783031969; x=1783636769; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jUEFO2dYlrUsHq/npRyqqQfPXBIu9PI/KDflitAC56U=; b=fY8f0CR18Nr4Lr5ltWqWyO+UKisUH+DPeTY3TFNHpAuvo9/aDWdcDLalh8qcEcon47 Kt0J3oMRFyn7bkwPYMywUg2BAr3rckUUrqLt5KV37CScCa8RNdiJKgvlTi5rtqVw6VMe vnPuberaUAM1Nz7vZK9BoIxr7IyzE2eb6dBIOdrxS1iI6s+Y+9bVxsxWLZAvikvKZbuV JV2zJXbtxn8orgs9NOu2+YcGHfCeamhjAKZhG6mW/u9ythRGSGnmyRlKNSqRKOr1kyNF byc9qsBCuq2wMwhe5+smmmH6DE8L4pTLxLrdeWvkKGKgCx1XbCz2/Xp5VHLUjzGlBRMW Nt7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783031969; x=1783636769; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jUEFO2dYlrUsHq/npRyqqQfPXBIu9PI/KDflitAC56U=; b=TA5sSwfblKjiTUQ9X7mw/P1kZZgXJpFuhpgwN008TWCuQtZ4rXfVTtiGPLJDuQyFYa VrzS9GY9SApFwdkbhbiyB+5BbOchVv4W4TXDaP5tiRdgXoZxkdv7mrdqlAOdWCdLWz/o Bj97xctJ305R5nTrByfS9wYo5iu8toZf6/9PUwRkpqhH8dRUJYxQnUwpo5JAe/IMdG/Q 2SRpGAhINaOJywrloUAVVGyvtPqXBW9KKGTUZ56OGr2+8bHOj/T/TDjGohPk6aaGqhv9 JddPn/dDhi0DGFFbSYMekqndzbjOZTHWykIumloOY46TDNdkJKsSVHQTpC5sV8TBj7q3 EnuQ== X-Forwarded-Encrypted: i=1; AFNElJ9DdLDygCHcWpMYrg/IXY180EtMOQMom6E7EYWwquhMU/JeHwwLn+ig512p+/xV4wYEaD+h1PrsgAR3Bfg=@vger.kernel.org X-Gm-Message-State: AOJu0YzkuUscx0lDiGfm/HxlV7uS9hCoqsrQscpZ3Lo2AXwbvAGBHqZg mgWXXFizjOEJvjczEquHZJvg6XmEHK2T0ff3h3+Wy7O18dzPGlx4A/Oql9zrLqnZ0Q0= X-Gm-Gg: AfdE7cliTfCBcxyDDcKCuC4qiv7+LKUT20tXbh2bScpGhVDQMIt2y11KBEMKxPonNgh nVrmiZDFQGc3tbw57H0CG0OsdyE4W5x5kJUidjgJO0omH/T3DHEiI1iDkgEUBjYo8A6xc81mpCN VL2+A1mHFBDVQlF8GWTSUBqabhr545E2LqpDm/HGg6VbddDHLYceY8+SBdBkoSwbICPLcwKtraB hcfRXbCQ3S7Tj/JkhvRwZpEA0w0lY/teZRQ/x4tlEmfG2ua4ebU7Jt+Qf7nYOxV3yXoex8k9eAz EQ2E8VntiDDAqiDBr7Cf2RYzANNURgJM8fhivxItas+eVv1dlxkfAm/H9mhWlpSdHDkuOWpH3Wv Suc+e4HxS2Yw2NqjwSPdLho+RzrjQr7Eme5gW4epJ1JfFqi3saysDiWQ4GSXHoc1iaKvJCcnYwC y84RhZni1KfQZMZDhYgA== X-Received: by 2002:a05:600c:6692:b0:493:bb6b:5bda with SMTP id 5b1f17b1804b1-493c2b983b8mr111151595e9.29.1783031969110; Thu, 02 Jul 2026 15:39:29 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-493c635c41dsm155275235e9.5.2026.07.02.15.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 15:39:27 -0700 (PDT) Date: Fri, 3 Jul 2026 00:38:18 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] USB: gadget: fsl-udc: fix dev_printk() device Message-ID: References: <20260702141536.90887-1-johan@kernel.org> <20260702141536.90887-4-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nulx3wvnaf5kt2p5" Content-Disposition: inline In-Reply-To: <20260702141536.90887-4-johan@kernel.org> --nulx3wvnaf5kt2p5 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 3/4] USB: gadget: fsl-udc: fix dev_printk() device MIME-Version: 1.0 Hello Johan, On Thu, Jul 02, 2026 at 04:15:35PM +0200, Johan Hovold wrote: > A change replacing custom printk() macros with dev_printk() incorrectly > used the gadget struct device instead of the controller struct device > (including for messages printed before the gadget device name has been > initialised). >=20 > Switch to using the controller platform device with dev_printk() so that > the controller device and driver names are included in log messages as > expected. I don't know about "expected", because before 6025f20f16c2 the affected device wasn't included in the message at all. But I agree that using the not yet initialized device isn't nice, so: Acked-by: Uwe Kleine-K=F6nig Thanks Uwe --nulx3wvnaf5kt2p5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpG6FYACgkQj4D7WH0S /k4wnQgAgH+bRzd/g47MZIWPVDUm/GIRllQkmHGQpbbPtH1l42O12kHnutcWShhF 29ExqURXwq7jY9SaSKB0Eoiv7kVto2Y0I3VVL9qTWA9icwCt1KRzjXjyxrMSWxwe OgBxCb+cTzVfSM3D2ZXbP3ZqY3BVoxLc1M4aAlfO0G6lwaGJ2tWmaOxRR5P3n+le f4GuNJP9DVvSw5TSyY4vUliDPLwN5g3MLfeYEcpaqDav4eW1bPKTpC7itWX2jdTY 6iTNkWRxiEYLn/VbmPca1SusZ4ViA/0hHIIjJDD6BNYm6IyzaCq37abkiI9w0z6e hfxRl+hHKTWLLbm2i2JNy6Cznx4DaQ== =JsLz -----END PGP SIGNATURE----- --nulx3wvnaf5kt2p5--