From: Mike Rapoport <rppt@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org
Subject: Re: [PATCH] x86/setup: do not include kexec_handover.h from asm/setup.h
Date: Fri, 3 Jul 2026 09:19:11 +0300 [thread overview]
Message-ID: <akdUX4vUEEJWrlGO@kernel.org> (raw)
In-Reply-To: <20260703001128.GBakb-MO4o6AUffNAx@fat_crate.local>
On Thu, Jul 02, 2026 at 05:11:28PM -0700, Borislav Petkov wrote:
> On Thu, Jul 02, 2026 at 10:31:11PM +0300, Mike Rapoport wrote:
> > The examples there are really x86 specific.
> > KHO needs decompressor to recognise 'struct kho_scratch' that's defined in
> > include/linux/kexec_handover.h
>
> That struct is huuuge :-P
>
> struct kho_scratch {
> phys_addr_t addr;
> phys_addr_t size;
> };
The size does not matter ;-P
> > I see there's a duplicated 'struct efi_unaccepted_memory' for decompressor
> > needs, should KHO do the same for 'struct kho_scratch'?
>
> You could. But it would go out of sync perhaps.
>
> You could also try a
>
> include/asm-generic/kho.h
>
> and put only really generic, basic gunk there and include it everywhere.
asm-generic would be my preference too if that's fine to include in
decompressor.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-07-03 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 15:15 [PATCH] x86/setup: do not include kexec_handover.h from asm/setup.h Pratyush Yadav
2026-07-01 16:57 ` Borislav Petkov
2026-07-02 19:31 ` Mike Rapoport
2026-07-03 0:11 ` Borislav Petkov
2026-07-03 6:19 ` Mike Rapoport [this message]
2026-07-03 15:11 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akdUX4vUEEJWrlGO@kernel.org \
--to=rppt@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox