From: Petr Mladek <pmladek@suse.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Miroslav Benes <mbenes@suse.cz>,
live-patching@vger.kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org,
Zelin Deng <zelin.deng@linux.alibaba.com>
Subject: Re: [PATCH] kbuild: unset sub_make_done before calling kselftest build system
Date: Fri, 3 Jul 2026 10:25:15 +0200 [thread overview]
Message-ID: <akdx6xWTuv5Ga0YY@pathway.suse.cz> (raw)
In-Reply-To: <20260703-makefile-unset-submake-done-v1-1-6899248f3d6a@linutronix.de>
On Fri 2026-07-03 08:04:08, Thomas Weißschuh wrote:
> The kselftest build system may recourse back into kbuild when building
> test modules. In that case kbuild needs to parse the new flags passed
> from the command line, instead of using the ones inherited from the
> kbuild invocation.
>
> Force that command line reevaluation.
>
> The same was done for scripts/install.sh in commit 14ccc638b02f9ec
> ("kbuild: cancel sub_make_done for the install target to fix DKMS")
>
> Reported-by: Zelin Deng <zelin.deng@linux.alibaba.com>
> Closes: https://lore.kernel.org/all/20260525083721.27857-1-zelin.deng@linux.alibaba.com/
It is great that you added references to the related commit and
the original thread.
> Fixes: c9bb03ac2c66 ("kbuild: reduce output spam when building out of tree")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
I believe that this is reasonable solution:
Acked-by: Petr Mladek <pmladek@suse.com>
Zelin, could you please provide your Tested-by, please?
Best Regards,
Petr
PS: I could take this via livepatching tree. But feel free to take it
via kbuild tree. I am going to wait few days until the discussion
settles down.
next prev parent reply other threads:[~2026-07-03 8:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 6:04 [PATCH] kbuild: unset sub_make_done before calling kselftest build system Thomas Weißschuh
2026-07-03 6:14 ` sashiko-bot
2026-07-03 8:26 ` Petr Mladek
2026-07-03 9:32 ` Thomas Weißschuh
2026-07-03 10:06 ` Petr Mladek
2026-07-03 19:24 ` Nicolas Schier
2026-07-03 8:25 ` Petr Mladek [this message]
2026-07-03 19:25 ` Nicolas Schier
2026-07-04 1:59 ` Zelin Deng
2026-07-03 8:39 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akdx6xWTuv5Ga0YY@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=shuah@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=zelin.deng@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox