From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEC2F347FC0 for ; Fri, 3 Jul 2026 08:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783067173; cv=none; b=UF4QRLim37ainppsw+tLvOw01DiOh1I8OVErExaXSREq4G8te1RppZNLPC0MXV9kgDUWNZCW5e4Kx6879NMi9zwHj+d5uH/y7R2o3jraTjVEC1FrRyja4juF/JUwDwsDO0yjFle1l9gWDm8PDlTvS0RuXKsCqH53V9tffIk3Oe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783067173; c=relaxed/simple; bh=XKI2pAfG7OX1O/DXM04l/YZndOsoqOzA948p9sxcHoE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P7fH1gi8QGylGbhKStyjidwKUg/MDTopqD5ExhTkIUyFV9iitLeiByOgZZ4Bdqzdd6h/ekL6ORBHdNl4n/GBJwBVedlQMzkjoMnVvqJjrATTEV3uuTkwR8p8N8jMYf7P7Q2WnMDzdkPe+AAJVGqzigvSaM1lDnJ9uDzmG4CAlng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=S0cPpTDn; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="S0cPpTDn" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-493b68b4643so1543765e9.0 for ; Fri, 03 Jul 2026 01:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783067170; x=1783671970; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=yi3rhvEIY7HPb2+WXJBWNBz8xP5NaPUV+FO6A/JpBpc=; b=S0cPpTDnY/bjqdlG6CvI1QWYPk5WPF2FxG4eJR8wwRsoNhViXn0w9GyWuFe//az0sy kHFQACYOK8imS6MyX6mTyKsKb9HOOjhnbc+HzOpILUw2F0lL7Wf+Ku/JoJ2oSH1ZPC3Y nVdC9E6StrdVwDFyd+MY8wpd993A+N46BN93Rv9TkT2JOa1ug1e1U/jr6Rb7+sayTzaJ /gI80KtGV5QxfK9xz9T2W58Yiq1aDV+CzEFVFi5LlWTP8bbEKIWK2iSpXYwueCfMGQBf stylJN1XLtC0U9Gy/IRbFfoMkbcKAViwIW0Z8dQkKH670y8b30IcuPIC76bpvn0tEutf b5FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783067170; x=1783671970; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=yi3rhvEIY7HPb2+WXJBWNBz8xP5NaPUV+FO6A/JpBpc=; b=imffYiaDwfwjit7xmE9NDWs3N1uzIQpiyMrEY1MAZT0QLRUSR0beOQtTLlwm/tp+VC 2ziZa2xEUS57I0ZsgmBqSe5z/wk1IBQWqRGLa5h5jI3wLqHviyqVFZiR+9p9g4EU72Z5 1u1zH4zN05M9btS5QLNVtVO3RKYPo/Q8VMYlx+Mwl/kldZewsTgAaWisiLo3bfbWD/ej WjqnJ0ovfDN7aC94WjBivVICMD4NtOtiqi6qodusjJUuj0J2kzFvU7z6x1RCdByKrB8S I7uTnmko0ynKm5BmWtcAAwSOva85S4z3OmAsYOzLKZwADbqF2+8LowHwxvdXj6EC5KPV ZhVA== X-Forwarded-Encrypted: i=1; AFNElJ/ha9TkHLYojxY97994U2pO9ZGgNjLhZ0aPy350qJXZ5qGwLjbvFPWZsG6QsJ7lmeFlqDLmoYKxj09cdsE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6aCMC7cb1RQSjEHR1M6Y0uIG1/99vEcbigv9t4a3dmh9Ciq+B 4FjbKY+mekTk3tYW5iIYj89m6L5BqUGBOfZwodqR4m8Ry0m/Eo0N+933HsNdA5Owap0= X-Gm-Gg: AfdE7ckOYPgzuGZVLi/Ox775s6XSweLExVw2gG2SBAsuqfsxhKWXkgPmr669Kvl5jxS Ez3yW056V437penfgTKYL/ROtc6+HBmqQirLZvnQgOMi7Gonqh+obTd1j2mT65qUMqAY+poLJJJ nEt/bfjzWpXEE3pAtz1Ms5TestkiNeSdVjHGI2tuh9hv/bU+eecM/riFZ6XCdh6bPJ0F7RrzLi/ oeURKsL5wmmxM8jVlbvB7P4wOdo5G7TVQMhre6Uf/Bcoev/OwQykPneJXZ1LI6h6GvyJMsCcYP9 wuOLMuXW3wqHC7hRt+eQLNhXlioDwdp4XAy5Nu0Worp7KySGn/UrqpPV+CWDcBj0VvsDLud1ANh 5ILtFw9/5bWb88/CR+tr/MGxKlmkwoCt6ktH5WdjnD0x7KAfF/qLHUMnIHrcw6qTp9cNsRD/E98 90O7HHPpx2eAFQLFU= X-Received: by 2002:a05:600c:8718:b0:493:c845:bc20 with SMTP id 5b1f17b1804b1-493c845bc60mr60654815e9.4.1783067170178; Fri, 03 Jul 2026 01:26:10 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce12c40sm50659555e9.13.2026.07.03.01.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 01:26:09 -0700 (PDT) Date: Fri, 3 Jul 2026 10:26:07 +0200 From: Petr Mladek To: sashiko-reviews@lists.linux.dev Cc: Nathan Chancellor , Nicolas Schier , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Miroslav Benes , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , shuah@kernel.org, Zelin Deng , linux-kbuild@vger.kernel.org Subject: Re: [PATCH] kbuild: unset sub_make_done before calling kselftest build system Message-ID: References: <20260703-makefile-unset-submake-done-v1-1-6899248f3d6a@linutronix.de> <20260703061449.246801F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260703061449.246801F000E9@smtp.kernel.org> On Fri 2026-07-03 06:14:48, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] Incomplete fix and inconsistent state: The patch correctly unsets `sub_make_done` for the `kselftest` targets to allow Kbuild command-line reevaluation when building external kernel modules. However, it fails to apply the same logic to the `tools/` and `tools/%` targets, introducing a discrepancy between build entry points. > -- > > commit 06c418388d65deb3d8494a6e8e7071c0e709186b > Author: Thomas Weißschuh > > kbuild: unset sub_make_done before calling kselftest build system > > This commit unsets sub_make_done before invoking the kselftest build system to > ensure Kbuild reevaluates command-line flags when building test modules. It > mirrors a previous fix done for scripts/install.sh. > > > diff --git a/Makefile b/Makefile > > index b9c5792c79e01..f717a4dc96d6a 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1591,10 +1591,10 @@ tools/%: FORCE > > > > PHONY += kselftest > > kselftest: headers > > - $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests > > + $(Q)unset sub_make_done; $(MAKE) -C $(srctree)/tools/testing/selftests run_tests > > [Severity: Medium] > Will make tools/selftests still fail after this change? > > The tools/ and tools/% targets in Makefile delegate to the tools build > system, which can also trigger external kernel module builds (like bpf_testmod). > > Because sub_make_done is not unset for these targets, invoking commands like > make tools/selftests or make tools/all will skip Kbuild's M= argument parsing. > > Should sub_make_done also be unset in the tools/ and tools/% targets to maintain > consistency across the build entry points? This might make sense. I see that the tools: and tools/%: targets are defined right above the kselftest*: ones. And they are even advertised in "make help" or "make tools/help". Well it probably should be done in a separate patch. It would be better for bisecting potential regressions. Thomas, Zelin, what do you think, please? Best Regards, Petr