From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF353D8132 for ; Fri, 3 Jul 2026 13:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783085422; cv=none; b=U+3tqnYyjgvNP4hTnbd6JW4leTUklbGPR4+gRWv3n23lp9mfGQ/WXnkZIriJBtA8NPHK6qg6nUAHXe1mUStVn5gfBaYdReEc7dkHhCYSkqdKazZ5pWc9EJZkvFy9cMgj1DBbAMXm7Zh15Zz5ld4KX2okvbpRIEwUr0Oh8bEkb1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783085422; c=relaxed/simple; bh=4lJ2O2wDSeRsQzaR8t5jnN3vMWzZqfraYHNgEuoulN8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VuHUE79Lmc8rlJk98vqrW/g5MtZwMcQCVEwz0mvO9XDDaxnDWVlNStDdjTIt6jwDMwiHxFzdfLCQDzLmZJbeTC7kBlA+wa///gNJHOe1u7eHedjL5xka+G73B7umij8gKk/uz2eML1UwZvAeeJ/e4KB3dwtV49jQ3kk7Qf7bZ2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JRx1rGBF; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JRx1rGBF" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2c82538b6c0so5953645ad.2 for ; Fri, 03 Jul 2026 06:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783085420; x=1783690220; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=j645c2D7HtwVcsPA69lZTtQpjVCwUV/sEYrOt+2paLM=; b=JRx1rGBFcCL5oP9VFrlR8MRQkXm4ZDfCUn/btyN+5TV+//XvQOBHwJWEhIW0ivzORb hpuwdGse0gGr7WGJsQ5HKjymIwk6gcIVwxp5mBdpeDBjuqnJvRjDqAKdCl4XxLX9zz2J mogkEu4OC1rvCDKKsH62h4TglqPq0+m1LQfSFHwh/6cYC3+p9Nbx4irPVxHBYEHhLF4v M5+kPPESDtDTU4dHja0FuAtn6Xmy8n5YpFJxl0NvkHv+msl+inhbYw2tUgpTZJKM04kv ljFGTQ8bgc3UsgnDxUdMRMrZCfb7+iL9XUJPmji/lJm7kyyq8wMDjJTgWa5uwMg2V/eJ OrfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783085420; x=1783690220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j645c2D7HtwVcsPA69lZTtQpjVCwUV/sEYrOt+2paLM=; b=H2OYPNafQM5N1MnGzPcjnReQzZMZPQBjQSs+t7vOH/Xyf45+Kg1jF1EOinvJDFqyYJ rw6Un4X/PLhxelMkWzK5YEoB4mV0b/1ROPvAz4HOQWLPZ3nfM38F1dD51OladxHEVVbH rIBfMkDcMvtgTA6RsEaSaa2FRgsRzKz8yZDfQJBOW9jHbpNp7G4olM5PbXQ88m+S8J3G 9OVjfR7MG0TEQfu2VKWAloVw9E78/4E5f3EKat8m3qqWOKbNq1ZCCuTT1pT1nIQQqpa+ Q0sQGTuA/6OqyB0NKydZe6QmGXqKeBcGOjNlp3TYVU7/P3xYvNfCKW/z1ahk9F3KyYUD CWNQ== X-Forwarded-Encrypted: i=1; AHgh+Roc4ClW/BAstnh5CZ74CAC1W+OUNJYRGpC/XdiGh1v2n+/6hzGoLPrJU7KXNKJWa2GIirjR0WqVYF4qTwU=@vger.kernel.org X-Gm-Message-State: AOJu0YzFZxjXe0gezItH7q2UObXmUW8oG+kHSGsC9KhAK0N9eHIZFtMh pCNloyR5Ito1cZUvrc0ejzDGCyaLLRb7JgsDXPyZgjncyE/yss4Hi6MmY+ziHebfZH26rg== X-Gm-Gg: AfdE7cmFcE3oxsPdVTwwMu4B/e6xslHJcKwenzKKcgltz2WCnxp3hg+6967JRvm91f6 ZmedHWSEvg4SVc6aiur0YjkWzIkbdJNc0sZFNuSZTqfpqau+dN5uhbcAoJX5cJ9hlkfN+MgNSYx LjftXh+sTiNyH9F+oRSpS7fXim/FZgWAazmz+3O+hnC7j0qPLf7nECk6DrCUXmGDxXcydDH2+Rf +0x2UAwKizmUXRp+DBpuYWh77M8UecMtXytVYImTzW+PW7U98oznnHql3+Qjae8UY1Yku1hjb3t yry39y0IlMdTx3luFTQ1I8SLbGiM/1qDGea7JfPw+8HDsZOfdjmZkMBMrXmjXW1CPbeZjIvZUD1 +IgEHLEvkecCLA+4vmrDnqFOuk/PmWsvBmhct5zlcTEcbn8+ZY1TaZBIzb6TJChyhEfJdv14= X-Received: by 2002:a17:903:2444:b0:2c9:d8c6:1db8 with SMTP id d9443c01a7336-2ca911d35d4mr101211985ad.28.1783085420394; Fri, 03 Jul 2026 06:30:20 -0700 (PDT) Received: from localhost ([2a09:bac5:55f2:18c8::278:51]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad6f260c7sm9901615ad.12.2026.07.03.06.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 06:30:19 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Fri, 3 Jul 2026 21:28:25 +0800 To: Pratyush Yadav Cc: mdshahid03@gmail.com, Andrew Morton , Baoquan He , Mike Rapoport , Pasha Tatashin , Dave Young , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Sourabh Jain Subject: Re: [PATCH] dm: crash dump: remove redundant NULL check before kvfree() Message-ID: References: <20260703112642.65498-1-mdshahid03@gmail.com> <2vxzbjcogu0b.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2vxzbjcogu0b.fsf@kernel.org> On Fri, Jul 03, 2026 at 02:03:32PM +0200, Pratyush Yadav wrote: >On Fri, Jul 03 2026, mdshahid03@gmail.com wrote: > >> From: Mohammad Shahid >> >> kvfree() safely handles NULL pointers, so the explicit NULL check >> before calling kvfree() is unnecessary. >> >> This issue was reported by ifnullfree.cocci. >> >> Signed-off-by: Mohammad Shahid > >Reviewed-by: Pratyush Yadav Hi Pratyush, Thanks for reviewing this patch! > >BTW, Sashiko [0] pointed out a bunch of problems in the surrounding code, >and they seem to look legit. If you're interested, help in fixing them >would be much appreciated. > >[0] https://sashiko.dev/#/patchset/20260703112642.65498-1-mdshahid03@gmail.com I'll send a new version of https://lore.kernel.org/kexec/20260501234342.2518281-1-coiby.xu@gmail.com/ soon which can address Sashiko's feedback scrutinized by Sourabh. > >[...] > >-- >Regards, >Pratyush Yadav > -- Best regards, Coiby