From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84FA43D9DBD for ; Fri, 3 Jul 2026 13:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783086374; cv=none; b=I5UWx1DXOGGYHzveB22EgMvFDjLFNB24BJROLK60SnXtws+Z7RFEpoT0K7KfocyFhKzofzVc5TWn30yXxAdjOGUkw/gNtdVuGCDkDCVp7mzj6AiLzpKlzbexbR+C1o2mOOFEer2OBMc21scEXetNVqqGiJeDlJcFiKCprApeSM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783086374; c=relaxed/simple; bh=PNYyEgoZtTQZAIb05vcE56UQchi78kODzvtdyqQGPd8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JjL5FyzPGOyqILFMHjxiMEUxI5ETwcjXkAEYMohruq7wkBvDepJJrOMzskiU1BcyzUWQVSjFFKAebs1T3p2rRr4ssZxtNeOtVR0Rtkt3RbAmSJQD+4xDDN/N5ZwkcDI7KsFFFc5MxgFByoLvfEleGUr3lYl4Gu6X8unoQs2LzMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Vq4M7Lx2; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Vq4M7Lx2" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2cab97c86bdso210125ad.1 for ; Fri, 03 Jul 2026 06:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783086372; x=1783691172; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=dEobmR+dTUalRHOtzAB6SzqkNWJ+47R827DKeMKcmBQ=; b=Vq4M7Lx2ytQUq/Z6BA0tBBqceo+HzPqOC+k+kj5s5kg89730h+yGr6gErUtxE+Bfoh Cz1a5J3UQRnE8GzGZnBSxU9YPxXAEhnYi6ksCVoqlEKHqojdTz7E7ZkuqhPzwPmXsuXf b3OWV+oygV5qT2h75tdXkdZYnneuoG5hRLb/8cdDKUIQlhjpq2nHcOJ42m1P8omup/jX 9ronGufU/BINHYPhdOLEX3jH6Z3I4dEYMLBptTnxsOzoz8LBSOyJrBGpVUbkhgBWZ+a7 RbD9asVz8ejilhm29sCXamgaw82tmFJ2JfyENf4psx1d1GOEMU1WKjR9sFnumEKeRbvW iSvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783086372; x=1783691172; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dEobmR+dTUalRHOtzAB6SzqkNWJ+47R827DKeMKcmBQ=; b=Fkpje8FsgNbh94pGaAh5sfEOIMIFVhoHq3oAWiSLzZGETm//NbS+XwXtqteyGQnCAu M8j7gy2sOu3Y/RD0Ko/F03rCPb4QqkZThl+aaM8sLqxJIPyp0mk8yjP5Ofe+Z1nSyPAj JF1stRoqYbckxmollAnWXpwDBS5R+mDhbO2rLGIKmNDYd6LBjEsBcrF5AEj4crWTrxFc LbFbFhHLw3pg1feETRx/UwuSchS2gf6FRVaGPywxBGb6284R2bSHEWr/wO2S4Sb01C5L yNnCPT7p6gM9g6tA0WGtF6RTg3dBQWYuFBIABEYmhWqFqW/Qzd077upt4oreRpsh7G4U WTUQ== X-Forwarded-Encrypted: i=1; AHgh+RqGTsc10e/709Nawubd1mcrRxKPisNz20TApVDHTtdgfYYVZzsnByXvNe1VzGDCagmQsnHzmR8UusWtGCM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyh+KVP7TBs2nVuMrGYaWAh0UFVdrnbEFDgZPGKGIclX/jfpWdp edzJvY08votEazR+5ohFaD3kXYx66RVcKtK1K98ue6+fsRZnwAQYkbsONA7cc1yMxA== X-Gm-Gg: AfdE7cm8Thcki1BEDOAB+k72TrMtHh2DIi6ZBfRlIbT3G7K+opp1QxGlKwv90Oeqh35 glE8AK/8kbzpBr0EKbK0Xd6bhnyDnEmnO6NLMOgHwzurOqyvPdMNmU868bAtPNLw3lryLsEtGPN 1S8c0aKoiTNB/gaymNHEt2Masts1aizkO5y75KKhh5KnRMmHp9ePOWGv8N9/O/vyY2H+IAP6WQ4 Pas4KcWI6lKq5fnFlqXgHHC0lLz5kJDfxKFXhUeKqxJs4tBJQtC7qtL9TmoTbwvdbcFFKds7E+H RbBgsOCJHaPrvnzOS+0F+OEaJiwgEJZiQiohi1Cidw4dDHvcqohfHhFyB/NnK+g9QF0pF7WmSAz roxEXd8dhnuSGY/f4pWe7KT1tYE7bcA01by09uF9I2vqwuy6XauV0G6Q8nRbJkU4i4QOtHV6rmP hFZzztpeKbdlBZ60VBAGyX+1vAnUw3U/6uq8xlS8aXVy+f0OU= X-Received: by 2002:a17:902:fc86:b0:2ca:d873:3b41 with SMTP id d9443c01a7336-2cad87347damr1931895ad.19.1783086371317; Fri, 03 Jul 2026 06:46:11 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad7894b20sm9826605ad.78.2026.07.03.06.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 06:46:10 -0700 (PDT) Date: Fri, 3 Jul 2026 13:46:04 +0000 From: Pranjal Shrivastava To: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , Joerg Roedel Cc: Joerg Roedel , Will Deacon , Robin Murphy , Baolu Lu , Jason Gunthorpe , Kevin Tian , Bjorn Helgaas , Samiullah Khawaja Subject: Re: [PATCH v9 0/4] iommu: Standardize ATS robustness and state tracking Message-ID: References: <20260615235037.259909-1-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260615235037.259909-1-praan@google.com> On Mon, Jun 15, 2026 at 11:50:33PM +0000, Pranjal Shrivastava wrote: > The primary motivation for this series is an ATS state mismatch observed > under heavy load (via iova_stress). A failure in pci_enable_ats() leaves > IOMMU drivers like arm-smmu-v3 with inconsistent state leading to PCI core > warnings during device detach. > > While David's recent work [1] addressed a discovery race for specific > quirked devices by moving them to the HEADER phase, gaps remained > regarding how Virtual Functions (VFs) inherit state from their Physical > Functions (PFs). Specifically, pci_ats_supported() did not account for > PF-level quirked status, and pci_prepare_ats() lacked STU validation for > VFs. > > Based on discussion with Jason and Baolu in v3/v5, it was decided that the > IOMMU drivers should explicitly check pci_ats_supported() before calling > pci_prepare_ats(). To enforce this, pci_prepare_ats() now noisily checks > for support via WARN_ON(). Furthermore, the device probe should fail if > pci_prepare_ats() fails. Since these early gates preclude software > configuration errors, any remaining failure during pci_enable_ats() is > treated as a kernel bug. > > Following the discussion with the community, the driver-specific series > have been posted separately: > > - Intel IOMMU fixes reported by Sashiko [2] > - Refactors for AMD IOMMU [3] > > [1] https://lore.kernel.org/linux-pci/20260403222750.1215002-1-dmatlack@google.com/ > [2] https://lore.kernel.org/all/20260531170254.60493-1-praan@google.com/ > [3] https://lore.kernel.org/all/20260601134204.2150602-1-praan@google.com/ > > [v9] > - Collected R-b tags from Bjorn, Jason, Nicolin & Sami > - Folded in the dev_err into the WARN for arm-smmu-v3 > [...] > Pranjal Shrivastava (4): > PCI/ATS: Ensure pci_ats_supported() is PF-aware for VFs > PCI/ATS: Validate STU for VFs in pci_prepare_ats() > iommu/arm-smmu-v3: Standardize ATS enablement failure reporting > iommu/vt-d: Fail probe on ATS configuration failure > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 +++++++-- > drivers/iommu/intel/iommu.c | 15 ++++++++++++--- > drivers/pci/ats.c | 13 ++++++++++--- > 3 files changed, 29 insertions(+), 8 deletions(-) > > > base-commit: 6666bde33b83cb4fc9b1f7ba6a3471479f76ce72 Hi Joerg / Will, Gentle ping on this, please LMK if anything else needs to be done for this seris? Thanks, Praan