From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3032F3603D5 for ; Fri, 3 Jul 2026 14:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090401; cv=none; b=DalolTDyOLE6UFxCNtbCcKpnJlfBkz8d4ZCRfXRSP+Yrf7ObQ++FAJKvDj2oLmdLRaqFJx30L9BlO0lzOOCH3YTb8C+YtDIkewcK/3/K9K7TDE5ceM0rGo40Z3eIJCQMO0y85FZAcKfcs9xXiiO4es8MSWeDiX7BPmqvPDvt8MI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090401; c=relaxed/simple; bh=dr4BeQSiZnpR1IwzMb3FXywWpykA6u0hAgioLbsXY/g=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=giXt80o6eJawARDGHyEkE3cWSBvOkYy9pJalSer5eiTuMbjsNacgM0H1oXVZouJ/XAXOgtUVQMEB9UdWDUV4TKPQ8F1T5EObPpfbzjg2PklDjWqjboMDq8V4hK5hhoSi48wWdE75z8JcFNHmd06KDaPE2NK0nWyI1oA+TpMUFHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=I9uEped4; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="I9uEped4" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-493ba701891so4749545e9.3 for ; Fri, 03 Jul 2026 07:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783090398; x=1783695198; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:date :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QB59yWoF1xJrXodhOCNsO8AMkW1gWMSY+FjvASquQ6Q=; b=I9uEped4GFKy/QJq6J3kzsqIarOXaMA6P7VdfvzDAsdY57C630g6SbvpY3F4cT4Uha Y5DJPK7cjAyGqIgAuO30NpvSmeL+ZEOgoqMmlmLSoza5Z8S5khOktJP/NHT5I+PBFD0F VrCZOMZJdHmCyZlOejTueT/xvXcjfyJwmq1FNgmSxlzndMtTuvaSp3NTrBzSKkSdLC8B lW7TJgOXKqOSjTfh75PoIAjtU7OAWP3llBfxH9P27Iz9UTL2N4HNGaaiVmby46wZX0k+ YI186HHOA0qV6tcOpPOJA88Hfk5lCmGaL2qBeW/sCpDFr03QVsr6PdT77lDS7NnHPNya 0vpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783090398; x=1783695198; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:date :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=QB59yWoF1xJrXodhOCNsO8AMkW1gWMSY+FjvASquQ6Q=; b=Nfk2z01UX6bKkC8AWSYoF6wW66z6mCYHQEB2E0jtUKRMBpDd+O98TJmFITdZR37f+J JkpSrF+KJGa4T6r37tASnn/0nY3UFJ9XVUOdbaJlAE2GUNX83gfp9ATLZoe3t+vbruSb /vuQN5RN7pUNssiED37N2oWZLzgJgG5AAElkXfL7hsWaAN5fCSpGiyscj6HmrHg1DLQF GUs/3UEMQbpwgp35oftIw5b68JpnbX4ixOF6lfWpp1JJRomk8kfeXY6+zNIoWuqq+Ko/ RQVfQRdYBVUlAPxcLH69PiQLLF7TTy7YQH6GIb14yCk+s5+fqOJLqF8MlnRCuqqlsAxc NBgA== X-Forwarded-Encrypted: i=1; AFNElJ+sxDA/DX1bibTQk8zS4BO938NcN9GjkWRKe+NK4v1qeePrWaMutHtSNY60G4sF6RkrFSwB2izjWT95KTk=@vger.kernel.org X-Gm-Message-State: AOJu0YwqAevAsBy9vMKZQfRwunH9SDqygbplSwQm6Q5ay3dwBXmd9G7r un8NuZvhFopBm624Q1IWbeWaj3Bp+c4f2TNs7ZvV45sFM/nElGrGpRml8wRIIpgUZXM= X-Gm-Gg: AfdE7cnrXTcXdCGN/8p/dMwGeSnsozWSfhEL3H05hQiYREWaQoJwtic3gvEmg1tM7x5 PgwBfOV0fwUJ9b41Bv+xGAo1NiZsgT6M9jfdMT8jC0Nf4IClTVFsDscVtFWZt0CYGhI9jbOvNFd m6rNELIkaFkjhwhHn/nEjvr7rBRpuawB1GhZX26Wclk5mCBv0j0N99LmntxMr1IvB6OTu93C0eT xj/A0myNVT6e6v939+/ZcyYCn3djhjUm11D6hFk4ubRazio6a2TiFw1x8KdfR4t5XacSmVUHJ0C weg4Bg1Q96wC3st1QUISyREBNgiO0LNJysvbOA3js97ZgO7yVmiUtJ2s/1jb7UKtOIWhpHRMhBL 6yI2Q0xMNEWEma1s3Y6I/JWUMunuyBz1T28y6D19GKrrvBOqdLPLXVl7bF/uklaLcAhbeJ1yfqy atRLLmCHK1R8w= X-Received: by 2002:a05:600c:1988:b0:490:e19b:bd99 with SMTP id 5b1f17b1804b1-493d0f43052mr2171635e9.30.1783090398625; Fri, 03 Jul 2026 07:53:18 -0700 (PDT) Received: from localhost ([195.94.145.62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477db8a44d7sm17320171f8f.9.2026.07.03.07.53.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 07:53:18 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 3 Jul 2026 16:56:44 +0200 To: Julian Braha Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andrea della Porta , linux-pwm@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Naushir Patuck , Stanimir Varbanov , mbrugger@suse.com Subject: Re: [PATCH v5 2/3] pwm: rp1: Add RP1 PWM controller driver Message-ID: References: <0b6a7f41-b753-48dc-b46e-77aaf0e999f4@gmail.com> <6babbdea-fa93-4cd7-8198-5cd3accc34cc@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6babbdea-fa93-4cd7-8198-5cd3accc34cc@gmail.com> Hi Julian, On 11:29 Mon 15 Jun , Julian Braha wrote: > Hi Uwe, > > On 6/15/26 07:37, Uwe Kleine-König wrote: > > IMHO selecting REGMAP_MMIO explicitly here is fine because at least to > > me it's not obvious that MFD_SYSCON enforces REGMAP_MMIO. > > I think it's better to use comments to document non-obvious behavior, > rather than dead code. > E.g.: > 'select MFD_SYSCON # selects REGMAP_MMIO' > > But I guess this is not really worth bikeshedding over. Honestly I don't have a strong opinion on that, but documenting is basically the same than just selecting the option (well with the addition of the #), so not really a difference. If there's no major concern about that I also wouuld prefer to expicitly declare teh selecion of REGMAP_MMIO. Many thanks, Andrea > > - Julian Braha