From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net] can: flexcan: Fix probing for m68k/coldfire
Date: Fri, 3 Jul 2026 18:53:13 +0200 [thread overview]
Message-ID: <akfoYuyHMAxIfalD@monoceros> (raw)
In-Reply-To: <20260618140147.142489-2-u.kleine-koenig@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
Hello Marc,
On Thu, Jun 18, 2026 at 04:01:47PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> When determining the device details was reworked in commit 5e6c3454b405
> ("net: can: Use device_get_match_data()") there was no replacement for
> the previous handling of non-of instantiated devices via the device's
> id_entry which then results in a NULL pointer exception. The only
> in-tree provider of such a device is arch/m68k/coldfire/device.c.
>
> Given the id_table only contains a single entry just hardcode the result
> of `platform_get_device_id(pdev)->driver_data` and drop the unused
> assignment to .driver_data from the table.
>
> While touching the id table, drop the unusual comma after the terminator
> entry.
>
> Fixes: 5e6c3454b405 ("net: can: Use device_get_match_data()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Given this fixes a crash (NULL pointer exception), it would be great to
get this applied. The issue is already old (Sept 2023, v6.8-rc1), so
there is probably no urge to get this in before 7.2, but getting it into
next and then 7.3-rc1 would be good.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-07-03 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 14:01 [PATCH net] can: flexcan: Fix probing for m68k/coldfire Uwe Kleine-König (The Capable Hub)
2026-07-03 16:53 ` Uwe Kleine-König (The Capable Hub) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akfoYuyHMAxIfalD@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=jeanmichel.hautbois@yoseli.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox