The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Bradley Morgan <include@grrlz.net>
Cc: anna-maria@linutronix.de, frederic@kernel.org,
	jwlee2217@gmail.com, linux-kernel@vger.kernel.org,
	peterz@infradead.org, qw3rtyp0@gmail.com, tglx@linutronix.de
Subject: Re: [PATCH] posix-cpu-timers: don't abuse lock_task_sighand() in handle_posix_cpu_timers()
Date: Sat, 4 Jul 2026 19:05:20 +0200	[thread overview]
Message-ID: <akk9UI6EKqjcW_cC@redhat.com> (raw)
In-Reply-To: <C816BC02-20F2-4E04-98D4-8C145FE1FA3B@grrlz.net>

Hi Bradley,

FYI, this is another private message.

On 07/04, Bradley Morgan wrote:
>
> hi oleg! I'm new to reviewing, so feel free to criticize.

This is fine...

But if you want to have a "real" practice, you can try to review V2 from Eric:

	[PATCH v2 00/14] Short circuit delivery for coredump signals
	https://lore.kernel.org/all/877bnb4uyw.fsf_-_@email.froward.int.ebiederm.org/

I won't be able to take a look until the middle of the next week.

> Would a WARN_ON_ONCE(tsk != current) be worth adding?

See my reply on lkml. But since this message is private...

IOW. tsk->sighand must be stable here or we have more problems. Without this
patch the "if (!lock_task_sighand(tsk, &flags))" check looks as if we can handle
the case were ->sighand is not stable, but this is not true.

And. This patch is trivial, but it connects to other (under discussion, nontrivial)
changes related to the wrong usage of lock_task_sighand() in posix-cpu-timers.c.

> For this patch,
>
> Reviewed-by: Bradley Morgan <include@grrlz.net>

Thanks again,

Oleg.


  parent reply	other threads:[~2026-07-04 17:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-04 11:09 [PATCH] posix-cpu-timers: don't abuse lock_task_sighand() in handle_posix_cpu_timers() Oleg Nesterov
2026-07-04 14:42 ` Bradley Morgan
2026-07-04 16:42   ` Oleg Nesterov
2026-07-04 17:05   ` Oleg Nesterov [this message]
2026-07-04 17:06     ` Bradley Morgan
2026-07-04 17:09     ` Oleg Nesterov
2026-07-05 12:27     ` Bradley Morgan
2026-07-05 10:18 ` [tip: timers/core] posix-cpu-timers: Don't " tip-bot2 for Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akk9UI6EKqjcW_cC@redhat.com \
    --to=oleg@redhat.com \
    --cc=anna-maria@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=include@grrlz.net \
    --cc=jwlee2217@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=qw3rtyp0@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox