From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A126E219E8 for ; Mon, 6 Jul 2026 00:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783296791; cv=none; b=sdHNgkcIkgrtnVSTieKHpR9LDOgbj5V+HhwhxxSCxO1xwtSU86cN4jGWbj4BdYTSd0u5HIjiBKLM9k+6ZmA7QV1NewW9XDgltzC99hVbukyY7KTWElUY7+/3QWGmW3x4soBEY7HKw2VeSkedguIEvTIKavAtrSLy5PK310aLLRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783296791; c=relaxed/simple; bh=6wtht9qeVhALo4Zoi7VNhiD2ovZBumoyHRXdEFeha3k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Olj9GOitJ0lwhlJpvVP3Q6QSbiictOCeWHDvs1MR8Lo6mMZN6g5QhJBDRJApPQyM40sbCxoxeDtMXS0Xv1s2DbAOJ80nUt1bt7NSMw1AUdyjuNxR+x9xo+rRFtNlf9yC7dKyCaLRzXKVISlTNdszEPXt6Sg0ZLcFDXVQK6F0GmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=GZMLyBT9; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="GZMLyBT9" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7e9f69ee6f4so2201293a34.2 for ; Sun, 05 Jul 2026 17:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1783296788; x=1783901588; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=65vNV6ez7HNjnTZnjKG9ch8gY34s41P1iqpCH0Wy9yw=; b=GZMLyBT9sB0pitvxmLoVwIBm5fUeodTQRAE8WL2gJwp9Jul0j2RK/xL++lwGxv7A6P zS5hRVKyxow5GPhRE+DjMKLf/U8aH2si1kAKOt5t27IpY0TfoCxTd9abF+qx0saTu6A4 uVTNfq0nAs8HB+HEmuzdmp0eLVtA5QEBIjuKFUesTQZSvK6caBTQAMn6GY+Xwvx35ga9 R0TPkxK7zl/cGASkHCnT5MFdaet5hblQ7/3L/88V6RorXVg+T85efXVdregOgIjSDCCs aBRgDlK4+9ohks3Ap1hfxnF4a893wvpZAMJ9JeXSbiXYg16P1M4BdMicbPt/WOzYBzpe tZ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783296788; x=1783901588; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=65vNV6ez7HNjnTZnjKG9ch8gY34s41P1iqpCH0Wy9yw=; b=BdVEzAO4VHq/DPQzA8EAH8bM8LwzVeCCrb4EAPiDE7gTqZ9Ah2CfHlaoedbEquf4+0 ULXctLzA0hZj0fkeNQAPw/TFgNJUWTUa3deno6FijodyqVAT0arO0GQU6AEKQgaYU/RJ 5hUDvAzbsPwWOi21ZweYVn2vj2uAlrwtYN2Iqs5g/1lvgWzN0wgVJrhEnskWNoWVrAiP h83OiEtJdcDSTufbDdPu7KN3s9m957CEKHcXzmnLq1u3ZnTn7ruG+bBzfmY4Dh+Mprc/ 5i+KpMe1bk4Whgbx6NuhVAcM05lLkBALbmtjNYyRJ0UECVGt4wG7nO69j8vNXhqiStQP Frtg== X-Forwarded-Encrypted: i=1; AFNElJ8tWegttZTy0mS7d+UWrTYYJBr0B8widdvkLm0kdD/Zvcd6w3ugaT+tZcN3vLv5Bj10rKQt/pKcenc4DGM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh5MCcnCM1YfHzFnBzgK6NquT0j4/3/LNZr+PmIQaHhCaulelv /k3A6ejZFeXbfVEJgzgDVURsokevgSFPaEsLqSjmUi7hrqEVehQdDDy8TZQRWUk+eFE= X-Gm-Gg: AfdE7ck+vQvjN1Ycr3CBylhGmZ6H/jX+CB21m8Lct78YHdMugs5aSngPejCJ7zW/nlp DdLRphVH3vLLteASJGyyG2585sJKtocYv4znF9iXgWLZ/XQQ0cGsIwRhdfZMP33bUQdr4RLcTso MgSJ2riIuHzEB8Z3HUn7nCb+mTGa+0kNRC67L298YhG9lLXQl0hG4TX3I6KJ0leIV9zxe3XkSAW 4aJTEb6DfWKZwG3PZq2Ob3GQ7+au2D7r1racH0jASj6rw2CBsKYvyadAg0faVSF/ViHQSUMO7aa yQaTbl6l6865s6ROBjHXIz8q+U9uuEeOhCu+gu3OdNCupyL/Az/LCoK+jZZk9s/SrbeEwawr+Bc Cnrj5JXwjjrssWa/Kxej9nf3SRzLJaEsuTLndfwDHHqWg8tgzrYdrJUZJaeCVNUuASm+IiS/AYJ Q05ArCF4UugVKYtk16f3SdVDgLTJ0dYMGXBhy/BSFuOmktCE7Dq6JnGbT/FwJIvB0mp7VwZhn2y DI+n5Iw0xlwflwU/TEnikaTYBQQwHbnLqZR1Ooms1R6dZyt X-Received: by 2002:a05:6830:82ba:b0:7e9:da5e:93f7 with SMTP id 46e09a7af769-7eb7ff98cd6mr5275306a34.26.1783296787587; Sun, 05 Jul 2026 17:13:07 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:ba03:1c5f:85be:5f65]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7eb542f07basm10587622a34.10.2026.07.05.17.13.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 17:13:06 -0700 (PDT) Date: Sun, 5 Jul 2026 19:13:02 -0500 From: Corey Minyard To: Michal Clapinski Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ipmi:si: Add async init to ipmi_si Message-ID: Reply-To: corey@minyard.net References: <20260703150955.3943082-1-mclapinski@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260703150955.3943082-1-mclapinski@google.com> On Fri, Jul 03, 2026 at 05:09:55PM +0200, Michal Clapinski wrote: > Added a new config option to allow offloading individual calls to > try_smi_init(). Saves 100ms on my system. This looks good. In a few releases I may change the default to y, if I can remember it by then :-). It's in my next tree. -corey > > Signed-off-by: Michal Clapinski > --- > v2: > - instead of offloading the whole init function, offload just the > individual calls to try_smi_init() > > I didn't implement the periodic retry feature that was talked about > under v1 due to my lack of expertise. LMK if this is a deal-breaker. > --- > drivers/char/ipmi/Kconfig | 9 +++++++++ > drivers/char/ipmi/ipmi_si_intf.c | 32 ++++++++++++++++++++++++++++---- > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig > index 669f76000197..c8fa445c1c17 100644 > --- a/drivers/char/ipmi/Kconfig > +++ b/drivers/char/ipmi/Kconfig > @@ -67,6 +67,15 @@ config IPMI_SI > Currently, only KCS and SMIC are supported. If > you are using IPMI, you should probably say "y" here. > > +config IPMI_SI_ASYNC_INIT > + bool 'Asynchronous initialization of IPMI System Interface' > + depends on IPMI_SI > + default n > + help > + Offloads invidual SMI inits. It speeds up the boot time. > + It also introduces a very small risk that something else might fail > + if it depends on synchronous IPMI init. > + > config IPMI_SSIF > tristate 'IPMI SMBus handler (SSIF)' > depends on I2C > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 9a9d12be9bf7..504d5b8636ba 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > #include "ipmi_si.h" > #include "ipmi_si_sm.h" > #include > @@ -2174,6 +2175,17 @@ static bool __init ipmi_smi_info_same(struct smi_info *e1, struct smi_info *e2) > e1->io.addr_data == e2->io.addr_data); > } > > +static ASYNC_DOMAIN_EXCLUSIVE(ipmi_si_async_domain); > + > +static void __init async_try_smi_init(void *data, async_cookie_t cookie) > +{ > + struct smi_info *smi = data; > + > + mutex_lock(&smi_infos_lock); > + try_smi_init(smi); > + mutex_unlock(&smi_infos_lock); > +} > + > static int __init init_ipmi_si(void) > { > struct smi_info *e, *e2; > @@ -2219,8 +2231,13 @@ static int __init init_ipmi_si(void) > break; > } > } > - if (!dup) > - try_smi_init(e); > + if (!dup) { > + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) > + async_schedule_domain(async_try_smi_init, e, > + &ipmi_si_async_domain); > + else > + try_smi_init(e); > + } > } > > /* > @@ -2253,8 +2270,13 @@ static int __init init_ipmi_si(void) > break; > } > } > - if (!dup) > - try_smi_init(e); > + if (!dup) { > + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) > + async_schedule_domain(async_try_smi_init, e, > + &ipmi_si_async_domain); > + else > + try_smi_init(e); > + } > } > > initialized = true; > @@ -2401,6 +2423,8 @@ static void cleanup_ipmi_si(void) > if (!initialized) > return; > > + async_synchronize_full_domain(&ipmi_si_async_domain); > + > ipmi_si_pci_shutdown(); > > ipmi_si_ls2k_shutdown(); > -- > 2.55.0.795.g602f6c329a-goog >