From: torvalds@transmeta.com (Linus Torvalds)
To: linux-kernel@vger.kernel.org
Subject: Re: 2.5.33-bk testing
Date: Sun, 1 Sep 2002 05:24:58 +0000 (UTC) [thread overview]
Message-ID: <aks8ba$1c2$1@penguin.transmeta.com> (raw)
In-Reply-To: Pine.LNX.4.44.0208312209240.1129-100000@dad.molina
In article <Pine.LNX.4.44.0208312209240.1129-100000@dad.molina>,
Thomas Molina <tmolina@cox.net> wrote:
>
>I've beat on the floppy driver and it seems to work well. I haven't been
>able to make it hiccup yet.
Really? I was looking at my cleanups, and I'm fairly certain they are
buggy. I just pushed an update to the BK tree a few minutes ago that I
think should fix it, but since I'm not a floppy user myself I can only
go by the source and trying to imagine everything that could go wrong.
Anyway, can you please pull the floppy patch from BK or apply this patch
on top of clean 2.5.33 to see if it makes any difference?
[ Now, in all honesty this should _only_ make a difference in case the
floppy request queue empties and another proces comes in and adds a
new request while the previous one is pending, so the timing for the
bug triggering is probably fairly interesting. Which may explain why
you find the floppy driver solid even without this.
Alternatively, I'm just full of crap, and this "fix" is bogus. In
either case I'd like to know about it ;]
Thanks for testing,
Linus
----
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/08/31 torvalds@home.transmeta.com 1.576
# De-queue the floppy request late, so that the higher levels
# know the floppy driver is busy.
# --------------------------------------------
#
diff -Nru a/drivers/block/floppy.c b/drivers/block/floppy.c
--- a/drivers/block/floppy.c Sat Aug 31 22:25:41 2002
+++ b/drivers/block/floppy.c Sat Aug 31 22:25:41 2002
@@ -2299,12 +2299,11 @@
return;
add_blkdev_randomness(major(dev));
floppy_off(DEVICE_NR(dev));
+ blkdev_dequeue_request(req);
end_that_request_last(req);
/* Get the next request */
req = elv_next_request(QUEUE);
- if (req)
- blkdev_dequeue_request(req);
CURRENT = req;
}
@@ -2939,7 +2938,6 @@
unlock_fdc();
return;
}
- blkdev_dequeue_request(req);
CURRENT = req;
}
if (major(CURRENT->rq_dev) != MAJOR_NR)
next prev parent reply other threads:[~2002-09-01 5:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-01 3:23 2.5.33-bk testing Thomas Molina
2002-09-01 5:24 ` Linus Torvalds [this message]
2002-09-01 6:06 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2002-09-01 11:59 Mikael Pettersson
2002-09-01 16:31 ` Thomas Molina
2002-09-01 18:03 ` Linus Torvalds
2002-09-01 19:00 ` Thomas Molina
2002-09-01 19:16 Mikael Pettersson
2002-09-01 19:34 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aks8ba$1c2$1@penguin.transmeta.com' \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).