From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Lee Jones <lee@kernel.org>,
James Ogletree <jogletre@opensource.cirrus.com>,
Fred Treven <fred.treven@cirrus.com>,
Ben Bright <ben.bright@cirrus.com>,
Support Opensource <support.opensource@diasemi.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/3] mfd: Initialize spi_device_id arrays using member names
Date: Mon, 6 Jul 2026 09:29:39 +0100 [thread overview]
Message-ID: <aktnc2e9rIzG4lo4@opensource.cirrus.com> (raw)
In-Reply-To: <f83c8292e7e3ba9425792591fb136d4ae1468215.1783003256.git.u.kleine-koenig@baylibre.com>
On Thu, Jul 02, 2026 at 04:53:40PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> spi_device_id that replaces .driver_data by an anonymous union.
>
> Also adapt spacing and usage of commas to the most common style.
>
> This patch doesn't modify the compiled array, only its representation
> in source form benefits.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
Cirrus/Wolfson bits all look good to me:
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-07-06 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 14:53 [PATCH v1 0/3] mfd: Initialize spi_device_id arrays using member names Uwe Kleine-König (The Capable Hub)
2026-07-02 14:53 ` [PATCH v1 1/3] mfd: Drop unused assignment of spi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-02 14:53 ` [PATCH v1 2/3] mfd: Initialize spi_device_id arrays using member names Uwe Kleine-König (The Capable Hub)
2026-07-06 8:29 ` Charles Keepax [this message]
2026-07-02 14:53 ` [PATCH v1 3/3] mfd: Unify style of spi_device_id arrays Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aktnc2e9rIzG4lo4@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alexandre.torgue@foss.st.com \
--cc=ben.bright@cirrus.com \
--cc=fred.treven@cirrus.com \
--cc=jogletre@opensource.cirrus.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=support.opensource@diasemi.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox