From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F9FB2F290B for ; Mon, 6 Jul 2026 10:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783335376; cv=none; b=i9HzRsfsARPf4ITxj9eVNUFHt0Z6WpWAVug4iMRVXss4k/+KgMdJizpEN2mNT1E1fvJlybtG+kP6cUqKv1SAKflSK7EUMOJ3w7o1WLIR3RKG8AGJ2l0nuiKcZBhsr7p52O9888OGC7bXzhDroD3balewWcuV3GLfd/Lv4JOFMQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783335376; c=relaxed/simple; bh=3wEprY72kVJPX73cGbaDluxrU1g56xSSUPXF+d8Mh00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NhxTgH3Z5wt+ZFJ+Fte1a4ZW5KXJcN58Y99WbO0nWS0Z3H5ae+rgl+utG/8uyiAVdBuIhP1zI+D6u9kT8R4SpgSo+em0kfg3wZHZS3qlO140UsIwqYQPJMQD1+iLWQKWwiscoiluAQew3h3+4YJjJEBccn4DhaeMP7KED57YUK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=B34+q/kz; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="B34+q/kz" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D6D1E32AD for ; Mon, 6 Jul 2026 03:56:05 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F2DE63F85F for ; Mon, 6 Jul 2026 03:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1783335370; bh=3wEprY72kVJPX73cGbaDluxrU1g56xSSUPXF+d8Mh00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B34+q/kz2dpUJGIRDhxjiFt3/QofaL5l0f3AqKrn7NPxy7fwenu3ZezHxgbgB8Wh3 nUL2PSOrEdVPnC6oTRMJj9PZIyx0SU119BOXqC1lFG2RmmoNoSyOqzvDXKI5aHaST9 FkVQu3/qHV7j52aF6YTP+6+G8F5e818zIoXUgQNg= Date: Mon, 6 Jul 2026 11:55:58 +0100 From: Liviu Dudau To: =?utf-8?Q?Adri=C3=A1n?= Larumbe Cc: Boris Brezillon , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Heiko Stuebner , Grant Likely , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sashiko Subject: Re: [PATCH v4 1/3] drm/panthor: Check for sparse binding range overflow Message-ID: References: <20260704-vm_bind_checks-v4-0-4705b6ca9f8a@collabora.com> <20260704-vm_bind_checks-v4-1-4705b6ca9f8a@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260704-vm_bind_checks-v4-1-4705b6ca9f8a@collabora.com> On Sat, Jul 04, 2026 at 05:46:44AM +0100, Adrián Larumbe wrote: > This check is being already carried out further down the call stack inside > drm_gpuvm_sm_map -> drm_gpuvm_range_valid, but it's best to fail early in > the driver before GPUVM functions are invoked so that we won't waste time > allocating vm_bind context resources. > > Reported-by: Sashiko > Closes: https://sashiko.dev/#/message/20260623204220.CDB1B1F000E9%40smtp.kernel.org > Fixes: 12cf826bf1dd ("drm/panthor: Support sparse mappings") > Signed-off-by: Adrián Larumbe Reviewed-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_mmu.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c > index 31cc57029c12..163231c1703d 100644 > --- a/drivers/gpu/drm/panthor/panthor_mmu.c > +++ b/drivers/gpu/drm/panthor/panthor_mmu.c > @@ -2975,12 +2975,16 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, > { > ssize_t vm_pgsz = panthor_vm_page_size(vm); > struct drm_gem_object *gem; > + u64 end; > int ret; > > /* Aligned on page size. */ > if (!IS_ALIGNED(op->va | op->size | op->bo_offset, vm_pgsz)) > return -EINVAL; > > + if (check_add_overflow(op->va, op->size, &end)) > + return -EINVAL; > + > switch (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) { > case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: > if (!(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE)) { > > -- > 2.55.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯