From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F11D1A6823 for ; Mon, 6 Jul 2026 12:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783340160; cv=none; b=OcB66MvTUqkSeCDzJrITrPcops24gZdTcaxrntxmd0qFYgYEFZNUiiSy2BYgu5qt5Jh2bZGBme9LsYMVaUurn6pgTQ1vM0Tkmt2z4ipSqKLPHzxoO+U4MTrYYL7Oc4HMAkPSvQIshurBNiosGI7F3R+SlLfKjIFkNiXtrFu5IXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783340160; c=relaxed/simple; bh=UQMA3O1KgP0d7XQxweBiJpijztQkgRLvbrdY3b1INQM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qXzisaBYSQuJOSTTrR9no6hvw7x3LBwuhSLH655Lhg1VTAjhy5P+z3brlwx3ta7gzWbQ7idscdhnQDhvde322rMsfQq17aa3iHbxF7s5bKxGDDTqbRgN+BdBb2EMpoHTP0N4zIshUMkV3f3SZZP0mjyIWPcAzVS2MfUeY3Ez37U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FVUT0scS; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FVUT0scS" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-697bd21fdc2so4839828a12.1 for ; Mon, 06 Jul 2026 05:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783340157; x=1783944957; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=bzjuVY716f5PrMn/z/kq+yIAQezspIShPITZBm544Sc=; b=FVUT0scSAcndB45z+sOXmd7M8Zs6oda+hkiKHcfhouPZuF6Vk2XAWlFBZRW0yqCF3j TC0W7+PTDC4h30v8QCfGomzp+xMoOSu686r0D4LSobrtMXZWNvqO5RBdRGjodsao8IVE 5TJ8Tn/u012WsJ7BB/GciwBWUYMZTHK/rwJ6QfJbOETWpJ2a5o0rjh6KW6swCnDpmd5a MfxjHCxjgIj7c0EfGKGkKZlNwnznnqMdPHtuP/jU/VdNrrGZlxxkN8Zcy0sB8FITJQVg zfz8vYa/HcgH7454+JivWDWjbiGH/U1E4/QgCqSBVi+5X521pJw2LZhOqM+ReY6FXVVw q/RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783340157; x=1783944957; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bzjuVY716f5PrMn/z/kq+yIAQezspIShPITZBm544Sc=; b=Xr4TFAZticCOy2dO/whzmd81FdsFP4YBAAV8mDmzbA6gCBhE1Bysh9GhGG23pgYDx8 vHB1RuqmM9X2MsTY+ZdFwxgyX589HSBvDxR3WwsFgw6xrCrph3J95qgpwC/3BkrM6nkf n/c1S7pwMnE/oNE/oa20ikHd6gziZF+5L+fLl/JdSrbwFAqqSKNBDlDYHtXRwV1BdO1i R5YDMehBJ7a17HH1iU0LdFPxMOECEv+r3g248F1og7uaQVT3G2k3wMyfWYwHBlBKG41j JVr9zy/z3gLvbNj0yTFOoCKjfnWVZXwIJZ9fN5948hGLUy3bVboK2IH1W/p9tiYDZnez AiPA== X-Forwarded-Encrypted: i=1; AHgh+Ro1Z3MDBhnoCzq42hJXEj/MrAtXNTucLPIvYqDI6mWxHmmbULS/Z3sLQOj+UnQHCwmOV6DQYBm44BGTboE=@vger.kernel.org X-Gm-Message-State: AOJu0YwiiZdGMGqOV5i5tPHwbSgLAMvDakoYiqiIDmah6/DBMrjBJkND iqguu9o/z/UElq6XcMBk8MBstRCY5pdv1b0g3VJCngzqe/o0zIqXout2H1p/PsHiM2bvP7gd1wd 0Gx/iH/M= X-Gm-Gg: AfdE7ck1Xf193TNeWnTJAh3GOTpyxENJTH4ls+iE7ZyrJ4LWW5IG1fnrwsyhtB4QhxI Un08fguwu1ngdHfm8lqcLLYRsY4hNE2rs589b3Jjj6Dubm5MsjgjEMyPwmVj6nBNN1YTJdzOx9/ /2v9MG4sPkb6uLDk7eFmwMsh5KXD9rBXpkWuThZRA5kuOYcyr818CNcdhSzKLdzWsDsEpCWEhfu +rSvCx8r2QEVYgO5YY6sxGCtee0Xr8XGlDQfjeYGnm4Zbh/bG1Zw2j8uEHcF1mecFbNPsh3r5Nc rS79XnBJ07ubokmOMQhSwPTBIuMrKesxPc6AX3u4sHRjiQuwb6buZ2LbI1Ve4jkUPdRiJqg1uj6 DlBHLJs5hBuc9vEDi8V2iwjrTwpe/fj+MOA+Pz8sON8KHYYCouwYjccVjFOOm9jW9/gs/Ndq31s T8c1BbvvbB2Mc= X-Received: by 2002:a17:907:bb8d:b0:c12:34f3:9a33 with SMTP id a640c23a62f3a-c15a685045emr11805766b.54.1783340156747; Mon, 06 Jul 2026 05:15:56 -0700 (PDT) Received: from localhost ([195.94.145.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b60550desm751619566b.7.2026.07.06.05.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 05:15:56 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 6 Jul 2026 14:19:23 +0200 To: Alex Tran Cc: Andrea della Porta , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: pinctrl-rp1: Make use of str_hi_lo helper Message-ID: References: <20260705-rp1-str-hi-lo-v1-1-1b452a5a8780@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260705-rp1-str-hi-lo-v1-1-1b452a5a8780@gmail.com> Hi Alex, On 09:01 Sun 05 Jul , Alex Tran wrote: > Use the str_hi_lo helper API to print value > of a pin for debugging instead of using > ternary operator. > > Signed-off-by: Alex Tran > --- > drivers/pinctrl/pinctrl-rp1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c > index fc4ed68ea5ac0bd272afe82076a36e93beba0539..dd0e85c2ca33a1ac506bf7ff0ceb424a7bde97d9 100644 > --- a/drivers/pinctrl/pinctrl-rp1.c > +++ b/drivers/pinctrl/pinctrl-rp1.c > @@ -1085,7 +1085,7 @@ static void rp1_pctl_pin_dbg_show(struct pinctrl_dev *pctldev, > > seq_printf(s, "function %s (%s) in %s; irq %d (%s)", > rp1_func_names[fsel].name, rp1_func_names[func].name, > - value ? "hi" : "lo", > + str_hi_lo(value), > irq, irq_type_names[pin->irq_type]); > } > > > --- > base-commit: 2b763db0c2763d6bf73d7d3e69665222d1f377cf > change-id: 20260704-rp1-str-hi-lo-cc64c3614be2 > > Best regards, > -- > Alex Tran > Thanks for your submission! Reviewed-by: Andrea della Porta