From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A880430CCD for ; Mon, 6 Jul 2026 12:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342219; cv=none; b=ZlEFbkGUfHP0qtCBgNnzms9suB0SqMVqSDSaFmBT7yZwLtrl0M8sBvHJRla7Xa0Wu0eMxAVmos3LVwQwhD/ZSBE7/fQd5Ui8LhXKXjdXVgdSWlhmLoL14XrqZ6wZqGoKQe3++VbPhQ7rlyu1Ls7HjmjBRiQ4isASoskDqYwfv+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342219; c=relaxed/simple; bh=A330RMdAPBip6Q3eWE7qsyi7+bB1bqtmQP3YOZoJoRQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KHEjbZzwDcSTHafz9Eh8u4VoL9t3wNIz4piZ1vdAxVcxoxWHsGXBhQ9icIxbzuZTo5vaAOVn4DgrMo2w3nsLGct3gfgOLKD6s1MySBFPZjDmdre8zIWHoTqtgya86vJwO1jgtLmWzQM2qyGnLQ8Cz+UUSmEoqaXGJ0qyZr3n0uY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q9iHldaB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q9iHldaB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DCC71F00A3D; Mon, 6 Jul 2026 12:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783342218; bh=x/DflsyFZMMMayN88xFKrPbO4xIeLNs4y3Zz8/BKzSU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Q9iHldaBZZwuLrQUeNXYgasOU2CPJWjyKJQUSk3YvITH4PYsI74DgvixGO0lHw9w4 Ld9xF6TsHb/VZZqOkmpgL/fwpuUkBvgPVGIk9rpG/7B2KIRCWoq0UZbhWixAeR/T5w oAvVGoymC+QqnF8/A5W9jVzeO1xB+k6Et+fSz8g/nDZQywn73t8di44o+mH+rxLer6 NGIPWGelihVNAbyow6cNKnmgVXmHwL0BaBwhn99gLKeG4Fku0o4H/8wc3ANkI7mMxz 1YC5RHw385RqNOK85Wn6kH/4fzrhsvYcoUpMBNDHkzhFYhHLeKhGFnZCBxJj/n21tr Mav+lDo9u7UDw== Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfauth.phl.internal (Postfix) with ESMTP id CF10DF40069; Mon, 6 Jul 2026 08:50:16 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Mon, 06 Jul 2026 08:50:16 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTF5xoQbiJ989r5bQ3iWyvjnYkkpnn8LZ7V/DF21MHB1XhwEDrMV3RpigyPZf9Kjbd afP+mbhtkFcxAR0V96R7snet1ndSR1y+kbEFZqDtXLcgbSQ0fqMhvpzLpvMrWPvM5KjYDK GEc293eRnQOyLMVp814avRhM/uJcgPZF5ND3c5YgaKA2HC866/u0RFdGAaEQfuRV9ZZNj+ fW6FFAX1knGAG1vcgwAvBk1xRYiQYoB2JtvDNTjC/WAezs+bDmPlNgu7fVPslaFpU1mgUZ a3St44qB9vtXtxWWPrw5w90yvN7I9P81VgZ1jhxatN6PE3VdoBWD9+OzK83OWGkY3GCdo5 KPnKPFF/IECcZSnvNci1MgpUcjxcEAP7zgwvmQYNmJSSsxJCP63svv855l/1yEpypATk3E onW8pX/4CnX+4VAr7yQpXm1vQm60XLuen732kMrkEwSW16gqg3qhwaI0Yi4COVhPoDwB37 IKEY2EuVna9bSVlxZuwLoRxQyg4ilz3KygVsTcogPuefre6ttKXkQy1G1kfOxe+jL/M2mt L3FQ+pwqbUfIlpGLH6u3KtB3gW1t/jFSWQRI49xUSLk9N9zn4EEUI33CrYRy5I4t9XxxXF t5er9dSmANX5Pz9QmuvacnuL0XCbbBlTrB2wEqBHk5j+EDGg4kD3gS4R8A+w X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Jul 2026 08:50:16 -0400 (EDT) Date: Mon, 6 Jul 2026 13:50:15 +0100 From: Kiryl Shutsemau To: Usama Arif Cc: Andrew Morton , david@kernel.org, chrisl@kernel.org, kasong@tencent.com, ljs@kernel.org, ziy@nvidia.com, linux-mm@kvack.org, ying.huang@linux.alibaba.com, Baoquan He , willy@infradead.org, youngjun.park@lge.com, hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, alex@ghiti.fr, baohua@kernel.org, dev.jain@arm.com, baolin.wang@linux.alibaba.com, npache@redhat.com, "Liam R. Howlett" , ryan.roberts@arm.com, Vlastimil Babka , lance.yang@linux.dev, linux-kernel@vger.kernel.org, nphamcs@gmail.com, shikemeng@huaweicloud.com, kernel-team@meta.com Subject: Re: [PATCH v2 2/6] mm: extract mm_prepare_for_swap_entries() helper Message-ID: References: <20260706114320.1643046-1-usama.arif@linux.dev> <20260706114320.1643046-3-usama.arif@linux.dev> <642efd6d-7366-4641-a999-2d419fd38f8d@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <642efd6d-7366-4641-a999-2d419fd38f8d@linux.dev> On Mon, Jul 06, 2026 at 01:23:29PM +0100, Usama Arif wrote: > > > On 06/07/2026 13:01, Kiryl Shutsemau wrote: > > On Mon, Jul 06, 2026 at 04:42:04AM -0700, Usama Arif wrote: > >> When a swap entry is installed in a page table, the mm must be added > >> to init_mm.mmlist so that swapoff can find and unuse its swap entries. > >> This double-checked locking pattern is currently open-coded in > >> try_to_unmap_one() and copy_nonpresent_pte(). > >> > >> Move it into mm_prepare_for_swap_entries() in mm/internal.h and convert > >> both callers so it can be reused by upcoming PMD-level swap entry code > >> paths that also need to register the mm with swapoff. > >> > >> copy_nonpresent_pte() previously inserted into &src_mm->mmlist rather > >> than &init_mm.mmlist, but the insertion point is irrelevant, mmlist > >> is a circular list and swapoff walks it entirely from init_mm.mmlist, > >> so only membership matters, not position. > >> > >> Reviewed-by: Dev Jain > >> Reviewed-by: Zi Yan > >> Acked-by: David Hildenbrand (Arm) > >> Signed-off-by: Usama Arif > >> --- > >> mm/internal.h | 10 ++++++++++ > >> mm/memory.c | 9 +-------- > >> mm/rmap.c | 7 +------ > >> 3 files changed, 12 insertions(+), 14 deletions(-) > >> > >> diff --git a/mm/internal.h b/mm/internal.h > >> index 430aa72a4575..0360648e5726 100644 > >> --- a/mm/internal.h > >> +++ b/mm/internal.h > >> @@ -1955,4 +1955,14 @@ static inline int get_sysctl_max_map_count(void) > >> bool may_expand_vm(struct mm_struct *mm, const vma_flags_t *vma_flags, > >> unsigned long npages); > >> > >> +static inline void mm_prepare_for_swap_entries(struct mm_struct *mm) > >> +{ > >> + if (list_empty(&mm->mmlist)) { > >> + spin_lock(&mmlist_lock); > >> + if (list_empty(&mm->mmlist)) > >> + list_add(&mm->mmlist, &init_mm.mmlist); > > > > The patch is fine, but the name of the field is awful. Seeing mmlist I > > assumed it listed all mm_structs. It has to have "swap" somewhere in the > > field name. > > > > I can send a separate patch once this is replaced to replace mmlist with > swap_mmlist if that sounds better? Yep, better. -- Kiryl Shutsemau / Kirill A. Shutemov