From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA8B8420899 for ; Mon, 6 Jul 2026 12:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342763; cv=none; b=PGaWyeZmZCyYsW098infkor6jIWwnNq8Pad+PERwzYrEfoawFbMiyFEBNatlSMQKeAaSLtBmCwFupqDx9skahJRDQ30Z567JnasTPaSIfK1Uxvaz85P9VZ196dRTHCSVs2VBFcciI1sukhPeBWjsIvXc4mrnXtZuYcxoL5CpEF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342763; c=relaxed/simple; bh=fZ/B3gG++yQfFhCXthmcxC8ySJ3revEyZ+ds/RRhI0M=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UcBWusmADJShvqmrje5bggfWQrMgBPjn3YS1gIuNmNk3rkhbHbTORuHqe1/FzTsCTLcFnkL8XjKyKHJvbZt/47BSNi1w0XWTwSXgFH097xqw7zZANyd6Uyadz6ZFHo9NU6Q34/TgTvzjI3/HRmqx1iVwOmbbFOdFEwiICb3CwYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RhAWTim8; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RhAWTim8" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493c19bad03so27799185e9.2 for ; Mon, 06 Jul 2026 05:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783342760; x=1783947560; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z98nvf77VmSsopBykFntdijBwu2o8RPbMfIs/vHx0Vs=; b=RhAWTim8vAwsqjrMgdylsjZbfRyohFPGpEvIV3c/pQAOFCWzwUJ246rkOPO8CbRgsR 5obl29VkMH4QVgj3N1tc5YYxFvRjz9/VGXh9krOHoW21yy9kRQyyP1+hKUZPVI9kH7t5 2F9kBikYCz2VYqzoN3C4EGTWjmIfOycCWCds0dfzAmjAV2QTLIJum+lagk3sY1HqtLc6 sIJ50LWO82xBkjd1d5HKkGMxa9ICryhOLcLKL7iVHEdvspNGgujZMNvPCOx7jL2xojPH orN2lzSgcrG2t0MGN6m2i6shTj467BlK9+GwHv6BN8F1xNBz+3W4a1t3khthACU596OE kzJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783342760; x=1783947560; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Z98nvf77VmSsopBykFntdijBwu2o8RPbMfIs/vHx0Vs=; b=q3fJ2kWBAap6IgFubX/ILugVP2y1Nun3tfBRXbFb5N3qZDekCbLPEhUIYVh0bG3iz3 OhTjMUWDB2efAzZzFngd5p9XNOvwfnnZY7T39doqnBTFMrIYB6V4FkMzvhVNNOerepuF fQHcnkODUyJpOTfLmWjhMJA0bQYjby1LkFTbJsvNEd+xZWn2VEURC2H3TSWe2PRDmfjP WeHnF1qJiIQQBa/EkXBJOL24xcM1ksJ+PLlFszDvyoflDByFCVgBbJQBGjaJEhmWG0Np jz0FI4O6pdjS41HhLPkpOI7q9onhfgz9ZSrULJggAGHhCTmYwAzKDEKRIR6AL0T44o+r pyRA== X-Forwarded-Encrypted: i=1; AHgh+RqIskj8CoLZ63ImQHPOuB4S1YoRrfnWIybSvGRDAmvzDY8MLZbTbs5MAYMehbZH+MmfZGVrHrcO5DQZwUg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv6nrhDA/5pE/2ve5ItQKfg5v+oDKgvUT1z1z/syKod+n6XsuB K4WzmJLjmX4NHNBJShcGV/TSk14K0PSvSQLwF8j2lS251MIBVIl2mkuH X-Gm-Gg: AfdE7ckS6N0RBUnNQ1Mild285UsIz6GALUgZrTR0xHIx+UukJuexW7goi3/5Dqh+Ote ASAV1HYVatF8u8ksqZYhESUw6ksuadlg49ULSD6+yZmX0zGufQgdSW1g0MTJVbuMA+7DbCdCWRR fuxi1PzMnkLEP1o6VhVl9Iqvo5tMk/EtlfSHhpaIizV7WYJmnohLMhuDfcbR97CeDlywThuAH3N A87GgKBPJ2SEYf1LaMbJ0O5hnOvV7ey3x0Q8CDr478rtQEToRLLxkZp8uE0dV9m3biuSioYgcDT TB0o/vNl/kaaimUX9ZJq9SXhg2YYGeb2G4HwPwxFp1QosWdEvCl8bbT1F+rHaeuMZGZnS0PDkEZ qA6M1QBjarxWjh6eZ5a23UTqkCy9gI48Znq4gIvqOS1pajM8mZsOUzaMgwTeQkUOX7ALNH1DurO 6NR3/2nrPRM7l4jw+mWW/J59iCIJa81c9XKrFcn3ltGhTd/A== X-Received: by 2002:a05:600c:3e85:b0:493:b771:ddf9 with SMTP id 5b1f17b1804b1-493df0413d1mr5456605e9.1.1783342759840; Mon, 06 Jul 2026 05:59:19 -0700 (PDT) Received: from osama ([2a02:908:1b8:2060:bfda:c630:e88a:7a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccd9d620sm295986765e9.1.2026.07.06.05.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 05:59:19 -0700 (PDT) Date: Mon, 6 Jul 2026 14:59:17 +0200 From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/bridge: tc358762: use devm for bridge registration and DSI attach Message-ID: References: <20260521215228.188615-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260521215228.188615-1-osama.abdelkader@gmail.com> On Thu, May 21, 2026 at 11:52:26PM +0200, Osama Abdelkader wrote: > Replace manual drm_bridge_remove()/mipi_dsi_detach() in remove with > devm_drm_bridge_add() and devm_mipi_dsi_attach() in probe. Also check > the return value from bridge registration. > > Signed-off-by: Osama Abdelkader > --- > drivers/gpu/drm/bridge/tc358762.c | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c > index 3d75d9cfa45e..3a021ca895f1 100644 > --- a/drivers/gpu/drm/bridge/tc358762.c > +++ b/drivers/gpu/drm/bridge/tc358762.c > @@ -293,25 +293,17 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) > ctx->bridge.of_node = dev->of_node; > ctx->bridge.pre_enable_prev_first = true; > > - drm_bridge_add(&ctx->bridge); > + ret = devm_drm_bridge_add(dev, &ctx->bridge); > + if (ret < 0) > + return ret; > > - ret = mipi_dsi_attach(dsi); > - if (ret < 0) { > - drm_bridge_remove(&ctx->bridge); > + ret = devm_mipi_dsi_attach(dev, dsi); > + if (ret < 0) > dev_err(dev, "failed to attach dsi\n"); > - } > > return ret; > } > > -static void tc358762_remove(struct mipi_dsi_device *dsi) > -{ > - struct tc358762 *ctx = mipi_dsi_get_drvdata(dsi); > - > - mipi_dsi_detach(dsi); > - drm_bridge_remove(&ctx->bridge); > -} > - > static const struct of_device_id tc358762_of_match[] = { > { .compatible = "toshiba,tc358762" }, > { } > @@ -320,7 +312,6 @@ MODULE_DEVICE_TABLE(of, tc358762_of_match); > > static struct mipi_dsi_driver tc358762_driver = { > .probe = tc358762_probe, > - .remove = tc358762_remove, > .driver = { > .name = "tc358762", > .of_match_table = tc358762_of_match, > -- > 2.43.0 > ping.