From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84183416113 for ; Mon, 6 Jul 2026 13:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344389; cv=none; b=bQUVLCvV21s3eN8YoA9tiqKIR6bWUqqdEQ82QB6fuyQgcD0xeKk3qupUh6KTG5rD4qhG5kj8gc3ZsCqqpTB33kLvUBkXlcOlyq/bKz9UiSiV5fY0Ol7G+MdioSIBxqONL6t8MJQuOrUE5/AXJKOvW1pSEzUIoyMvOSrXzShR1Gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783344389; c=relaxed/simple; bh=2X1TGST7uNQ4I4baBGRTZMrzsyrjAmmsqM/GevpKbSQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UypH9axmBniKEsPYt/+jhUh4iPvlqGobpg/ucdOn9RvKuP9KbwuoT/1wdzPLycDNfuiDwwSyE9IjfNMK9RcGXWQf5ROkrsH86sdMh6CjVX+uq9P2wChwyp1i+HRkvkKIAbQDKFwjgD/v8cFQnIJOuXpdluQNI0/a/1oOOD65ppU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hs73lySi; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hs73lySi" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493d3135f62so10244335e9.2 for ; Mon, 06 Jul 2026 06:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783344384; x=1783949184; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VewHMeV2HgLnExdf3eHCgLjBbEBUzVfCGkn2dqN19pw=; b=hs73lySiIQQG8zGbGy8ac2CZfCccA7sAEDMOwRwP9xHtM6Uj7QnfGnFODkjpfSzz8+ NvhDdt9FUZlACoI6zT6N6gfvDJ87SZG7UGRXjX6OgsUlQyIQFQ42HyEUjG4eN96tLb0+ gzqsXo8hI+MLl3zLe44CvGQA4ywU6rC+oPonSg1qWsNBLaSTxB8xZdPyTNfWDmIi9uVZ /hCw+kU+dpU9xvkUAl4GqlBq4pEb+AFyn1X+4N9yFsV6ZV1FeMCjYJvGuejOThR7zGr1 UidPdQiPTDzakebinsBGAvYRI/m7lETQv/177p+wrtEZ6vl9UL446Azaov0yHQ+Cl0Qa bj4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783344384; x=1783949184; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VewHMeV2HgLnExdf3eHCgLjBbEBUzVfCGkn2dqN19pw=; b=ncO6rAMxv2vQQGeT73NPcEwxHOUHjX0fvdjsGW7+R8JEDB/O6hkoznaaSnPgCs9x7m 6H4WzU5iiAdiRbdNqThL71GXqIopYK6WY4WBBTKhb3ATY7wnGnN9P48v9XYplYLcrj3s sIaQbBEn21a9UKrj4JvM+uGdNCIRExUIoYmFlgS4VbA3vFr+zxmW6hKeB8bLQI0I6QsM jiQAADknYL/DMKO+fVCE6+ECyu7Ch7sCLeGeofxsd03afNyY97YumawiyHgNvJtbIsO4 8p88kbSWCpzsF/RZM6ljZV85DsxG3aEj2aNgoOLR+zsWvzn+/iNUfAwr1Kun1KWjvVfK y49Q== X-Forwarded-Encrypted: i=1; AHgh+Ro77xwpUhBIaI9bogMFomzyt6NZROb1ROf129Op+dGVXCh0Q6DuMkY29m2NHzVb5tG4CvrjSglIaIL0Eu8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0zyIgO9E0Z+eSxzZhoPW/x1OS6ABio5ngf+yU2modOkVwHauS IA6RlwDVYUEhizgpzMiA7d62FcrdpKuJtdCx2bhgksR1EeC7Qn0JStVit1o9oVrxpjo= X-Gm-Gg: AfdE7ckY6bHTxBZA++9+J/JhCZFBsqnlh4MQKcHR58pFvIsjylSCZBIH+NMwl7W/qZv KK/6XhX8O5B8cjkG3uXS4z5iEl1iG24ZEdJ/jkiFr6kGTNVrrab4Id3oBgtNye3n6OiIpqqvaBL tkUX8HUY0hEV5hv/I0b5Ywsnt34rBm22L4rQy1NvRlGWEFHo7BkdsGF1P5e8J8bALs0AhOyZ+9H +perCZ5ClOozEoU6w/hVZKXEjf2K9ZuXgz46AyWcJ8oP/se8otoKrM0GGsCmRSPHI5UHeWhtIto ec22yzJltT+W4zorB7utFYFr0I8si68D5GKQHppDVWrHrUkSNYxGlsB0ZMONSIa0Mojdv6Aood9 /Og0dfcjPYoagfpHwlsCCoJSvIMfAw9uR+2e639LgrlKQi2Keyky5rou3qrMXu5Vg+hNFcro3Ys 3MzpINFrfhRvvIXhhuzm+sON0fO1AqEpBIbX8= X-Received: by 2002:a05:600c:6a0d:b0:493:bc4a:fb51 with SMTP id 5b1f17b1804b1-493df077ef6mr3952495e9.39.1783344384207; Mon, 06 Jul 2026 06:26:24 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff24:7210:1bb5:914d:5d25:d048]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4a343csm326732325e9.0.2026.07.06.06.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 06:26:23 -0700 (PDT) Date: Mon, 6 Jul 2026 15:26:18 +0200 From: Stephan Gerhold To: Miquel Raynal , Manivannan Sadhasivam Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] mtd: rawnand: qcom: Add MDM9607 Message-ID: References: <20260608-qcom-nandc-mdm9607-v1-0-4639a0492274@linaro.org> <4kdjxrn3bxg7rhkdovidxv2b2f6evnknng7gjtbz7pahyqaakh@qkgxaz6xlav2> <875x2smf39.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875x2smf39.fsf@bootlin.com> On Mon, Jul 06, 2026 at 03:18:18PM +0200, Miquel Raynal wrote: > On 06/07/2026 at 14:55:26 +02, Stephan Gerhold wrote: > > On Mon, Jun 29, 2026 at 05:46:57PM +0200, Manivannan Sadhasivam wrote: > >> On Mon, Jun 08, 2026 at 03:20:21PM +0200, Stephan Gerhold wrote: > >> > MDM9607 has QPIC v1.5 that supports the OP_PAGE_READ_ONFI_READ command, but > >> > is missing the rest of the hardware changes in QPIC v2. There is also only > >> > a single clock that can be controlled using the RPM firmware. Document and > >> > add the new qcom,mdm9607-nand compatible for this setup. > >> > > >> > Signed-off-by: Stephan Gerhold > >> > >> You could ammend patch 1's commit message with the information I shared in the > >> reply. But nevertheless: > >> > >> Reviewed-by: Manivannan Sadhasivam > >> > > > > Do you want me to resend the series with patch 1 commit message > > adjusted? There were no other changes requested as far as I can tell. > > I was mostly waiting for answers on my questions from the DT binding > maintainers, but I understand they must be too loaded at the moment. > > > I think the current commit message there is fine, especially if you add > > the Link: tag during applying. The extra context will be there. > > > > If you want me to resend, I would just replace the second paragraph in > > patch 1 with the following: > > > > --- > > On MDM9607 and other recent SoCs, the QPIC hardware requires 3 clocks > > (ahb, core, aon). However, the access to these clocks is restricted to > > the RPM firmware that controls the shared power resources for the whole > > SoC. The clocks cannot be controlled separately, there is only a single > > RPM_SMD_QPIC_CLK clock that implicitly enables all of the 3 clocks. > > The only exception to this are some IPQ* SoC that are not using RPM, > > there the clocks are directly controlled by the kernel via the clock > > controller (GCC). Require only one clock in the dt-bindings for MDM9607 > > to avoid having to define dummy clock entries. > > I am sorry but this is still incorrect. You don't have to define 2 dummy > clocks. You would have to define 3 times the same clock (and that's not > a problem). I have been working on the concept of clock nexus which > may solve this kind of issue in a rather elegant way but that's not > ready yet. > > In my opinion the binding that you want to push (a single clock) is > wrong, but since I've been explaining this for several weeks already, > please at least fix the commit message and I will take it as you want. > Thanks for your feedback! Either way works for me personally, but now we have a conflict between your requested changes and the feedback from Mani, who maintains this driver. :-) @Mani: Would you also be fine with defining all 3 clocks in the DT ("ahb", "core", "aon") and then assigning the RPM_SMD_QPIC_CLK to all of them? Thanks, Stephan