From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011045.outbound.protection.outlook.com [52.101.52.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C8433B8D75 for ; Mon, 6 Jul 2026 17:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.45 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360039; cv=fail; b=kARqlCGCuiTGrQ6SlPZ1EhFB1Rcpr6AK+OT/0mwbvSoKW/PGou1dPR4YmxwULwGoAotsxHo5rO9HwJjZdsRRI8Z0vpdCS2YML3jB1tgQchs8UiQaT6zrBlaJNba8esmbXXysSrMUJDsulsp0OvMCfqZljtJ2IlKCUA1/7+77U3g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783360039; c=relaxed/simple; bh=ha6uAIWcdPE1Ey0jbFCOMUCtXYfv4pVynst0IQcNH6Y=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HLV+Jy2lBYgBY0UfADpyuWbhSd2n2cwklPSPBMm0SiDUpWUJ+cHUY4y2P/ioTO2Z0aLjtaWX3CaQ5AVII+6vvHYMdFqoA26grbSgNXlCtE1Xf5X5fFzqd+fq4+u7x9mMZPOMNGSH+xkygcgHb45OdJMR4QA4NHlmgo4Zjbuf+so= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=sY1Qd8ok; arc=fail smtp.client-ip=52.101.52.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="sY1Qd8ok" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HS0f9IR3PchGBICY9qoVBbZQ4tlFFlN/LK25xUC+bg0nPNxQefVqQmvuS48NXgo2s9ltHGhZmRZtVNgL79pj8QZAsi4G3bnEGmxH/9SNBn8TfkX92Ky5La9igLrlrCmWPUalqmZ2jJf8NDSKPTEFZVnLxanMuManT0xDHQzGZ1LuLA4z2Xo2XMgX9f9QHbfn91+tTDrM1/ZyFkBeNXftrpaHEwIiZ4wLVFU8/3/Sx4jlxYI2H0jX1KVqiLxkJ9Hcm7vM5qi5BN47jVMfQIUFj21fj335DefY/gJiPfMBYVupxYmk1Ln3Cwf/l64ejTTm8ExV4za6kZN7gFzAGRBoQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YXmCqTfpDxfe3YGphYbJKygjvZnKhOwXRJcNyJ1ebcs=; b=TIgE33Rmiim/Te41JRnL8nwg2S076Ddk5o1qMkPK6saHzj8aeiBGaG4SJM5iv7jrk3nABiD+RoBud1LXg2sheH3BreVtnj3JPlqLaqWDZSq8kCy6gNVR4c1XqKLWnmGBVtGOwCHlxbXIVoPBMw/ny+GX63ebzmybFFmg1+pMkYbOhJSb3/yED30u6POp8pA2vWGeDE5kq6pJchsGmkyHIVnp3fbLYVltO778TM2CkClqSpxV7rYFDKYKw6zPk1yGAH63nbgN5oev/xU0tv160+49KuO+Ug2DWyJCYeLvfQDkjoPYfOsXQLgMRLZ8Tuno1D9TLEPEEDRNnMqmW2Rxig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YXmCqTfpDxfe3YGphYbJKygjvZnKhOwXRJcNyJ1ebcs=; b=sY1Qd8okhGYy9pyW5IorLE2nslkZ6mrp4WNwD1WxufnvYQUeowb0q9MQsVfTpHX6l2xVT8KP675inmEZDcENoUU+io/x3s3v3Tvv0zTGkMUJLSFLthWbo7sNwQJagWIeb7JDb+Rgp/fN0Pv6JCrpaxmW4hm7thseSHjkSmSBTRNA5ayv+hVMuv7iKXLcMYFAxhUMJnRXlZgCyrOseF+5yWHkQ4KBcVZWVCLyTyEiO+3XjDmudiSoD/dDSp0kPy/S/8Ws9ljwHK3lpoTo0EM3qe+q97bXqDS86KR8o/amSo9EW5o4enYI69KxrPlMGyFOMo1NbNQR0T8i3pl3ZVDa3A== Received: from BLAPR05CA0045.namprd05.prod.outlook.com (2603:10b6:208:335::25) by DSVPR12MB999191.namprd12.prod.outlook.com (2603:10b6:8:496::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.18; Mon, 6 Jul 2026 17:47:12 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:208:335:cafe::3d) by BLAPR05CA0045.outlook.office365.com (2603:10b6:208:335::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.9 via Frontend Transport; Mon, 6 Jul 2026 17:47:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Mon, 6 Jul 2026 17:47:11 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 6 Jul 2026 10:46:42 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 6 Jul 2026 10:46:41 -0700 Received: from Asurada-Nvidia (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Mon, 6 Jul 2026 10:46:41 -0700 Date: Mon, 6 Jul 2026 10:46:39 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: Will Deacon , Kevin Tian , Lu Baolu , Robin Murphy , , David Woodhouse , , , Subject: Re: [PATCH v1 1/5] iommu/arm-smmu-v3-iommufd: Reject unsupported bits in invalidation commands Message-ID: References: <20260706171632.GA118313@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260706171632.GA118313@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|DSVPR12MB999191:EE_ X-MS-Office365-Filtering-Correlation-Id: 60003c35-6d9c-4cae-81c9-08dedb869b6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|82310400026|23010399003|36860700016|22082099003|18002099003|56012099006|11063799006|4143699003; X-Microsoft-Antispam-Message-Info: meju0fobQJ1H6ugmDZs+2C0/rvt/kH0mCraE9byvK1E4TXMtk+nEnwHMLx4Grpu9gTTm7Ly49rnpA7sDWKJhqirH4DZt4znnD8USmzHc2885qGyJuTXBnrKjHP27OoVf4SxSaYML+M0Sgq2CpKxFyhVq6DbSqoVY0CLFg5+S6w6+VFhe9ywsGSXq63uufQwGGVjm+oW8MRfUDxpcwP/51EJvLMC7ScghqGQJ5DMPjc95xsmeYHbPlhxUCRaSo8p4Gqlo15F9HnZxGRkZP+yhxJAMB3IfG2VCFqJzI6WvgyBjFe9aMU7m+MPYHjXFJ8tvalpQwk2wzq2p+LOuUXZoXl0Ffo2cGU1FyYMT0p35RTQkE4ZZtXP4U1c8ux7BqEVKHgnJixN1AlDNysRAgPS0VJyJGWz33YsAjaB6BbegBKd+tSJFkuhSZ17R/QnxMBO8+80YMKAyQxj2edt99p+Z7IFX+HM3FBpcTyJKRSDBx28a3ADJBRwZH4nYNFql2YyJRbZfURgulY8aPvPqqDGO7sl1ylmVYCBJaXxZ0gNYhAkWAWdcAf+h4zgs4FEvNWOH3sXXt6bZabQGHG4Z2Flq0l5OPExaZif1Ka59kn8FOKkO8Vzf/dOH8xWbxyiFYJ0BfonSyT5B6NWEsO6U/2e24oRNtyY0RLpHSVBRzOyL+toElDaoG2cGeb139eHOU68xx/kQxYWbn8NtoxfyxqiFrA== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(82310400026)(23010399003)(36860700016)(22082099003)(18002099003)(56012099006)(11063799006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: V5f1MWAzhkgmn+LCQbhT3FQnU11bvjRJxrXipQptOjPcc9a3RGh8GgyGgwjKKfZuIN4mP9I5EocvoLS+knIbB21IT6IdjWIXMzJiko0dElwVTchlp2iwDKsXC/XSdiDC1V5ISWemj0AMSqo9p/EJJk5A8mfiq4VnPjaIxCwLSHGH7cj02QLXFWcxrnZvPvRy3/cCVMvnAJYO1FoZBHks9aAjLi7YWqM+SRyn524t2nw2HIjVXizGlNsdnUixENqkw9K2mVVtOf5YTHLTCJ28kXJUCMcUM1rw6Yd29fJayP7fUi2KIezee7jN2zR+SAg4Mp/MY9XtK6RxIlEEYf/AVkKhCxMDV/7tK9AyfPaKB3ehQKS786blmwviNf3bo7387XLOqEf1O280XEUjhF2JZUN4FDr2VXYoCcsbh/ozjympWZY1nIlXryknCD0H5qBx X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2026 17:47:11.1032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60003c35-6d9c-4cae-81c9-08dedb869b6e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR12MB999191 On Mon, Jul 06, 2026 at 02:16:32PM -0300, Jason Gunthorpe wrote: > On Mon, Jun 29, 2026 at 02:15:36PM -0700, Nicolin Chen wrote: > > + case CMDQ_OP_TLBI_NH_VAA: > > + allowed[0] |= CMDQ_TLBI_0_VMID; > > + allowed[1] |= CMDQ_TLBI_1_LEAF | CMDQ_TLBI_1_TTL | > > + CMDQ_TLBI_1_VA_MASK; > > + /* NUM/SCALE/TG are range fields gated on FEAT_RANGE_INV */ > > + if (vsmmu->smmu->features & ARM_SMMU_FEAT_RANGE_INV) { > > + allowed[0] |= CMDQ_TLBI_0_NUM | CMDQ_TLBI_0_SCALE; > > + allowed[1] |= CMDQ_TLBI_1_TG; > > + } > > There are a couple of additional conditions on tg and num in the spec > under RIL which are reserved and illegal, I guess those should be > checked too if we want to block any illegal command Yea. I have those covered in v2. Thanks Nicolin