From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 943313BD63A for ; Mon, 6 Jul 2026 20:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783368098; cv=none; b=UICtfOIlADlI1K3DhcrHHyRvee4rycb1AHCxno7YklDYG3eXAgp5JtHsbH4DSz6kHdZBv+XJHnGALHmIgPHJgjburAtMWItHwwndCdztjPBIBHjYT1nz1TsA5MudwHdgfM362c6k+B4dXYnbnYQ9FCE8KqHzkIYteuZUYsOMQlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783368098; c=relaxed/simple; bh=nVB9WHTsYYBpGmRfCYApDPLoE9C1PJXqoELbdeFQULo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VrBrEHbVRsINsAT0wKz2/PQLUjgLksY1qQLaEZLQ4Dj6LiNlR1T2xjS2Vbx2WAZWcRE6XwN7pge+4lDneH52bmaMqKfKudhapfuK9UjtQYtn6gKxvB3IZjhHUopyKv2u2WIMgoMESm5q6rGxCMF7FDPzg5S4c+kofNI0vdNGUrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=csDsfXS8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YOOsdg8n; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="csDsfXS8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YOOsdg8n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783368095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JBmxobDW/MHje2f4xBTmx9aIBxPjJtJsCEI+DZFs4H4=; b=csDsfXS8I1UfzI/MbvtARWHu9vsvttxlqvLr1wY0YAYAv7l+XAiAuYHmMIJGYeDA/lxmSQ CbVaomcWFLLXjArsOi8i0tpDKz260Co9//AkqtAa+ePgTsBRUf3iuVl9s27YAIXqyHobi9 xrWMoSB6Gpf5Eje+B5PIQ5nKQg0XatQ= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-PwQoZEFkNkiKi3CDpA_rUg-1; Mon, 06 Jul 2026 16:01:33 -0400 X-MC-Unique: PwQoZEFkNkiKi3CDpA_rUg-1 X-Mimecast-MFC-AGG-ID: PwQoZEFkNkiKi3CDpA_rUg_1783368093 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e820609d9so259274785a.2 for ; Mon, 06 Jul 2026 13:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783368093; x=1783972893; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JBmxobDW/MHje2f4xBTmx9aIBxPjJtJsCEI+DZFs4H4=; b=YOOsdg8nS9wJP/8koGEDRkxLlNHBrkl3MOIaN7rD1MV8MYEMelIrQWWKpK8YCrkbmu 1B812NIUxMy7FpWC7l8oSV2Q+MmLdtAsYfM8dTY+GgkO5Go4vQXC1VoZz/5bB8ZPhENI +OHzQhPRbI//1Zec/B3nVcIXimMUrobFYw/NdvO8HczCPneq9ZA3eqI+Q/gMuX2ECA0R 1zoYLKe7lmNITtbLn3NhRrfhUelb/FZu2srkiHX0RqR/IDXuJUMuelalJSmf6VVs8c96 wOHlealtd6PiQUo3+JJDhH1IFbhVB0E9CTbV+50YYD5PdYjlb65s4b/q9yP6U4/GWJFk h7fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783368093; x=1783972893; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JBmxobDW/MHje2f4xBTmx9aIBxPjJtJsCEI+DZFs4H4=; b=C9BuzX//DyrNTxFIV4bCWTE8uoVy8imMrrXHsKlRQw9HxOpjCM/xPyRV4iZnbk1XKH uRVn65wzji+HlfvdGVar4cb3ukdDDOg0uIx28LyOPU59o30TsoXzxCqLTzfWy1FI/G9N KyHAYfmITY3WMHeVed6oAjPhjjsyDuEtmprspcCTus2pWc5VUJm2kADOTPfLsFOBYOnf yEX1+rUzFetoLIsTSRt4QxdU6Ie8XWOfmsv1lcxF8+JvGRskBXlGSgh8ooxAuNeFJES1 pV3OOZcCdLmYBp1bSJjifDG/OW7poAsiaX8oom3GdqvK618gjxmVMYxUhFomU9ANbA95 wM0g== X-Forwarded-Encrypted: i=1; AHgh+Rq5plK/iMC0nj0tC5Sh7rnPLKcRPL9qxRGIgH0YoOXQ0mODf8eyrpntC0R7szWGbeOddqTEUIJdPSdqw1w=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/jlsq3Eoy3kSrIeQXc/8nDKxJ+fonRL+jS2cMBre4NWNazlyJ 1HrG+IdKpfd5ZPuewdTHJQHVKUE3dwQV1/PvQP5+dV1sPYxZlzAcPtsor1ey2Rhh0wSU+fk7KeG fBmcLbBnB2P0/Xi2GiIPjHcFgNKwiS5u388eWbsHgp2xiOv4KkyZB5RtYcXx7GUECJg== X-Gm-Gg: AfdE7cl52zUBuTDqXzq7X2evMvp0fxRsGkMMHCC+TYt9sLf4N5T+VK4t/H9FvhdnGK+ MR4HHt3tzBRaHmTuAOXFQYcY3SOgNHntCIWX1Z0UcHXAYhLGEl/KbyotXd8KegTr1WHpuRuhd/u sikla5DQc3Bl+wZS6sRXayBUw27nPE55BmjjMIvzdHxZ93Ch1youhoDRasE4t0dEal3zy9yhhLJ 8Dmbo849JsxQo34MzJdm607XPnHJIgi6IOaO3SXQwaJ7ir8JGpM+7u+Cvyam9WYoGjARSWs4Tpn ctmJaCf/9vz2tlRtLZAHeL0A3h+pmNhTDNu2A8/0TVjgmiTJTcxDCuv9IgN8mIgFfAzKM4Vxdss If28djalGlYbJEGpceJQV+plNEpVibNSZ+dy/l5mrW+w0HQ== X-Received: by 2002:a05:620a:170c:b0:92e:9cb3:3f71 with SMTP id af79cd13be357-92ebb56bfa3mr271389985a.36.1783368092260; Mon, 06 Jul 2026 13:01:32 -0700 (PDT) X-Received: by 2002:a05:620a:170c:b0:92e:9cb3:3f71 with SMTP id af79cd13be357-92ebb56bfa3mr271386185a.36.1783368091707; Mon, 06 Jul 2026 13:01:31 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92e90b81342sm1006981285a.7.2026.07.06.13.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 13:01:30 -0700 (PDT) Date: Mon, 6 Jul 2026 16:01:28 -0400 From: Brian Masney To: Akari Tsuyukusa Cc: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Miles Chen , "open list:COMMON CLK FRAMEWORK" , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH] clk: mediatek: fix memory leak on module removal Message-ID: References: <20260629142348.273766-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260629142348.273766-1-akkun11.open@gmail.com> User-Agent: Mutt/2.3.2 (2026-04-26) Hi Akari, On Mon, Jun 29, 2026 at 11:23:40PM +0900, Akari Tsuyukusa wrote: > Some MediaTek clock drivers do not call platform_set_drvdata() during > probe(), but their remove() callback calls platform_get_drvdata(). This > results in platform_get_drvdata() returning NULL, which leads to calling > mtk_free_clk_data(NULL) -> kfree(NULL). > Therefore, the actual clk_data is never released, causing a memory leak. > > Fix this by calling platform_set_drvdata() during probe. > > Fixes: 124294ff468f ("clk: mediatek: mt8192: Move apmixedsys clock driver to its own file") > Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and allow module build") > Fixes: 54b7026f011e ("clk: mediatek: mt8135-apmixedsys: Convert to platform_driver and module") > Fixes: c50e2ea6507b ("clk: mediatek: mt7622-apmixedsys: Add .remove() callback for module build") > Fixes: 0d363282bb0c ("clk: mediatek: Add MediaTek Helio X10 MT6795 clock drivers") > Fixes: c6368ce86435 ("clk: mediatek: mt2712-apmixedsys: Add .remove() callback for module build") > Fixes: 838b86331c5e ("clk: mediatek: mt7622: Move infracfg to clk-mt7622-infracfg.c") > Signed-off-by: Akari Tsuyukusa > --- > drivers/clk/mediatek/clk-mt2712-apmixedsys.c | 1 + > drivers/clk/mediatek/clk-mt6795-apmixedsys.c | 1 + > drivers/clk/mediatek/clk-mt6795-infracfg.c | 1 + > drivers/clk/mediatek/clk-mt6795-pericfg.c | 1 + > drivers/clk/mediatek/clk-mt7622-apmixedsys.c | 1 + > drivers/clk/mediatek/clk-mt7622-infracfg.c | 1 + > drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 1 + > drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 1 + > drivers/clk/mediatek/clk-mt8173-infracfg.c | 1 + > drivers/clk/mediatek/clk-mt8192-apmixedsys.c | 1 + > 10 files changed, 10 insertions(+) > > diff --git a/drivers/clk/mediatek/clk-mt2712-apmixedsys.c b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c > index 54b18e9f83f8..24522fc24019 100644 > --- a/drivers/clk/mediatek/clk-mt2712-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt2712-apmixedsys.c > @@ -129,6 +129,7 @@ static int clk_mt2712_apmixed_probe(struct platform_device *pdev) > goto unregister_plls; > } > > + platform_set_drvdata(pdev, clk_data); > return 0; Please add a newline before the return. Also, please split each fix out into their own patch to make backporting to downstream kernels easier. Brian > > unregister_plls: > diff --git a/drivers/clk/mediatek/clk-mt6795-apmixedsys.c b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c > index 123d5d7fea85..b607592a7c37 100644 > --- a/drivers/clk/mediatek/clk-mt6795-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c > @@ -175,6 +175,7 @@ static int clk_mt6795_apmixed_probe(struct platform_device *pdev) > dev_dbg(dev, "Performing initial setup for MD1\n"); > clk_mt6795_apmixed_setup_md1(base); > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_ref2usb: > diff --git a/drivers/clk/mediatek/clk-mt6795-infracfg.c b/drivers/clk/mediatek/clk-mt6795-infracfg.c > index e4559569f5b0..12146bb3b726 100644 > --- a/drivers/clk/mediatek/clk-mt6795-infracfg.c > +++ b/drivers/clk/mediatek/clk-mt6795-infracfg.c > @@ -116,6 +116,7 @@ static int clk_mt6795_infracfg_probe(struct platform_device *pdev) > if (ret) > goto unregister_cpumuxes; > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_cpumuxes: > diff --git a/drivers/clk/mediatek/clk-mt6795-pericfg.c b/drivers/clk/mediatek/clk-mt6795-pericfg.c > index d48240eb2a67..28faeb2e657a 100644 > --- a/drivers/clk/mediatek/clk-mt6795-pericfg.c > +++ b/drivers/clk/mediatek/clk-mt6795-pericfg.c > @@ -125,6 +125,7 @@ static int clk_mt6795_pericfg_probe(struct platform_device *pdev) > if (ret) > goto unregister_composites; > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_composites: > diff --git a/drivers/clk/mediatek/clk-mt7622-apmixedsys.c b/drivers/clk/mediatek/clk-mt7622-apmixedsys.c > index 8a29eaab0cfc..a9fc2e5536b3 100644 > --- a/drivers/clk/mediatek/clk-mt7622-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt7622-apmixedsys.c > @@ -109,6 +109,7 @@ static int clk_mt7622_apmixed_probe(struct platform_device *pdev) > if (ret) > goto unregister_gates; > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_gates: > diff --git a/drivers/clk/mediatek/clk-mt7622-infracfg.c b/drivers/clk/mediatek/clk-mt7622-infracfg.c > index cfdf3b07c3e0..b44baf521d2f 100644 > --- a/drivers/clk/mediatek/clk-mt7622-infracfg.c > +++ b/drivers/clk/mediatek/clk-mt7622-infracfg.c > @@ -90,6 +90,7 @@ static int clk_mt7622_infracfg_probe(struct platform_device *pdev) > if (ret) > goto unregister_cpumuxes; > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_cpumuxes: > diff --git a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c > index 19e4ee489ec3..41e5cfbcbb76 100644 > --- a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c > @@ -66,6 +66,7 @@ static int clk_mt8135_apmixed_probe(struct platform_device *pdev) > if (ret) > goto unregister_plls; > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_plls: > diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > index d7d416172ab3..fe36d2eac3da 100644 > --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > @@ -179,6 +179,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) > if (r) > goto unregister_ref2usb; > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_ref2usb: > diff --git a/drivers/clk/mediatek/clk-mt8173-infracfg.c b/drivers/clk/mediatek/clk-mt8173-infracfg.c > index fa2d1d557e04..b923b73c64f6 100644 > --- a/drivers/clk/mediatek/clk-mt8173-infracfg.c > +++ b/drivers/clk/mediatek/clk-mt8173-infracfg.c > @@ -128,6 +128,7 @@ static int clk_mt8173_infracfg_probe(struct platform_device *pdev) > if (r) > goto unregister_clk_hw; > > + platform_set_drvdata(pdev, clk_data); > return 0; > > unregister_clk_hw: > diff --git a/drivers/clk/mediatek/clk-mt8192-apmixedsys.c b/drivers/clk/mediatek/clk-mt8192-apmixedsys.c > index b0563a285bd6..446c55b77777 100644 > --- a/drivers/clk/mediatek/clk-mt8192-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt8192-apmixedsys.c > @@ -176,6 +176,7 @@ static int clk_mt8192_apmixed_probe(struct platform_device *pdev) > if (r) > goto unregister_gates; > > + platform_set_drvdata(pdev, clk_data); > return r; > > unregister_gates: > -- > 2.54.0 >