From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D863A3DE439 for ; Mon, 6 Jul 2026 20:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783369651; cv=none; b=sY+Pvz6Rvu9nm2DdU25TNraRU2heoVVaP4HcBBGbIPbkIaA0v2vTnnyoR5MX4WvL/tED12qtl0wF6dyjuQqxC1F+BEYsiZVv5kSAwCYuv/tpms8WX9lvZsOqtY/9LJRdecT5kQvVI2PuMRz2ga+48ZdK/YW2ZW47d/GaO1iw1xY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783369651; c=relaxed/simple; bh=hb9Ap554Ki+u2dGlJ7DNW+pGcNvhjajDhiB1roXBXoM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=da5llaaEg2CjG9C0h5kena2uwR7NLgqLsOr8xm8IEzYWMlXrcQd1OzfTFXIZIbFmZ02CDfKnOK6zVQ4/kRYMKk6m6DgL+HeVlvq2U5STRciDEzY9xWWjjXKc6U7z76482EbNbfzsdgFkzhRyF6LlhygO8qiz6RsWWkhwgYR0eNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GvZbnqv6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aXlRx4iJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GvZbnqv6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aXlRx4iJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783369648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ZL/DegmvXGzHdZTvgWnc7Fc8nL2OkgclVE6j97WTc4=; b=GvZbnqv6BZNIC4P2QXk1dRJZNqHNMSmBWNeRMCCWT3nEumFuEaH/d7M7PynTFU1T+nQZu5 SccgQBwutM/4uuJgr8jA/iOX9l/cqazE/tSbcxuOqSfDh4nmr2JKehl+/SRPHczSNJqBZK HfQaG2eCyO9rzFi1q4D+zo4WTCB3a2A= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-5gjxh0KDNPWs7d5OOjyeDw-1; Mon, 06 Jul 2026 16:27:27 -0400 X-MC-Unique: 5gjxh0KDNPWs7d5OOjyeDw-1 X-Mimecast-MFC-AGG-ID: 5gjxh0KDNPWs7d5OOjyeDw_1783369647 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c20762d21so42066051cf.0 for ; Mon, 06 Jul 2026 13:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783369647; x=1783974447; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=8ZL/DegmvXGzHdZTvgWnc7Fc8nL2OkgclVE6j97WTc4=; b=aXlRx4iJURvbr28lmMlCgoOt09xk+1BjtQ/OPfz+Vl6gZpJjITMY+hQAGbd0lQeMfZ nSbkYeIfJPZ6N/M/LdEVfMhXEEMtjh7c/JkBjdI3jEXtcvpSvDF03hHtKTZlaR/garE8 pBIF8mp6W7v45TO+EOn2AZ0FK4SZxaAESwSA3lIYmTH29pMX2dI21vvHyG4YALmKM2Xm 1pFn2UJvqCFLWrB6C5xNiKIZVZpVFbh+ciZIq9X3aAY+sUIUhJLYzQneP1944CgvX0ED PpfbyuNLcvFxMSfcFyDOhWT07GePJzT7o8X5XG9uj/piu53FImeEGwkLRzV8zQg12VQN 3UFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783369647; x=1783974447; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8ZL/DegmvXGzHdZTvgWnc7Fc8nL2OkgclVE6j97WTc4=; b=Nwucav444R8t/KpjeNHxK5y7OuZpb/6lRVWNNMAodB7A8fqwRShoQtwPcxWqGXgk3e pEZSPeRyoFETt5tCxQa0ePcCtGhlGdCb6Zwv9icxw75nkoelm5J6cqUNa+MJA/68IbpI HqqkAQ01ZimuSslR2GPysr0eGrrAqxrv885XOyBs0PSAy7IqGJ/wRpeOLQBIQDTEJ+Vq luUokih0ToLIc0r/J0iJSjWltSe7rAQ9M5WzzHy6OJDDCH6itLjzKLvzEXqCpegOzpmQ gJ+3nVHlWEgBwYM4f40GgnLpBT0PvaIZqcRPGovdrmRZu0LuY0QtnOIs3uPCSudj4cEg 2WDw== X-Forwarded-Encrypted: i=1; AHgh+RqJxTwufT7k4LMVEYPB4Z+xFRHoEFSJk0ugpIsMHTYkJII10RIyuTXAGnOCLEe2ObYUqIkYSy2TqdWnJDY=@vger.kernel.org X-Gm-Message-State: AOJu0YyphDFblByPLaQ+DKzm2xvo/roc/IGOQ9nldXGPFv9vOhq/uLZP 1Gv2L4WjIXnl+2qC1TWQ/RKVP1EPt0f50W1UpXzpACvQFRWA1s9Yyo/JkR4p9KuHxrSClY4WZkB GYnvBQYpNupr91NIksgGTH6OwFFERGb0JPV1zTnvjJkQmTDfXc+YmRzKQhqJnySoT4Q== X-Gm-Gg: AfdE7cl9/XzVji/S9jidhHDKlWq7Pw91jvO8vB6mW52SCKY/5yMS1o1ol5w4ldYFv2t ARDoIRQVvYle3fKg63MSOSlMZGbyK4aY3rz3M02e3rztefP7J2hQqJdcv5yc9GDcYkoRg7lHlfd /upMOGMVIOrjKLkjUD85LU6xCmlShiLAHmQNFdVk1dD56AaXdDQPGObNpz8VtzHgneAfXG5vNok uaZEa/FMgVNb2W7sQvd5lu5tLDrU+zQpxiMnAGkVBdLmAnuGXg7nqeZEYALxMxe2DlO0YyWhxzU RicojI3aZmz7vwX6SsPY9yGswCIa+t76uHVN7O+avH5kiiE6GAnzBqeXDk86Exux5aCaAmTHf92 twPoxt5UE+rfcI2wNgERzwbTfpr4ad2uogvU8FY+VUDn9Fg== X-Received: by 2002:ac8:7c4f:0:b0:519:51b1:e764 with SMTP id d75a77b69052e-51c7485370amr25568661cf.47.1783369646951; Mon, 06 Jul 2026 13:27:26 -0700 (PDT) X-Received: by 2002:ac8:7c4f:0:b0:519:51b1:e764 with SMTP id d75a77b69052e-51c7485370amr25568441cf.47.1783369646512; Mon, 06 Jul 2026 13:27:26 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f46e371f44sm152788386d6.2.2026.07.06.13.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 13:27:25 -0700 (PDT) Date: Mon, 6 Jul 2026 16:27:23 -0400 From: Brian Masney To: Myeonghun Pak Cc: Yassine Oudjana , Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ijae Kim Subject: Re: [PATCH v2] clk: mediatek: mt6735: Unregister PLLs on probe failure Message-ID: References: <20260624062409.45678-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624062409.45678-1-mhun512@gmail.com> User-Agent: Mutt/2.3.2 (2026-04-26) On Wed, Jun 24, 2026 at 03:23:55PM +0900, Myeonghun Pak wrote: > mtk_clk_register_plls() registers the apmixedsys PLL clocks manually, while > clk_mt6735_apmixed_remove() unregisters them on driver removal. > > If devm_of_clk_add_hw_provider() fails after the PLL registration succeeds, > probe returns the error directly and the remove callback is not run. This > leaves the registered PLL clocks behind on the probe failure path. > > Unregister the PLLs in that failure branch before returning the error. > > Fixes: 43c04ed79189 ("clk: mediatek: Add drivers for MediaTek MT6735 main clock and reset drivers") > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Signed-off-by: Myeonghun Pak Reviewed-by: Brian Masney