From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43DD037CD2A for ; Mon, 6 Jul 2026 20:48:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783370915; cv=none; b=oRU3BhU2ezTMYqQYVEHuCxav3ijvr/1qN6dft8kYOU6dsPIfIBxi51MzDyQ4KZxWEJ3pMK8D68TmiOXdOWGsRRibOrV/vgVizyrzx4mNDzDVzMr3fSn9xdMQBEJ5SbTyg4Xy2m/CPi2+LEAzW0E14iJi2mry5wXx1FVCA0cKHxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783370915; c=relaxed/simple; bh=sA3bUyxlyAgtfUkMb0H5qkmTnmpV+7g5kV7l0iLbrg8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DGOTPtq4sOk/HIR2K278RX4Zs2S5onEIi/jxWKJ9a2uQwn9d6Wj4ordKm8YWQp/r2yHkRjcUhDB0VYO+8zlCP3LnFVWRHAkqLUKaI0uMuCgx9bCOKSDCUfNqRr/jknlyCaSn496Ztl1FCAB3diPvXXLtn0S2D/KPmPvXYM9ZHaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=mZ3QsY+A; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="mZ3QsY+A" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-4629051c9d1so1730361f8f.2 for ; Mon, 06 Jul 2026 13:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783370912; x=1783975712; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0UHpBUD3cu/Rp4zLRsGuE1AtMqiOkk0aTyTzhiJ1BL8=; b=mZ3QsY+AsrHxo3EAM2ic9C5MGyspmw2OwlRSqtOP1RX+npnC1yJlQfLVToZ6tp2L+D 1FDQ8vg8CtTeW1uLeyRJ4k5u8EpVauS3/891pOD7PU5dvtbD4pwaiEd2vCEIYfzvT0Kp vHg2XXaJTbU8yjeHrYZszqaK8+068r7gx7WpPvrpLGuadZu9JauwioCLswVB+VZp7UYO zXDG9BmwxAHmApF29H05BNPvzhqh1hMu2Zz+EsHYHTbxBFS+0cjczj4b4FeQi7bXl6zL NZy79GxlTszrRqwt+jWi6VWTIYb4oEl8udgaIUV+wh2tURFq4JNT0BiobJVjoyhdRH7/ 0dLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783370912; x=1783975712; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0UHpBUD3cu/Rp4zLRsGuE1AtMqiOkk0aTyTzhiJ1BL8=; b=LW1YnTdDRB/dDyhthzEuFHa/VFj3XSi/6io9s29NJpeS+o+A/4A42y2TS/lCaxuIOi JvjKN0a52AQ21OwOkMqX856VQJdNBWhylssrtIfUKRifzeArk898nivCJQ1mVFveF5XS JVOJHnQyxRCxzN1qZA7VsaOzTn2z9J1WcZSrfyapZE48EvxFkM2V2HJ9JUgA2hoayIDY JiQC+txl/4tLDiD3c28bI+Vsoj2ez9qn8y/mcYzjep+KlPZOkUdYLrEt7NytEjn5dcXN ccSgtTwi7mi6AET6GrTyYJ91qFxVXUtLGo4h6iQ9Bj3X4/nbEOOXHCDlGps+bTQ+vwcO AiIA== X-Forwarded-Encrypted: i=1; AHgh+Rqxm20P57wFZxmq0pV7Zz3Di+SCy8F6NUgXfeu7YeUzVrEgEOXrMBN9kfQtolRgJ8sX42IFB/WLfItNftA=@vger.kernel.org X-Gm-Message-State: AOJu0YxiQ7tTr0yS1+uPH7Vc9t5V1jHaseWgrf0k6dZgY/q/fTtcDqif N+SiFvC+B8Pwq/AIWCLXN+VVBREEw4DE9HMQDo6Y0eZ4Ywbs7I0KE/LdJX0SyoYcRk00inoWyE6 4MFT1HxU= X-Gm-Gg: AfdE7cm5ypubWJmyM+g2qBaWR+bp4POHFUrq8xBEgbCjfmoI+WNORv3aOvLVrRPrhe4 5fI8MK6Un3ltNoJgg0VLDcg1MbuUm4Kr5PnNeYRkP2+7cBdUe0YXHzXaapsL5DZKIOs1ccEkovE ZD/uX2uWdc2SjCvOXNeEXa9lJS5ARz08MiUy2+hMyFyEzD2nxDR3/fTCO3Ya9ASbXE0gIupIHO0 +y2K/eGrF2Cu62Jd+skvyv7RKl4yQFyXrU3NR88zKGrQOE/Sp6ftwciVEGwHltUy1wdYhoEcQTu +0x2Wsvc5fqrWh2gt8nX3P1IOJM0vNHSBh09q+1DAyaC/O4ruCLycI93/TO/nvLu6Pe4bixGBuv mHoNqa3f0EkzSd9sluKR+XNoZctD8nHLkOZMWiGevvOn2kAcHhb98bND895pWW4t1UKlKS5XxgF p50dWHc7fcONgl3rMWA1GrCqGT/O2p X-Received: by 2002:a05:6000:2484:b0:476:6bd4:82b8 with SMTP id ffacd0b85a97d-47de66d0032mr2092771f8f.14.1783370911620; Mon, 06 Jul 2026 13:48:31 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47a9e4d7801sm28301287f8f.16.2026.07.06.13.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 13:48:30 -0700 (PDT) Date: Mon, 6 Jul 2026 22:48:27 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Andrew Lunn Cc: Heiner Kallweit , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 net-next] net: phy: Drop #inclusion of from Message-ID: References: <12ec5246-4124-4edb-a5f8-f10c73b1fcb7@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yznje6wp3egk2oea" Content-Disposition: inline In-Reply-To: <12ec5246-4124-4edb-a5f8-f10c73b1fcb7@lunn.ch> --yznje6wp3egk2oea Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 net-next] net: phy: Drop #inclusion of from MIME-Version: 1.0 Hello Andrew, On Mon, Jul 06, 2026 at 04:17:47PM +0200, Andrew Lunn wrote: > On Mon, Jul 06, 2026 at 11:29:19AM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > itself doesn't use any of the device id structures. The > > files #including use a variety of them: > >=20 > > $ git grep -l '' | xargs grep --color -E '\<(acpi_devic= e_id|amba_id|ap_device_id|apr_device_id|auxiliary_device_id|bcma_device_id|= ccw_device_id|cdx_device_id|coreboot_device_id|css_device_id|dfl_device_id|= dmi_(device|system)_id|eisa_device_id|fsl_mc_device_id|hda_device_id|hid_de= vice_id|hv_vmbus_device_id|i2c_device_id|i3c_device_id|ieee1394_device_id|i= nput_device_id|ipack_device_id|isapnp_device_id|ishtp_device_id|mcb_device_= id|mdio_device_id|mei_cl_device_id|mhi_device_id|mips_cdmm_device_id|of_dev= ice_id|parisc_device_id|pci_device_id|pci_epf_device_id|pcmcia_device_id|pl= atform_device_id|pnp_(card_)?device_id|rio_device_id|rpmsg_device_id|sdio_d= evice_id|sdw_device_id|serio_device_id|slim_device_id|spi_device_id|spmi_de= vice_id|ssam_device_id|ssb_device_id|tb_service_id|tee_client_device_id|typ= ec_device_id|ulpi_device_id|usb_device_id|vchiq_device_id|virtio_device_id|= wmi_device_id|x86_(cpu|device)_id|zorro_device_id|cpu_feature)\>' > > ... > >=20 > > but none of them relies on 's #include. > >=20 > > is a bad header mixing many different device > > id structures and thus is an unfortunate dependency because if e.g. > > struct wmi_device_id is modified all users of need to be > > recompiled despite none of them using struct wmi_device_id. > >=20 > > So drop the unused header. >=20 > While i agree that there are lots of unneeded dependencies here, does > this change actually solve anything? Pretty much every PHY driver > needs mdio_device_id, which is part of mod_devicetable.h. So it must > be getting included somehow. >=20 > I assume the long term plan is to move all the structure definitions > out of mod_devicetable.h, so a driver can include just the ones it > needs? Yes, however not long term, but I intend to get most of this done for 7.3-rc1. > Is this patch somehow a step along that path? Why not move > mdio_device_id into mod_devicetable_mdio.h and include that? It seems > like the more obvious fix. That's exactly my thought, and there is commit ad428f5811bd ("mod_devicetable.h: Split into per subsystem headers") that is part of v7.2-rc2 and that does exactly that (apart from the filename). Best regards Uwe --yznje6wp3egk2oea Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpMFJgACgkQj4D7WH0S /k5dHQf/QoJwvEDslmRdlY/7+cdVFzKOjggf0jklvP1rIUOxJuc1G9pdBRKfCACH cSpHt0herH2EwKaXrpQPVdJgTNWwURKJ55j1fkP/YEPEGE7i3TM5JktQ/YAOPWj7 MvfcQ5Ia8h40i/1g3X3gyKqaEGrB/eFDslsEGcMYiEUTLjtK8P/CqyubD+YXDJ7M mfLuW6fu6/U8gdw9fQay/J2UaM/zV1iNqAzgmD7eRAvje4WgrUnw6xm9RtaSimOq NUZtsQfvjxDJHWtJFNQODzR44GsLymwK6H+5bQLiVuBFtBR1LLlg28qipw3VRWtF 2ncfNVS3on+zC95LHbfABSDLS7LqOw== =Y4bH -----END PGP SIGNATURE----- --yznje6wp3egk2oea--