From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8AFA22689C for ; Mon, 6 Jul 2026 20:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783370979; cv=none; b=FEM3YXj4mIQ+yTihmBgeydZfLpth1RnbiLGCPJDsaSCWHmooBjF6zMRq8JVDRW5cERf0k8UDxQaL5KMoXx2N+PMdEWf8kf2VfGCY1pxjnknW/Rg9utCKtFHPzRogH6R9tqKq5gPBLjehs24lQKfksWo9m1TT5Uvlf9DXg+Xwhdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783370979; c=relaxed/simple; bh=d4S7sDiFbTc53OqWoIai9pPjYCRzDsWspPHPSQWAR9A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l6ZYMg0FbRzSLY+KPtOpDq+iwxM3pemgMukRr6guOXI+dRDm3/ITgSLPBVBggMyaOKR9KYz2qS8vficVSl+TRVS2r1BTW1pgmfMrc+5AVeSZqGCM8RkMOxlTFXULGQxEjLxoJ/kr5VY63clLULpwGB6MaWbCAiwd3jofzxZVdRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OY1t4vVq; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OY1t4vVq" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cad4170e8eso41731365ad.3 for ; Mon, 06 Jul 2026 13:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783370977; x=1783975777; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dsAw/f66PDO6A23XewR6r4+zQzL0h2Tt+CMeAp7uytE=; b=OY1t4vVqWzXz2P2S0YE0yDxjR2ucGA4vXE6BjGcBif3ysuJXYB+ZVgozYKtNxDu7cf 2F/eLTGMmzzc6fvRlfIWV1AaIVdNIDuilgCk4kjCUnd8YL5iZo9cxlu0N1dDoC5Yrgk0 sZej3/FI29aBt4nFwdUFg0ZNx4oOPiFAf7CF7SGvemWK39Rkz2GQulWpIJ15qP4Ti8gg 7IEUHBGchhNLZvDXZA2VOc6KzHnfirEQoZRDQnOBWsidJ2vsiYqSrQQ62xvA9et4Tjd4 3p1vwPX47dF1qFJyFvAtL7QPS8Aa9zdFSZ2gsMRR+W2XGrS52Xt7GUHQEpJ7ir3dPJK0 M2wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783370977; x=1783975777; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dsAw/f66PDO6A23XewR6r4+zQzL0h2Tt+CMeAp7uytE=; b=KpRs8zlmWePfdiSiQBSSaKftpTCDW1GkkUDNMKkV+L0Lx8okaRieAmAoE4YHcUQZaq 1j/A9L86FbLWadpx74Fd7EYQyk+SDXmPT5Fr874BXDW1Hmnrqb6PrkA87ZCqBUWziKY3 7pbYyAllWs1Mk24SDgDTLScfg9fW9MwgpM2cJijMGGqcsrsT2NgNR2tc/LOoRLUJtWfN 5heQRFdzDW2WLOAN4yWe+HGdVS8ao9owId/qZO7TJ9/1HgjmQ2m3rURovvPBfJb/3r89 AXpOm6PYohBgCHcfLWQx2PWZ57Gum4V7hJDHCaJP+TVlVKDxKI+eY4PJYQkrAT8ZHhTP +h6A== X-Forwarded-Encrypted: i=1; AHgh+RrnkvA4xE8ydb6MvcpG/yUk85KPpqoja6qOnXiM0RQpQgzwwrSuzfv3Q1az5AGq8tVdXOHI5Y6hGFCjps8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnusz7b8SIVllXOOjUdp5tvnOv5DcTjhkhve5TmUttv8g4zzmL pwnDrOH1cX13nelCgA6MA4Oj/Pbw9IDMLUChwMG7DLlaHTwANS00e1QnFSXMHpsIMw== X-Gm-Gg: AfdE7ckB1AbQcWK6FRGE/xyqb4qK1RKwaMOFVDZIdW13zo7GcsT93y0kOTyG0En+WDh RGQMXa8BgLvhREdt/2jm9QC1THNtz9OJVCaoNatAo4Nv75sPqwy4hHF9PyzZ1mSpMnjwKnG4wKL NTSxJgpNJ5vxbqLCcqN24Ydx6e+/QOjnSTYCjkSPrY81JzQ/o9p/505218mFzj6cfhaaEb3fO/D iOFgYZ38YG8JByuN9D8j1BSlka7yECCxkQ9f+qiKz5T1v+7TnKv1sTXU23h6ReovKYCNsl76LYR Za+sttuO5ZvWTXQUeo4TEGRY5laFAszSYjh0aROtomDLV9/+WLahjiKscPD8Nf92duhFNK2gFZS fXeLardZDF5WcdgLsZXggKiivbA2We63KqIRKVilFqc0d7BDlSJstsrknzIUNN1xNPp6FNB9xfx I7sJ57Bd//a7hb9eJBoy4JzDfVcYDWgN2mGYtFld2O1aPdXAJ6ZkM= X-Received: by 2002:a17:903:390d:b0:2ca:d151:383a with SMTP id d9443c01a7336-2ccbe729b2bmr26058305ad.20.1783370976544; Mon, 06 Jul 2026 13:49:36 -0700 (PDT) Received: from google.com (56.149.168.34.bc.googleusercontent.com. [34.168.149.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d3da55sm302005ad.71.2026.07.06.13.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 13:49:36 -0700 (PDT) Date: Mon, 6 Jul 2026 20:49:32 +0000 From: David Matlack To: Josh Hilke Cc: Alex Williamson , Vipin Sharma , Shuah Khan , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 10/10] selftests/vfio: igb: Use offical IGB headers in selftest driver Message-ID: References: <20260526235417.2058313-1-jrhilke@google.com> <20260526235417.2058313-11-jrhilke@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526235417.2058313-11-jrhilke@google.com> On 2026-05-26 11:54 PM, Josh Hilke wrote: > Include the offical Intel network driver header files in > tools/testing/selftests/vfio/lib/drivers/igb/igb.c and refactor the > driver to directly utilize standard E1000_ prefixed registers and macros > found from those headers. > > Delete tools/testing/selftests/vfio/lib/drivers/igb/registers.h as it > only contains duplicate code found in the offical IGB header files. > > Assisted-by: Gemini:gemini-3.1-pro-preview > Suggested-by: David Matlack > Signed-off-by: Josh Hilke > > # Conflicts: > # tools/testing/selftests/vfio/lib/drivers/igb/igb.c This should not be in the commit message. > --- > .../selftests/vfio/lib/drivers/igb/igb.c | 159 +++++++++--------- > .../vfio/lib/drivers/igb/registers.h | 127 -------------- > tools/testing/selftests/vfio/lib/libvfio.mk | 1 + > 3 files changed, 83 insertions(+), 204 deletions(-) > delete mode 100644 tools/testing/selftests/vfio/lib/drivers/igb/registers.h Please fold this into the first commit to avoid adding registers.h only to then remove it a few patches later. > -#endif /* _IGB_REGISTERS_H_ */ > diff --git a/tools/testing/selftests/vfio/lib/libvfio.mk b/tools/testing/selftests/vfio/lib/libvfio.mk > index 1f13cca04348..0075749e2f12 100644 > --- a/tools/testing/selftests/vfio/lib/libvfio.mk > +++ b/tools/testing/selftests/vfio/lib/libvfio.mk > @@ -23,6 +23,7 @@ LIBVFIO_O_DIRS := $(shell dirname $(LIBVFIO_O) | uniq) > $(shell mkdir -p $(LIBVFIO_O_DIRS)) > > CFLAGS += -I$(LIBVFIO_SRCDIR)/include > +CFLAGS += -I$(top_srcdir)/drivers/net/ethernet/intel/igb Please create symlinks to the specific header files you need to include rather than exposing this entire directory to the VFIO selftests default include paths. e.g. Take a look how how the DSA driver does it: $ ls -l tools/testing/selftests/vfio/lib/drivers/dsa total 12 -rw-r----- 1 dmatlack primarygroup 11648 Jun 11 21:18 dsa.c lrwxrwxrwx 1 dmatlack primarygroup 49 Oct 6 2025 registers.h -> ../../../../../../../drivers/dma/idxd/registers.h $ head -20 tools/testing/selftests/vfio/lib/drivers/dsa/dsa.c [...] #include "registers.h" [...] > > $(LIBVFIO_O): $(LIBVFIO_OUTPUT)/%.o : $(LIBVFIO_SRCDIR)/%.c > $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@ > -- > 2.54.0.794.g4f17f83d09-goog >