From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84477324B06 for ; Tue, 7 Jul 2026 04:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783400037; cv=none; b=g6gc5c/GX5CSfwdlS11KPDU5r99i9j9SBW63o6lXFdD2yTGFeLPSUQszEMxhnW5brSNucXPdvN578yTs6NJ5KVtvwOsz2MvWUzoYRPfx3qT6eZydRxQ4t12cIuYf7Ka5UqgJe0dQ/5RjBZ2KGiouVQ6GUi7fVzrGkxw1tAtCY2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783400037; c=relaxed/simple; bh=75PBt+v2GzBSKnsGzynsKuc+AUFug7BzFOJo/204S90=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pc5d99x3WgA4tdp15z2d5TQnCvzp7Xyy74JToBaYhIPG1Tjui+0uEHRctHiQDTzOAt4CjMeoUt6Lhs8rF67mo8ZtWFYSv2BMPATbROFFD/bfGhtr2AhzfkA4L2PMnVwYxF5g85XWLyb1S9qKW8a9ylyAuN2hoSdkCX4gkyQAbAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=h+wiQnAo; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="h+wiQnAo" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZNkSEK+HvFWgew8qT2LZ9tewGZDZTkJj36P11icWQDk=; b=h+wiQnAoKkVAmJRB+OEo983N4G Y7JHUEujPz/FnemfTyAxC6zfmndkahUKnLNTjBudc43Z2pGlHX4UaG45S9wnaK3F1IAcUEaIGWLNZ njvHXsdJSlx7ucOnXQ1MKRyBg8F5j++MQIOv1ELZ9J3pB8HzRYTgv99GYyn+4Ik7Z9oFRlXhYTZDb TavglLsUNTX7yJMwwQVdCQypAcSUkNlx+jfI6t4An5UhcCS+CZC6ZrdQQbInxZXu27N+d1Hq5G8ZU ZoT3ucMukkSXnnEJ4voV9zYtasCIj8zrdYVlXIle8puDLZ1d4d7LMeRkIcQGfu9CZygqTtzgnVBtz 8NIC+WRQ==; Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgxoX-0000000H94J-1ifE; Tue, 07 Jul 2026 04:53:45 +0000 Date: Tue, 7 Jul 2026 05:53:45 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-mm@kvack.org, andriy.shevchenko@linux.intel.com, usama.arif@linux.dev, hughd@google.com, "David Hildenbrand (Arm)" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Standardize printing for pgtable entries Message-ID: References: <20260707041703.658021-1-anshuman.khandual@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260707041703.658021-1-anshuman.khandual@arm.com> On Tue, Jul 07, 2026 at 09:47:03AM +0530, Anshuman Khandual wrote: > if (!pgd_present(*pgdp) || pgd_leaf(*pgdp)) { > - pr_alert("pgd:%08llx\n", pgdv); > + pr_alert("pgd: %s\n", pgd_str); I don't like the extra space being introduced after the colon. It's normal practice to not do that. But in general, this looks a lot better.