From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4CAC36A370 for ; Tue, 7 Jul 2026 07:19:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783408781; cv=none; b=JvRmKGELqJZla0PKad0d7j3heNSFdWRIEiHbHD63CjH4kBFCI7VHkyIhikAyYz+pCL4/4wOP71JCUkEpJpGmzgov8JgUa/hrc5TdFZWa1C+2DT3hf/PN0UcJOEV5HGQueU+Y5ZxKRu2ps7VyQzW0ObdSYjsoxfuX4mF2By4g73g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783408781; c=relaxed/simple; bh=q0ypKI3CahFXV1rXg4t2iuvquTiyFI33qRFdaSZZjcE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PmlUo3KneWUOJ64kCaEKHmpqn4LpFmS88t5PcAxq0uME+UwrdipMxckw1fzsOwYT7mcl56P3xqwsKQgjyasAmKLkNjCL8DZRZ9lO0n620IDHggYk37LsUzBEUBr7JxpJlF42RRWOtHR7x53rTkphdH4XAsSPBHHfvJKIDjpwm18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CKuZ1Rru; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CKuZ1Rru" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8481fb4324aso1044643b3a.2 for ; Tue, 07 Jul 2026 00:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1783408774; x=1784013574; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Wgh/p0t9TWjURNEJcqUkzP0rZOfYFyjQ3wAwE0PR3nw=; b=CKuZ1Rru92l699pCD2/UbtmN7eEn8nTTcQ6ISa1C7ul1F2Klcr3zXosUJURFLQsGI2 Nm4HgU9KuIB9xV4QXTCsBrOXaxwSKHvnw3iepOO/xHM1W5nRjkmgxqEQQStyaGz8cOnA LH2P+St4DHK3jHC8gCe2TxXiFwQVVCvxvFHkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783408774; x=1784013574; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wgh/p0t9TWjURNEJcqUkzP0rZOfYFyjQ3wAwE0PR3nw=; b=nt7tn6k4A7S8zofOXmKhnfxBLFIxD8V0wrJto5zW8p7kOxeTxz2HwEvpzD2FKUWqxW q0n1c0ma/7/1yfKPm8GG8UPIQvRy6hr1dekQp8iRyMpQhH519AL4xzGN65Q16hI+kayM CzvlVZvi3+DraRw3oX0B2jy4AB4oo5z89CWb2n47vGJG486qKwMjaBRPOGcN77SO0Z0p Eov8UX71/WKPyntOWjRHBVfweRepRVjdS+d8eXx6nHqYy1A/lMFWsRzA4mio2woyr9ni sk1D5AUXL+hOdER88CNE0Me1XRUPYZAaZwREFTd/War4CaI6+p1XIPRqx4nHVNmHVdSY 2kEA== X-Forwarded-Encrypted: i=1; AHgh+RpYpyWSkMSDzJRnjXfLtbrcuH+4F/P65TVDCvtUwKuCLfEtteO79+twXK3zt1YSBGG5o94Yw/LIH+uwYw8=@vger.kernel.org X-Gm-Message-State: AOJu0YwKsoOyDG31SBaOzU+bq33h3ZptsrnRWLjKJ4xPJZZuPGURCAgp XZINpQdPmfxmPFxFsZn/byeAi8+QX6aqPSjeeiBQjEKvpHSCv+5ZlwyqLGmLtsOy0Q== X-Gm-Gg: AfdE7ckbs9E2t6Hnugrio/lAWoqvyDoNKfQX6t1DBPHv822kqCJFPx2OLPH7ZGcdhyn j/SYxJp6Mf+69KUE2BuQD8RlF/tOps8ktJoeQ1R5LwGsXJAyWwxI8GcJ4dNzyCjNOdn/T9FSUCd N9FGWmO2iMNZKoilXYUGqnL4uQ35cUpHv22Fvza7RiqKOlYHK8ODW1U14Fw/d2xS0k8cqeABvYW lQ3gO1sQHcnpt3fmomlQIvr71U07h2bKC3FkEb53FyJtSJdBKgNwbnWrrI3c7HtROFKNgH/K4gV qtyBSMw+/GNPyx5FwsNO1sbd+izsUE9swu3lHWUxdkOHffuAquoje3Uffp0GdKPNDMUBFvroaCe 04Plo2ynv1qvDc0dCATaZiaTm1zxi7oRYp9V+m96OfVD8hWFlCyWSNrusKssdPnoprlyvV6kKHp CAHIUks5zNlLlNRCte9YdsSF03KoL78SKX/J63p0bdggKnIECICMEm X-Received: by 2002:a05:6a00:348b:b0:846:7507:4e07 with SMTP id d2e1a72fcca58-84826df3cbcmr3846597b3a.39.1783408773293; Tue, 07 Jul 2026 00:19:33 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:d4f4:6328:49c0:b912]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b9b389sm5003551b3a.13.2026.07.07.00.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 00:19:32 -0700 (PDT) Date: Tue, 7 Jul 2026 16:19:28 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: minchan@kernel.org, senozhatsky@chromium.org, axboe@kernel.dk, terrelln@fb.com, dsterba@suse.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, rongwei.wrw@gmail.com, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH 1/3] zram: fix zstd dict use-after-free on per-CPU error path Message-ID: References: <20260627070216.13511-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260627070216.13511-1-haoqinhuang7@gmail.com> On (26/06/27 15:02), Haoqin Huang wrote: > zstd_setup_params() creates global cdict and ddict stored in > params->drv_data, shared across all per-CPU contexts. When a > per-CPU zstd_create() failed, its error path called > zstd_release_params() which freed those shared objects while > other per-CPU contexts might already hold references to them. > > Remove the premature zstd_release_params() from the per-CPU > error path, the global cdict/ddict are properly released later > by zstd_release_params(), called from zcomp_init()'s cleanup > or from zcomp_destroy(). > > Fixes: 6a559ecd6e7e ("zram: add dictionary support to zstd backend") > Signed-off-by: Haoqin Huang > Reviewed-by: Rongwei Wang Apologies for the delay, I'm catching up on emails and will look into it in the coming days.