From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 601D041A77F for ; Tue, 7 Jul 2026 13:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783430005; cv=none; b=dA97JMxggH3ObvlgsqeHkGT1dZiCbx2LiClWgx5RgNaz/JpYNY1PHRN0hqKDli63um5IbxpeT4mL7bTlrg2jGEtdNB3aURyCptTbC/1IlJ17ma7vm0WN1TH/0iuxaP+ikwX/liM7eF9IrIo9nEdApDbKB1c4OLLnwfSfeJUH3YQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783430005; c=relaxed/simple; bh=MmybheBvPbZ9+fvtkdTreXu3lF24dABq4Vme1lUmp0k=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=A0w7daxy4hAzTS+wtJE/SjibhqzeEzvP0hZEC3BLS7i4yO/KlxihWL62mo9O1hpzKsUvq3xomJsOWClGeyegLO9wUNHjUTABy4PQDDWg1yt0AYZH03vaoEEmSGaGRxl/e2nY5yiGTYSTQMEvta43R7D+/RdRYTcZp7uQhqHfZX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gy8g+MBo; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gy8g+MBo" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-493caa3c54eso35590025e9.2 for ; Tue, 07 Jul 2026 06:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783430003; x=1784034803; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QAD8oBOQgciUMb3A+X2IkqOxCsD9BlkHYpuCHLlyDA4=; b=gy8g+MBoUjztWivompumUzhzsaJ3hsH4T6VEhW34lUpAt+L06Fg0xFp9KDWLnjQqXK eN/HpgQjaKk83u1AAY3qAPuiZVJDGpC5vXlLBIJQdQaNW4gs8x/vTOEk0rSd2AoFkitw njqAD6eTOaPPPyqkUX1SYup9dtF6zLHj8rz2Cq74OB2gCgeQ6ZoS9PIiIj3HLgdv1iCT eM4NxMI+Kjjck6DpB3/KMvZsrlTjQ/eh3gjvImwUE36aruEzLksN7qOajxRUsGypgTQv /VC2IWEUC1TzoEj5HXkomAjq+LV7llxaTYIKbGXuR9FbHu5KJmSfkqf1ZF4fiDMofRBD QKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783430003; x=1784034803; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QAD8oBOQgciUMb3A+X2IkqOxCsD9BlkHYpuCHLlyDA4=; b=ZfdmSowIZBu2ZCydqpPuJGMH9FLABkmXFGVB6/5TptTvASADB5YgXDJLL5AwT8ccy3 WvIvuEJ4iT00S2FMdVxRf2QSxBJixTlWhiaYQu69FjZ6hpOGCwQqXEJIZJZHJNXMIlye 1mzmz0Y3rBgEuXTxSRCv2DNYmd1t33MdPWKgm8RSltFpPIbfGlqo2+HniUYGU0hxG0Yk bZja6dY6pnvMiOTOKl6uiyxI44424FcMmPjzsQkwm2E48XSnef56x1EcfWJvGqDp8fsK 4IJrilHVW6UOkRt/oR6J1N0XsqO32gMNkZ93E99Z6j8c9UOu7HyAVXVtOOCmZa9IXKFE gBag== X-Forwarded-Encrypted: i=1; AHgh+RpM9mLUbp79sS6DVb2y5KUkgWL+T9J+hAgEXtt6mUZXOEoC507OfnCikF7fwvW4W7h2VotIH53qMDjIKGM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy16MwGrbwjujqzswryQsvRvmXw+jfng7oanDe0iYVcf9uXikZB Fns8hlQjzd+nxkN3eaurgoG5SmHCD/InEMS9a2ehHtteJ7Pgxy7ew9ha0qAeQgQiXM1ABpSTVnM 4loTtIjhAZ/m3/lPJ0g== X-Received: from wrmf17.prod.google.com ([2002:adf:e911:0:b0:474:4c49:fdb5]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e92:b0:493:b6ee:fcb7 with SMTP id 5b1f17b1804b1-493df04b124mr65012395e9.14.1783430002417; Tue, 07 Jul 2026 06:13:22 -0700 (PDT) Date: Tue, 7 Jul 2026 13:13:21 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260623-pr-ratelimited-v1-0-cc922f544dc0@google.com> <20260623-pr-ratelimited-v1-2-cc922f544dc0@google.com> Message-ID: Subject: Re: [PATCH 2/5] rust: sync: add const constructor for raw_spinlock_t From: Alice Ryhl To: Boqun Feng Cc: Greg Kroah-Hartman , Carlos Llamas , Gary Guo , "Onur =?utf-8?B?w5Z6a2Fu?=" , Andreas Hindborg , Benno Lossin , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Daniel Almeida , Danilo Krummrich , Ingo Molnar , Lyude Paul , Miguel Ojeda , Peter Zijlstra , Trevor Gross , Waiman Long , Will Deacon , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Mon, Jun 29, 2026 at 08:44:58PM -0700, Boqun Feng wrote: > On Tue, Jun 23, 2026 at 03:38:05PM +0000, Alice Ryhl wrote: > > +/// Helper for creating a raw unlocked `bindings::raw_spinlock_t`. > > +/// > > +/// For use in statics containing raw spinlocks. > > I think > > #[doc(alias("__SPIN_LOCK_UNLOCKED", "DEFINE_SPINLOCK"))] > > is not a bad idea here? I'll add that. > Do you plan to have this go via binder tree? (Sorry you might already > me the plan, but I couldn't recall). Anyway, > > Reviewed-by: Boqun Feng Yes, I think that would be the simplest. Thanks! Alice