From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CFA53EB0F5 for ; Mon, 20 Jul 2026 11:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784547298; cv=none; b=U8Rk5j1KJfTYZ21Os7gceMWziFvcRvPDJSZL3WYCjIqcF/TkwhYrU+97ZECow2De+BjT7/TzjwdfxDWe5XsmzVucnJiFvlsTwzzUg6WXiAkOWd/BApCSmIB3jbRno5YthMSOIsbp8a7/utMjLfpEfAy4+2t4awXcXHG4gIafs/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784547298; c=relaxed/simple; bh=5MEo8NUpZhRQI5j1rCBJtgFOMjhyLVipMDpM+l3a/38=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NWJDbIy30YywQ2OZxjQF7lEDDGM4fxOfWOx48DIQ0btB4K/HooGi6e/+c09A/wjtprMNTjMRNAO5jNKOiywhltgFJ6a8rP+NPUowe1MIJ41PHNqWWoA6KXkeBRxpaQfGj2XMVUn4P4l9EhbAqVcyELTYjgtZQ9lzWkO1i1b4COM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=PSSBcRAS; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="PSSBcRAS" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f707e5d75so785433f8f.1 for ; Mon, 20 Jul 2026 04:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784547294; x=1785152094; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=5MEo8NUpZhRQI5j1rCBJtgFOMjhyLVipMDpM+l3a/38=; b=PSSBcRASfZWOy/f5VGNKUOqPDIrXJe+gUyhBgzVU1LI/svZBLHNX7HAHb8fQCXuZf6 ma9dLdONJ/aGEMNEEsO094JYyc6MdFqk/OUL65GrlbzGsWfM27mrf3Thjg4BhKvZ79qZ AnXQ9nciq0TFss1MrWca2OL7rhR0ndCDQ+0f4VjjXU5qgtKFfvecMQvfPIXlOMHm+OQP pdoalJRb5QBt9Ph9pqnvfiI3Fjv+qKZ61jDmQIxfv7ADFOjegr3Gz9hDcWZKCOw7cCME KEnQi7++tSXfCopPexrwx8TDxVJtjyu876sSoBpr+IAHhJx/fCOizTuxwA8Kqegl7nBh GKfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784547294; x=1785152094; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5MEo8NUpZhRQI5j1rCBJtgFOMjhyLVipMDpM+l3a/38=; b=epC91S79RDr8w4BF6P9UC7BNwq1OORokDupZiFf9gSKYN7py7ezST+PKjVBYWOLJjX i+ixnWcrc6tUW+KxhhnKLWycJKQuBlhqG8HZ5i1yjfTrwwXscPZVML4LvOIxJFMYuGcW Gr3uGc+JI4mq1CrfRsvdo/dynmXTLvjiJGg7TGSuMU+Lkn7t+aplTsGsUn2fEikC781H GKoqrvDmwzgwsbevKAD5nAOvvEHTv6O1dz3YVNW+X7aoqSLX39S80aCkBJS8vVThNO4n WTgURMsr9RUYag0WTTwV2/ORGKkHkUramTk0VVDJFnrVIi1GsBvYQuRfIscaNFqA5kCc D8Rw== X-Forwarded-Encrypted: i=1; AHgh+RoRcRyuNl0KnDA6Jnjd3pe3PL6tjUA1WeZRuqTJ2NvZeIYKY67xWcpuxXz55xPDbiy64EeRkAv9biAkia4=@vger.kernel.org X-Gm-Message-State: AOJu0YxpNUPCaHdJzio//uxQAseoFtCBYuRzmtvnuq8kWgbFnqQPTiST c06Kqrena9JIhVpy0mlTe9RuHYg6Qla9GXA2vdvzREQIqCabdBU9pslOgXvHkUGtjxwB4uScwG0 fSwjE X-Gm-Gg: AR+sD13JxrusXGqJv3QhsPYARo6wCbFs3a2OfsIHanrXrbWmu/8gGt2k4mTkbPQX7q9 Ue7QaUuk81nDqI8GafJUSsz2bpX2IxeWFQMx9Cf+dpwNKnp9ZUKhQB+H9Jx+75TCBfIGMDhIk5h Jy1j4c7FFWyF1dRETniJYUjiV3pvZ0CqTtKLqTlJVmCpIU6DCU+Kxh9MQcWKaFeBh7pYGJiyR2m GJxEDCIt8B2pKxJjZ/XsxeNsvp02Tl/8pMEfv65mRDeMi9SAIo0LGj72/WHu+6dB2viKoXDGQ9p RL3sqzTdecQL4JjfjDlVhfja9N5HT3NiIEMHnt9y/5kk/82sd61nWykPA7R7tVtAwAiM9CjU4ud KT+MQp50CKljZH69adH0GzaTh8kyHCG0IU/IxAnApA0jZqsmepY019vwyMxOWqohyYu8I7gU8l4 QJz5iZJs98qK+gUmtTVAuXkMdH2AW5CODy6eI50uYOz/Kyuvs97gWohRnhdM8Bw+/q8g== X-Received: by 2002:a05:6000:4b14:b0:47e:aa3f:f822 with SMTP id ffacd0b85a97d-47f6233be35mr16319068f8f.53.1784547294401; Mon, 20 Jul 2026 04:34:54 -0700 (PDT) Received: from localhost (p200300f65f47db048587886ecb5b26b2.dip0.t-ipconnect.de. [2003:f6:5f47:db04:8587:886e:cb5b:26b2]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f6fa848fcsm19241724f8f.0.2026.07.20.04.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 04:34:53 -0700 (PDT) Date: Mon, 20 Jul 2026 13:34:52 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= Cc: Markus Schneider-Pargmann , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/amdgpu: Consistently define pci_device_ids using named initializers Message-ID: References: <20260429171644.8406-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rjr5ydhtag5cemwi" Content-Disposition: inline In-Reply-To: --rjr5ydhtag5cemwi Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm/amdgpu: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello, On Wed, Jun 10, 2026 at 06:55:09PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > On Wed, Apr 29, 2026 at 07:16:44PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > ... and PCI device helpers. > >=20 > > The struct pci_device_id array of supported device was initialized > > by list expressions. This isn't easily readable if you're not into PCI. > >=20 > > Use PCI_DEVICE* helper macros and named initializers which is more > > explicit and thus easier to parse. Also skip explicit assignments of 0 > > (which the compiler then takes care of). > >=20 > > The secret plan is to make struct pci_device_id::driver_data an > > anonymous union (similar to > > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylib= re.com/) > > and that requires named initializers. But it's also a nice cleanup on > > its own. > >=20 > > This change doesn't introduce changes to the compiled pci_device_id > > array. Tested on x86 and arm64. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) >=20 > Gentil ping! I'd like to work on changing pci_device_id, but that > requires that this patch hits mainline first ... Would it help to resend? Did I fail to Cc: someone to get this patch into some tracking? Best regards Uwe --rjr5ydhtag5cemwi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpeB9kACgkQj4D7WH0S /k5Z6Af9Gq2QxbDClvePDJgb1S0Btc3vPaIme+YCro+lTIwcbZZ1CHZKRKdrSSda ajvSbtUH6ZT2Dj/grtQNq0MAgwRXNJjpEtNUVhuKa/g/O9G6HseGT/JLZ6gpbE3V FvjvZLvFYE0cC5UBxPsfpJZWSZ4b6HHG2yaqgGbKG01UIuW0bu2ElQXzN8z9FLqW QjR8PEoBgfPQZA2TUqtRQ0tjbMFA+FEpFWkuPSmdDFVR4OPZUbAIltzKfYnCcmch cEnAnx/m12gfxUS1cBy7m120C/Ko+q4UszZPzbPrivbFGby8/E52ee+rVAuzdcCE TPAmP3ysP/Olxv7n3XJ9LHGrkhVHuQ== =E0ji -----END PGP SIGNATURE----- --rjr5ydhtag5cemwi--