From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 434A3330D2A for ; Mon, 20 Jul 2026 13:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784553867; cv=none; b=GTVU+DCywFzs9o3TEJZAPhKu70//LFjNuzuCSrH9ogER4Rw9MJnJo4pGQKxjCM3fItLfPRis1Dc2JtuXy4Mk9xiisJO+nvniBFOWDkrj10BOREJMCQbyMOigo+kcGWPA5N/lmMZF7qYjHILVQ9pOVPIaT4UjVg5zpkonQQdZCEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784553867; c=relaxed/simple; bh=Xf8sBn2Pnmjjd5VNjH7fEQNdI/Ka397W5d16XCphEUU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wvvug+u3M5KcThDWUGw9G4wwMKJEa7dPv1WD+FLzE1J8HRrdRAC8+Nd6HJKGZPJojdxI1vzpDMz1G5ld8BEkFxB2b81HvD26yiCOmbI1Te3U4UsEn6z5bUo21RZF2LCzwYV5S3Cb4Wlf0BhcOlh33LKjW0ul7BS1kvJPSiMJ/s0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eFxtgw5w; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WZiK4zdI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eFxtgw5w"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WZiK4zdI" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KAvXaW2457842 for ; Mon, 20 Jul 2026 13:24:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2rnuTTxS3dtHAIgoofax5iZiwmNO+2ul3JOTWMDYSu8=; b=eFxtgw5wut5B92w3 RtZVhajGc7llr/dfSaSe83kq00XNfrpnd8/z4naj0xu1FB2kRE5ClT3jFInM4NUk OYC/SDqCunEnuJAXFLaWEamwJE+jF5XzAECMf0TH8KGT2GCGKsBD8RkQNevWqaUe SK29H3kDJuKVntvjF3xkn3T/XNJ0RV7v4Cai3cKyn1xib7zOJQVepqd0zgt1VCQN D3OTVNOlrhrltPMuOxNITi9kr6IQGWHxBm/b4Nhd3r82vSAGMSCSGnDWu/m7z2Zx I4Ku6WhSOp1WwCOM61lpaFPN07QxjYiAtxTHCypTFVRmvMibPCSx0+cK0rn/r8f7 HoC55g== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhf0kskm0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 13:24:25 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c110a3b6aso109115771cf.1 for ; Mon, 20 Jul 2026 06:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784553864; x=1785158664; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=2rnuTTxS3dtHAIgoofax5iZiwmNO+2ul3JOTWMDYSu8=; b=WZiK4zdI5Dw+8sKJzRDzqAgS7gKP0t93P+kOn3iKAEkMjfNJGHMgOeLmwQWVnGpgEy +IC7m9WSmtIUG+ea9kcRnUskrCvAbiqg23zWjov08x6Ly2juhcSYGlPnu+u+umOpGkVo RNk75yJFSZLuAFbyOvPpg8EZpRac8qJLUSp7usjg22hU1/+hP9PyXKNoqLYV5J3HepmD 3+LzbVb9TC/J/X5SM1PQz+fHaeklhi3WyvjMHCbo+e5Ud4sFN57bQ6aHXcZ8fvW5AHxz 4W62NN1FvyYIjFxoYBXkAN2jozwmgLXhsfR51NskCOsB57U9ui1yX+CmwxP3KMoYy4p7 TLGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784553864; x=1785158664; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=2rnuTTxS3dtHAIgoofax5iZiwmNO+2ul3JOTWMDYSu8=; b=hkxuXmhRpuf+aw1QgKNUAmPDmvfzaUpMpaJf9f2DKhpbHhZkpH5XaSmtHyIF3wu2kM F0NUt3S5NxIXuWBs3PrWiIFPFZmfs69cGmTLOxFGXXGghwsb7tQbnv8uQH1OqW5suz3k FotLU36ktTb+TOr/Dp5BpWZXwtch87LGxQLgpuCd2rqakHqF9kBbHSEL44nI04d42Xob dGDXF8cM5/pLmZ844PuKy7Dfq+NaQSDsx89cvmsPyXm//5iX27NNAlej2n+JOR9P3NQR 0/K0DbMo/ZwZ649KUSwnrquTqKkM8xkmeg+bRPuRFufEYl6u4WYnCtD/u1qYCVss0Pma WFew== X-Forwarded-Encrypted: i=1; AHgh+RrUQmr8Xwj7vki9W8hrTiVMON3oLkYfyQpx/Ym9rtIg6t3d+rUmFqXblsZUluf6fFhPAOKUbicWxC9heNs=@vger.kernel.org X-Gm-Message-State: AOJu0YwlzF/coh+Gynb4yV1bpsoUxshJflReg9HAIuycgwn/sWWzab7h s137cZXvNjU9gnRTLCRAsu4lgUWih7M2J6iXTcdFFfSu2rwCDggGga0UxsNrCNKYq79wVdnugQh GJVxqKFMaJc6NntLqGE2wV1mFzcYBjmgfgJTXXgCgihwZ4tgzGjA4Rca7fMFppa5GbPY= X-Gm-Gg: AfdE7clllzBLu94++SpdjLQYo3zmT4+UFVrUFLxp0fnjxQKpqaI+SUXfgGzPL9qS5+D Lym/tUtUQeFDn01+47Nrev4/eGAo73HHIi79zKiN2rJ0yLI4QNmci/5NhSPi0lZ1oDX0i/YTHxL T/G4Ut5+ySZa6PbO7bF5yI2FaeasF12lET/zCShDR5sW/qWWlWUtITL2PpL2Nk2lVHthJwM3Nky m3gIJ9TJoLpn+koBW7+CJClIeEdEn6t7fQlDSSHghNkLa6R50BmM2zQEIftJJIQ4HnyZPqMUc/q W0OohCIDBEHZolrcuA6Pt21WjMSY10rx1fTS/yNoKptQh/fLXsUsTOCMKQVXu00we0RKFOTF60Z MZxuv++2Mic/IvgAkSwOD5P02Zy9QtwsXc4NETac0EplDL8TeGXaYgcYtl6Re/WecJEsEc21aok 0zgS2vYeJK1cp8Ug== X-Received: by 2002:a05:622a:4110:b0:51a:8b64:69e0 with SMTP id d75a77b69052e-5213d2b7109mr130718391cf.11.1784553864358; Mon, 20 Jul 2026 06:24:24 -0700 (PDT) X-Received: by 2002:a05:622a:4110:b0:51a:8b64:69e0 with SMTP id d75a77b69052e-5213d2b7109mr130717871cf.11.1784553863758; Mon, 20 Jul 2026 06:24:23 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291e0ea8dsm2337558e87.41.2026.07.20.06.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 06:24:22 -0700 (PDT) Date: Mon, 20 Jul 2026 16:24:20 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 1/8] phy: rockchip: samsung-hdptx: Fix rate recalculation for high bpc Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-1-ce5e1d456cda@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260612-hdptx-clk-fixes-v4-1-ce5e1d456cda@collabora.com> X-Proofpoint-ORIG-GUID: 5YAwUQ2WNCo8XEwrBTiAxf8jks9VYKyA X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE0OSBTYWx0ZWRfX5DxNhziVt4DS b3vgqGoVRq74Z3QB9bTFMLmk4sHmp+044e3koLKt0h8TkOghPel7pTYSUlyxHc2MZzvqdblA8lv rrRotjKwwMsU1Zy8RF74a5/oObCZ41k= X-Authority-Analysis: v=2.4 cv=G58s1dk5 c=1 sm=1 tr=0 ts=6a5e2189 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=LBX7SfcbrNp00noYVVsA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=dawVfQjAaf238kedN5IG:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE0OSBTYWx0ZWRfX38pyuJspTkih O+IClTMSNNl0HPLpuNRlTOUeO+P9HhEVq3XEBtR1BUNOWT6Yk0OUwc0kOHJyuH34iX0F/ZZukLr PDjtrqGB8HJ8O4Cx8JstoBzmj8nRILopySBUc2zAaUvr/5r3Q5ICIQcIa60KaR1N62sS+WLBdQI Tknl0LxIXrNg2QFfA5X7GOu05LRN8Xhjbu3RuqOzvMuq9TUTlAxSp/OC0hRaiYCb2c709oKGEdb ddJNs77FXCWemGvdQxqsgP4s/21FXqUzGe33d/yffAwqBFRnfElAf50so6XndBHno89fvszxROT 2PnQC780DP+tDkCDeoPCmeVKJw9PomeJUX8IHzvklS84piDTDIpyT31DbdcQTbUmM8GpgVrFrla UM3jx7tTMcYAWQuo2KowO2DTqPQFVYUurVrkvzf0bm57/APatFAS2KtL1zBAQCjsKivZw05RNwp 7uHcmy3Ae9sQXXTp7zw== X-Proofpoint-GUID: 5YAwUQ2WNCo8XEwrBTiAxf8jks9VYKyA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_02,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200149 On Fri, Jun 12, 2026 at 02:45:20AM +0300, Cristian Ciocaltea wrote: > The PHY PLL can be programmed by an external component, e.g. the > bootloader, just before the recalc_rate() callback is invoked during > devm_clk_hw_register() in the probe path. > > Therefore rk_hdptx_phy_clk_recalc_rate() finds the PLL enabled and > attempts to compute the clock rate, while making use of the bpc value > from the HDMI PHY configuration, which always defaults to 8 because > phy_configure() was not run at that point. As a consequence, the > (re)calculated rate is incorrect when the actual bpc was higher than 8. > > Do not rely on any of the hdmi_cfg members when computing the clock rate > and, instead, read the required input data (i.e. bpc), directly from the > hardware registers. > > Fixes: 3481fc04d969 ("phy: rockchip: samsung-hdptx: Compute clk rate from PLL config") > Tested-by: Thomas Niederprüm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry