From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C323BA237 for ; Mon, 20 Jul 2026 13:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784555000; cv=none; b=nUj0Oe8TgbwXM0/kxxiyNf8kTwvv1URULkTUrIFS6Q+kCc97fKFYl7jC6e3KjL031LnWhfQX7TjbBJJ5UNRHzvxNBbzE4EkqMwjDXxQkdIvLRpfHJ/97isKWVTKLvLkgMBH2pZEAvtTLs9guMpBhDsnTR0JY9QwFQKiHkAebg7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784555000; c=relaxed/simple; bh=zmBJ/0A84g3rungkV5GDtUzaTyuvksj0gerDJWlqPf4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fjq+lPSLpRUg3aXkd/i4TgrSmI+8SmDLIe7erdjLNQtT+3Zce1jWJRBAY+d6G3c78lpSPkgi/l0nrkoBnPILJnD6Oz7EI9F2M1iKkVGd1MuI7pzej4/cfHn5+x3XG30zUa6YwbiWl7l4U51vO5798kLjYnGvgSiru5SZb0N8r7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=VKYXOJaV; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="VKYXOJaV" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4954d29264cso12282225e9.2 for ; Mon, 20 Jul 2026 06:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784554991; x=1785159791; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zmBJ/0A84g3rungkV5GDtUzaTyuvksj0gerDJWlqPf4=; b=VKYXOJaVwdS5a7a7y6wBBKng3z/GnWsWuT2JM1MfuuAMLeAxGdBHSBCenrxfPufAF1 GqAEHI/WxWcA596B5Nv7+cqksIzfsrmT/ZZEqHLM3XZVgQa4XN5WFIh4ixNZX9u2QaOH ydBjJ2EEUUCu/N43q5U1B2XW8wst8vR6EMidnNp6P+RbFJ+4cu4m8+ArRva3K1XF3DxE M8MmtNpQu7KorhGx6QINqnrQUiKkgpLXdg5FZxEbpoyzRwdHQhWhIUTvcO/LkvA2p+V/ 8vgFaCDDYdDTCC941DdsPdKJsVbaPUt3iNXY64T3DMqvotyHcenbPO5UeeXKXHp35CaS QXUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784554991; x=1785159791; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zmBJ/0A84g3rungkV5GDtUzaTyuvksj0gerDJWlqPf4=; b=Gg8FNE+h4PGx582VIpWCLJATBfUxkmoiR/eK2VNSaxhZUEWPsHNY6+alBqnY2TrmRC i3ntZitjcUFmZu4l8OmYDLWGCxG9ecKZhuYXG4Cur+5cdkJs87vGz8tvOQ7HgLKxOjcG Uy5i1FM1tSm6FXMWe7Ln+UZaL4TnZWc5D77wQUh3lV6IEgpx/JuoN70eMUjWfwpvVhLS JBggv1gcfnrXfFnekad28KLv1oj8ZE1ddu2ROW7z+eBw5eZSkJJxeNT0PHOfrHfZlZDG rAcQMUDJ+y+FYtafyxg+DZ0C/rGx87OYHIedcO0PS92vP7enxarCirEt4kPfAJsDTL3E 9N4g== X-Forwarded-Encrypted: i=1; AHgh+RrqnoF+nnUDBRR/OMkDbfuwHFnJGFyu83gTp+bS3RlqOR5xK++SEoRhBpdl0MJOfhPWIubGPMbZ4ctRL5g=@vger.kernel.org X-Gm-Message-State: AOJu0YzZpL/p8jz8hz0c3hcJXoIyI7hTCwrIuBpNkna972tmilCsHoml xkkdZAantws1nbRSPhXS3jufdxf7AF9wdzSPZDwiEcVQuCSJ7nrBsSz7Dq9EgVY0DH0= X-Gm-Gg: AfdE7cmQJlf6TsFzypDvTj8mCLYZp/ILaBLZoDPxagjIceTk3sQToAT3YsIWFq/bZxV iTIWosV9aFXf8Mgbay8syVfpY2gSe3Lcxu38av39Xnl5mDrmMoKLSd3foT327mSe3hfYrXVKWGd 0UvdYjVAgYTLfNhTHlj9SDeVL3hFjV9MXowNNntJ9ojtbtezmuTUVyshvzOqrEn+3E38n5XEjvJ 1w34phr2Id+bR1ab9BJ/lYrOrP/gZ4kBefW3Plzb0SLjDyxGGeGUo2xcFrFyIq5rYAKC3Zv2EVK JPWIVFWV7iv+zmG6kqj0f22J/6gD2LEgpS5dj/akN3KeB9E3GRn1rmrXZbcMeebIRnLFTLy4bZV XczS89arvfPBbY7v+hBF81pU3Lw5V42AfkdN7zyOuHoBmOGhy2vOLR1u+Olqy2RJatpi9cdl6dB rjiduNRSPbapJq9YNh3WV63vMh86oxekYcYx6LEE49HSTkn3e2qb7K6tNt0f9UkDhsDg== X-Received: by 2002:a05:600c:4685:b0:495:3f99:849c with SMTP id 5b1f17b1804b1-4954a3f48ebmr182901205e9.15.1784554989689; Mon, 20 Jul 2026 06:43:09 -0700 (PDT) Received: from localhost (p200300f65f47db048587886ecb5b26b2.dip0.t-ipconnect.de. [2003:f6:5f47:db04:8587:886e:cb5b:26b2]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4954a2e83ddsm273264985e9.10.2026.07.20.06.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 06:43:08 -0700 (PDT) Date: Mon, 20 Jul 2026 15:43:07 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring Cc: Jean-Michel Hautbois , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] can: flexcan: Fix probing for m68k/coldfire Message-ID: References: <20260618140147.142489-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7gz5gbihnzriqixc" Content-Disposition: inline In-Reply-To: --7gz5gbihnzriqixc Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net] can: flexcan: Fix probing for m68k/coldfire MIME-Version: 1.0 Hello, On Fri, Jul 03, 2026 at 06:53:16PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > On Thu, Jun 18, 2026 at 04:01:47PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > When determining the device details was reworked in commit 5e6c3454b405 > > ("net: can: Use device_get_match_data()") there was no replacement for > > the previous handling of non-of instantiated devices via the device's > > id_entry which then results in a NULL pointer exception. The only > > in-tree provider of such a device is arch/m68k/coldfire/device.c. > >=20 > > Given the id_table only contains a single entry just hardcode the result > > of `platform_get_device_id(pdev)->driver_data` and drop the unused > > assignment to .driver_data from the table. > >=20 > > While touching the id table, drop the unusual comma after the terminator > > entry. > >=20 > > Fixes: 5e6c3454b405 ("net: can: Use device_get_match_data()") > > Cc: stable@vger.kernel.org > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) >=20 > Given this fixes a crash (NULL pointer exception), it would be great to > get this applied. The issue is already old (Sept 2023, v6.8-rc1), so > there is probably no urge to get this in before 7.2, but getting it into > next and then 7.3-rc1 would be good. This still stands. Marc, do you have this patch still on your radar? Best regards Uwe --7gz5gbihnzriqixc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpeJegACgkQj4D7WH0S /k48MAf8CwYvCoFTxvTNVmeMwQ+UhSiB1fZhEmppRaXZ2vbqFGkPOjgM+F0G4QFS Y/GxMzMygtEeCe/rv2ucw5+rB0pWJE7hoCmCsClXHTsMKzb8MPxZxVypHSVoRMlj MVC+5Y0r/9ZrfW5W5iFV5Y43SzmDutjkvF8mbFI/1Zrs3n6/nH3mxNRjGL/1A5CA oA0bOtkd6lOHVyU4s/lZFfji4Tg3Q0X9Fgs3tmA/5Ev82QhVnW3spANA/U7x9jhM OzBD9sDszUbJFf0GdA3DG7jZ3dsePRePy7EfPs+rT1QHbxiLjFTcAY/CyyH07MMj RgTX4AWpQlxwcMSuOeP7UvJmtyGjxQ== =sovE -----END PGP SIGNATURE----- --7gz5gbihnzriqixc--