From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9B83BCD07 for ; Mon, 20 Jul 2026 13:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784555159; cv=none; b=Xb8nX/AnEHn73tDwZChNdOH92XiQOb26E6ty2O1Ej+SX811BMNXXm7XtHlGeu1RBqxttnEOfxBPTDTHTf2uZNN/63qBvpGr91mWdD0aP8Ej6RzR4yG7hJ2cYOa9JIooWJ+BKI/FYQdrJmliCui1qf7E4QQ+jtMQlNQkHriaSAOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784555159; c=relaxed/simple; bh=jTUWRfK24l00hKUVp+X3wKsTU4+l4+mJzP71Xpyoryo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fW/cRFhGAC4qErUjX3UR6kSMxtQxZeOXQeU8ELfMifcbca6lclKjaluQ5NsaF0WOEBSChbz/OTBsGzEoTcvdpE0ECi+TArMvBz+EkYxdi/46TVbxyYHbYyOhQuEatmsfWUfzwWsRR1qHokbm1qRQsUixg8nlle86/U8h1CIfrjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D2S7HQpA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D2S7HQpA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784555156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jTUWRfK24l00hKUVp+X3wKsTU4+l4+mJzP71Xpyoryo=; b=D2S7HQpASVYnc+6QDKuPB27YdF0uviPabwSzkeyLr/9TxWc9zHQmhufUtl0cTh4h694AdL iBL+59+plt98Wc7hvs0ri7EbCN1Cpf8XUgdZie3m0vGqhkNvV9ABuKnD9MpJBczrdFfOG3 NPrAEI1JEuOohWrxHY/eRoThX/TLpp0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-KiFn8M6EOG6nbQQCxW33kw-1; Mon, 20 Jul 2026 09:45:49 -0400 X-MC-Unique: KiFn8M6EOG6nbQQCxW33kw-1 X-Mimecast-MFC-AGG-ID: KiFn8M6EOG6nbQQCxW33kw_1784555146 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0EB4B1944E42; Mon, 20 Jul 2026 13:45:10 +0000 (UTC) Received: from fedora (unknown [10.44.49.164]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id BC8AD1588; Mon, 20 Jul 2026 13:45:04 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 20 Jul 2026 15:45:09 +0200 (CEST) Date: Mon, 20 Jul 2026 15:45:03 +0200 From: Oleg Nesterov To: "Eric W. Biederman" Cc: "Cen Zhang (Microsoft)" , brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, avagin@gmail.com, ptikhomirov@virtuozzo.com, mjguzik@gmail.com, include@grrlz.net, legion@kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, tgopinath@linux.microsoft.com, kys@microsoft.com Subject: Re: [PATCH v3 1/2] pid: deinline kill_cad_pid Message-ID: References: <20260719155842.7069-1-blbllhy@gmail.com> <87tsptu7b7.fsf@email.froward.int.ebiederm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tsptu7b7.fsf@email.froward.int.ebiederm.org> X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 On 07/20, Eric W. Biederman wrote: > > "Cen Zhang (Microsoft)" writes: > > > Move kill_cad_pid() out of the header without changing behavior. This > > prepares for taking a reference to cad_pid under RCU in the following > > fix. > > nit: If you are going to uninline kill_cad_pid should be placed in > signal.c not in pid.c > > That is where everything else that sends signals lives. Agreed, but... I had a private discussion with Alexey. And he pointed out that if we move kill_cad_pid() to reboot.c we are almost ready to unexport cad_pid and make it static. The only problem is kernel_init_freeable(). but I guess we can shift the cad_pid initialization to reboot_ksysfs_init(). Anyway, this needs another patch. So I agree with signal.c in 1/2. Oleg.