From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0667352C3C for ; Mon, 20 Jul 2026 14:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784556112; cv=none; b=IOtTeWeRgTCo8LqzEVRsZuaGpzHl7EAukudu9QwxpzzRIUjHLbwlAE9+QcFNRz1sASZgh+uz61loUdbA+BsflzLN8H/iqYs70xSlh2S/3IfZaaWK4fWaaGJP16TCBeiweVs2xW+EBkk+z64BHs3mj9WiuEhfSQDL985BblVmhqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784556112; c=relaxed/simple; bh=O5JZPx+4cG7J2idyU2ig+NVv9LEuHLOijjzPWdXaX3A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ceH0k8cDnmz5OH1z/3h5MBkhMmppqhyi5kOhh+yTt+ubHfcXAd9oeHuqrCZ3XoZ4Gfz8EX/hdCY99if72uQW7Y6QUpVEV7hMzPHrihDrpQl/8Dj4b+XQeHTk02JWE6XBP+kvfj7HkFKjU5m8csHDJKvJfLsXbC7p4d90g1mR+QA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ajOdTFaU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ajOdTFaU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784556109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O5JZPx+4cG7J2idyU2ig+NVv9LEuHLOijjzPWdXaX3A=; b=ajOdTFaUAL9RXGZTxIjhLe+cebMeAZNYd6JPZs+oAakEf4MFKXtc+hVih8CTuJAea4I9kz xpxiF6zifXKRxZhL/IVXqTSgMqLI1qBq5oIGXvXIqaDTXDl8uScaAndEd7dKNIPjeilnNn flGBeC4oh351JpYACjuPl/O05pfNXWs= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-5EFRSGhqNs2vBbk9Z5atCg-1; Mon, 20 Jul 2026 10:01:44 -0400 X-MC-Unique: 5EFRSGhqNs2vBbk9Z5atCg-1 X-Mimecast-MFC-AGG-ID: 5EFRSGhqNs2vBbk9Z5atCg_1784556101 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 586F71806D2E; Mon, 20 Jul 2026 14:01:40 +0000 (UTC) Received: from fedora (unknown [10.44.49.164]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 9CF83195422C; Mon, 20 Jul 2026 14:01:35 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 20 Jul 2026 16:01:39 +0200 (CEST) Date: Mon, 20 Jul 2026 16:01:34 +0200 From: Oleg Nesterov To: "Eric W. Biederman" Cc: "Cen Zhang (Microsoft)" , brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, avagin@gmail.com, ptikhomirov@virtuozzo.com, mjguzik@gmail.com, include@grrlz.net, legion@kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, tgopinath@linux.microsoft.com, kys@microsoft.com Subject: Re: [PATCH v3 1/2] pid: deinline kill_cad_pid Message-ID: References: <20260719155842.7069-1-blbllhy@gmail.com> <87tsptu7b7.fsf@email.froward.int.ebiederm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 07/20, Oleg Nesterov wrote: > > On 07/20, Eric W. Biederman wrote: > > > > "Cen Zhang (Microsoft)" writes: > > > > > Move kill_cad_pid() out of the header without changing behavior. This > > > prepares for taking a reference to cad_pid under RCU in the following > > > fix. > > > > nit: If you are going to uninline kill_cad_pid should be placed in > > signal.c not in pid.c > > > > That is where everything else that sends signals lives. > > Agreed, but... > > I had a private discussion with Alexey. And he pointed out that if > we move kill_cad_pid() to reboot.c we are almost ready to unexport > cad_pid and make it static. > > The only problem is kernel_init_freeable(). but I guess we can shift > the cad_pid initialization to reboot_ksysfs_init(). > > Anyway, this needs another patch. So I agree with signal.c in 1/2. Forgot to mention... Either way 1/2 can remove EXPORT_SYMBOL(cad_pid) but it has to add EXPORT_SYMBOL(kill_cad_pid). Oleg.