From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A66A3B811F for ; Mon, 20 Jul 2026 14:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557205; cv=none; b=HLxCNHWr+tFoJin6dYknpA7YwDSJuxqB4exk88DmaKDnePapgBnxlBkDZmqm+K2Rvyfm3SrQPwsBL+pKYNf/laNkQsKQx0gPOnVVrS1gIlcH8RFZsocx8PcNlCFhVeHDrE5mpHGAGh4WxdaOUiGHOIQ5yAuWYUij1em13EyGyGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557205; c=relaxed/simple; bh=ID1CroBiIV9kV6qLXjkwoQJVZQH5ZPGsMu/Wq2VPUsE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IB2+HSMdKCP+emOXGKIs7PDWtXSD/SvUiqjuu41iO82y2uxvkf+QD+kNwCT4N8J+GvlRts/SC+704GEh7GtOc44Vx9mRKs/gHO8dXSJVbQBbH+62vuFhGaaLfkSowAVfFSdqU5xWHColyIkJTJyyIiC0q40SKotuHy5egKEMKL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gOFLNXiH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YBiXES/Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gOFLNXiH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YBiXES/Z" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDquUs2839963 for ; Mon, 20 Jul 2026 14:20:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sjxGraRdWr9o18D48nknKGR/TQtYQrAOX4PFkQIou1g=; b=gOFLNXiHFRrsIK1w rpNq7QNHCXsdyzVUgcfHx5cszS0zvJkjoXzOyBb68dxrSRiPeEpwP1os0jAD1xo0 1TBn+YB0559oBLJM25Z1JN8Vycq0XHXc7HvAIxRlQShfBvy1hgI/DZF+EkP13uNK SuQUFCRJz7l+vfyc+WVjLNyRAGR0a32Tp+dobB/74sDu8ImG7QD5P2qVKEhAIjPE /+LIaN4IZyoBl0tU0Rb3j0J0TagttyjL2sjr+BmmExq3NSvTn6hxJ7QLTAvOih2x NwYp1Krx9v3yg+QenF58VF9GGAeWCX90boApEW45IrZIWlcTU0SegRFVIXDCG8Tt 753IHg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhfvxhmew-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:20:03 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1d137a68so272066601cf.3 for ; Mon, 20 Jul 2026 07:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784557202; x=1785162002; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=sjxGraRdWr9o18D48nknKGR/TQtYQrAOX4PFkQIou1g=; b=YBiXES/ZCI249e4UIEuDQYWRi8E62g1sqxq1sejJv50uPngXxu9UXoGlVrOmfh6zDL vJsCX7+yOLt+wZeFv076H7LCznUXXLLrjA9sD9Su8pknqD9W8Oi6ECLiIRFG8A2T81AS Dh3Xr79EgveiCkD78UhwhDqWFYKZbX6cOUycNSZGlJpAgrLqJ7wSlssNjwmC+PyDH6KA ydqu4v8bJTaoHYj2QT8z9uQFgCMB77f4pLqS5LsS1enlM9DgaNB/YEaXoIrm1e2fzvR4 zXs8OpoCScja8rW/Ymtabea34jmiZxmuMgChjJ5O+INm6SkFB5iYCRFTIqi3S9XAFk0m FsBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557202; x=1785162002; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=sjxGraRdWr9o18D48nknKGR/TQtYQrAOX4PFkQIou1g=; b=bTCYGevrTXSxZ/vxEk/PPutws0ssttMN3llD8sX6MhrnHXcDujGvv1Duj++V5/0Jqs 8CbKIU9ycqWPzRYSOcFlqG25Z5tBnYIWsK8T5bPFAow12GNp2+JFQ0xeG+ODAIbBQZdO N1FnbrVqk266TyonyWUNTAsFKaqTeZZnwDxHEeTUsHnyH2qTU78sjJmS8e3I4wo1oSGS fwWyHwfM1dkq+EQ04fh/PPNeozX3hJntDXYBjNqrYUN0Kr4/BB+8DAVaBuNzj5SnhExt Vrz7hCAJ+bbKcbhRQAkBMXQyS6iO1To6k5/MPB8yrUcefRimQdKDEtm/1cEba8zci3Lz LZgA== X-Forwarded-Encrypted: i=1; AHgh+RrFxzR/LNwnfdyGhJ933HfEWVgWm6R6HxhTE3VYxqR14gaPoP16Rk4aYdgFBNWf1c1S4i9ObJhz9TqZd9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yy02Kfyc/Lvwt0Ivk9FXkhOGkQelRRzOAegcI7q/fmJhZKi8LcN edS6wXgiaawJvDazPkig4eghnS1FBxIb+qNHpMVo5cYNDKue0tCuqPxKOSoVhRLMnyx+hKUI8NH u/SByM/e1YNT5ysyF47ECKjqxP5Tw5z/r+AS4mUNyyisnGSaafpTwZ2ApqsU1vAA+eLE= X-Gm-Gg: AfdE7cn7rZ4G37z+MmiHAi8e4da/aG7y80HqLvSWnyB9TXXdfAbEh7G2Wy7Icb8syoz geQasvm5+J3jSdFp1LN1sO0P5ovSHEfoWii22PAwmDt24EM7P4OMaQZPfe3440Ws0yhIbokE/eA iuZlQWAP3JFEYtwnH02VC0vrOpO0QvKroUBWUCfDMP9748RntqOlp5nsLF+87a7EX/86JOcPIlS 20L9gIEfGjJt8FSC9eY9g8j7IlSwQPhHLSXdEP6EugKGKqeJw3eUUceU/giv1stSbQx+7ybA8U2 f4AccB0JUUbUCuVSPt0QBY5V5ZsxqvEMaK8RWXr37g0kPstdKq7RvjiK2nGO1btM51xiUxPJZNJ V6tyuJw7ORFrFkmz7Ioiv/6L7zxp55cAsU3Z8XN3nWDoHTD5nilszv00z6do3aeVllLVCuC1N37 8HvnF3VvChWKNHhg== X-Received: by 2002:a05:622a:1186:b0:517:6804:3732 with SMTP id d75a77b69052e-5213e77cf30mr120810551cf.55.1784557200546; Mon, 20 Jul 2026 07:20:00 -0700 (PDT) X-Received: by 2002:a05:622a:1186:b0:517:6804:3732 with SMTP id d75a77b69052e-5213e77cf30mr120806691cf.55.1784557199310; Mon, 20 Jul 2026 07:19:59 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291e245e5sm2381076e87.71.2026.07.20.07.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:19:58 -0700 (PDT) Date: Mon, 20 Jul 2026 17:19:56 +0300 From: Dmitry Baryshkov To: Cristian Ciocaltea Cc: Vinod Koul , Neil Armstrong , Heiko Stuebner , Algea Cao , Dmitry Baryshkov , kernel@collabora.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas =?iso-8859-1?Q?Niederpr=FCm?= , Simon Wright Subject: Re: [PATCH v4 5/8] phy: rockchip: samsung-hdptx: Drop TMDS rate setup workaround Message-ID: References: <20260612-hdptx-clk-fixes-v4-0-ce5e1d456cda@collabora.com> <20260612-hdptx-clk-fixes-v4-5-ce5e1d456cda@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260612-hdptx-clk-fixes-v4-5-ce5e1d456cda@collabora.com> X-Authority-Analysis: v=2.4 cv=HKLz0Itv c=1 sm=1 tr=0 ts=6a5e2e93 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QX4gbG5DAAAA:8 a=zwdtIQzbwfcTUTQlMeAA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE1OSBTYWx0ZWRfX/Xyzojw6tYCr JOJPoeAHRQg9nZyiX+0SmVRyHs2Y9Kqt9jtjyR01OAeMv0XyX6j+V49OvoRmfHlh+fCz36hY/NK EuEQHJJ7B/tri1Eh+AJEFdSNPsY5ZPQ= X-Proofpoint-GUID: Nd6K_xtTf-e2ULrzYAs3orw2JugjWlBM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE1OSBTYWx0ZWRfX9eLahsoFppwP WKwS2roNJ3gMpjXnjF4abPM3+w05FBqUqtJ4jg3pRhm7b7HlzuOm96MdO9oMXBHeFy25EUsBcoH H+zr5ReojrykiZ9i1+NMSa8EUKiqPwYn0VWoaE33N+nyksM08Mq8ZCKBzMpp6AGDJYEqUa0gk2R /115KaVUDZJD4vH+I56H1QHj/Epv/q0eo054kCfDpwANtGeqH883Jy2Sdf0d/15mNtuYJDq3JeX bfyFBsAcjbFGj4YpNsINevkuEOCNEBTpEi35Vvw5T3ReRThDHeHfmXAyusbeKnpiKmUni91PI15 nKz0+YRvBeiZts63Yd6prwUs/B/zxB/Wr70DKgUNCxmO61bM+pZD6sZjqRfiIsdsw8pCSlWLIpD uVgdQgwsd+qjCLNNasVURIgCisivh//oHyK4+sL5HQe7lYMLlSBuFqxMeGRdXA8UmAq9/ihg9/U ZDfQ8q1IJJSyeP3Sm1Q== X-Proofpoint-ORIG-GUID: Nd6K_xtTf-e2ULrzYAs3orw2JugjWlBM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200159 On Fri, Jun 12, 2026 at 02:45:24AM +0300, Cristian Ciocaltea wrote: > Since commit ba9c2fe18c17 ("drm/rockchip: dw_hdmi_qp: Switch to > phy_configure()") the TMDS rate setup doesn't rely anymore on the > unconventional usage of the bus width, instead it is managed exclusively > through the HDMI PHY configuration API. > > Drop the now obsolete workaround to retrieve the TMDS character rate via > phy_get_bus_width() during power_on(). > > While at it, get rid of the extra call to rk_hdptx_phy_consumer_put() by > moving the statement at the end of the function. > > Tested-by: Thomas Niederprüm > Tested-by: Simon Wright > Signed-off-by: Cristian Ciocaltea > --- > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 27 +++++------------------ > 1 file changed, 6 insertions(+), 21 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c > index 25bd821cd039..35997087d61c 100644 > --- a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c > +++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c > @@ -1660,22 +1660,6 @@ static int rk_hdptx_phy_power_on(struct phy *phy) > enum phy_mode mode = phy_get_mode(phy); > int ret, lane; > > - if (mode != PHY_MODE_DP) { > - if (!hdptx->hdmi_cfg.rate && hdptx->hdmi_cfg.mode != PHY_HDMI_MODE_FRL) { > - /* > - * FIXME: Temporary workaround to setup TMDS char rate > - * from the RK DW HDMI QP bridge driver. > - * Will be removed as soon the switch to the HDMI PHY > - * configuration API has been completed on both ends. > - */ > - hdptx->hdmi_cfg.rate = phy_get_bus_width(hdptx->phy) & 0xfffffff; > - hdptx->hdmi_cfg.rate *= 100; > - } > - > - dev_dbg(hdptx->dev, "%s rate=%llu bpc=%u\n", __func__, > - hdptx->hdmi_cfg.rate, hdptx->hdmi_cfg.bpc); > - } > - > ret = rk_hdptx_phy_consumer_get(hdptx); > if (ret) > return ret; > @@ -1701,9 +1685,10 @@ static int rk_hdptx_phy_power_on(struct phy *phy) > rk_hdptx_dp_pll_init(hdptx); > > ret = rk_hdptx_dp_aux_init(hdptx); > - if (ret) > - rk_hdptx_phy_consumer_put(hdptx, true); > } else { > + dev_dbg(hdptx->dev, "%s rate=%llu bpc=%u\n", __func__, > + hdptx->hdmi_cfg.rate, hdptx->hdmi_cfg.bpc); > + > if (hdptx->pll_config_dirty) > ret = rk_hdptx_pll_cmn_config(hdptx); > > @@ -1716,11 +1701,11 @@ static int rk_hdptx_phy_power_on(struct phy *phy) > else > ret = rk_hdptx_tmds_ropll_mode_config(hdptx); > } > - > - if (ret) > - rk_hdptx_phy_consumer_put(hdptx, true); > } > > + if (ret) > + rk_hdptx_phy_consumer_put(hdptx, true); This looks likes an unrelated change. Could you please split it to a separate commit? > + > return ret; > } > > > -- > 2.54.0 > -- With best wishes Dmitry