From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C5B357CEA for ; Mon, 20 Jul 2026 19:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784574187; cv=none; b=KUR1AAtQKw/F2BROUCy4yai+g4117JM1N46JxIv1WbmVXMdh6sFRsnGspjuSFS/vDdILMIeGHFNT0pr5sETIujUHwbDJWvbsgHuiXWJ32+ty9z4JCFDZlWkrBXIqP4SW+VpnnhnDCSwJkI79A/SztK+c1RbYybrQs+Oj0zIyamo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784574187; c=relaxed/simple; bh=npO40HNu6G7vNoWH/xfhYoxvUV+rD3YxcTBJYjQ/ikQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=byN33kx4LD+c1nvS53ynD8TS0Lx5S1ZGadXRKItQoeHH4LUcEo5TVJAUbnviavo+m7DRmIFd+OTZ+fRxlvHIMk4Qkud7MbzOmTuhoZvqgwICNqNhBTqrLNzslDYHQGRYc7ulblmkpBJv5GA0CIFAmpEGmBiUuBfDsZSzB73MqBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cVx7IOL9; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cVx7IOL9" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49546c690ffso27654725e9.2 for ; Mon, 20 Jul 2026 12:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784574184; x=1785178984; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ADiUitgJtlg1qZ/LHubhQUG1lGSN9jDviGJhaJgAv74=; b=cVx7IOL9356jHZarWIetsiYg2KwNYSw3K2rZ7yObEYOqrNkBHpg3n+f8CIPM05ihg5 Q03O4uVxKeNvBen2e0jfi1GXrtLEkufTyixdCoqKADsun+mZ9IOQGm6JdAC/VRzRAOKT PPNXwmBZIFabZt2eGzFceKFOuoqfN3wA/gr/UhZBu414EE+T6di3wQtA2x+9sU+EQb3b VA0/bZZUgrAtWKJKPmGtOYbZAPLnavYdWDT1CpnuEVjca9k6WKcHDrZgdNlD4M5fHtos WpNwmkcAp/KT98INDruEt6asTVAAaVMWaNS6nadzxZViA7KWSMJVZzwbAPD96ST2V3d6 uQPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784574184; x=1785178984; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ADiUitgJtlg1qZ/LHubhQUG1lGSN9jDviGJhaJgAv74=; b=A6qrc4dECIq7f6RFYK9CrdOKQnRyi1i/7itq1jXMX00FDqI/x+Qjkj6K+NbZl0Qmaj o0t3QwE0EGg8ovXQ/pwFGTv+X1xkLxlJjNvzGezmyz+bDDXkGk1au6RzXmSn2/ddMrXI kFhKXVDQSLD3cytaXoWIfupiatl+LYWpCw3pzzjgJNh9j6CfoZmQ/Oj5gzgSzCakTxcZ dUxdSJy5qdXuiu2HxNEhmBvmqzo7qJ9O77lGOroOBUcb7fcwoE4bhopTtk8wjfcE8+xZ ac85Sp/aYUUaK+cBedIdjEBe9dRU3/IRMrlW1R0MNAJFBnBJNX5wRWSO8BeU6GhGpYFB lNfQ== X-Forwarded-Encrypted: i=1; AHgh+RpRrb4y6i1kb2IWAPQPLmjVyollhfDyHfSfEu67wWCmtFMAGWcCUek+8ok7K/eACValrldtpv4k7ZkjUUg=@vger.kernel.org X-Gm-Message-State: AOJu0YybxizsWGtEYDXB7KCla3aNKFOCvWN4BnMSBnriWQJfm1JFTpJ4 kpaDl/eTvS4CaQW+m2g4lqjC1PmaMFOV6KhPkUsabqV6f/e8tZKAuIIilvckaqkofIWw2VUuIcX TLmECOA== X-Gm-Gg: AfdE7cmQN6m/wg80hNYofR5r49v6rOOamgbQ9qwPKzA36diTPQBS161FkB6TRcqQ2Sv dhbDI/ObmVyxsABvIZ32Q8S8p+u/kC6uGOk56z98KhodvfK+z0TWYyP0Ip5oJQ1TdxeH8olsIrE 4yv9aHeGq5c3no2X4L0AA8PBGaCPzDjMQgs/K5fKFy0TBAMq5jhGHnn/0D/NOu3LKNVHfb+pLHW ZDBBbJN2h+2EkmgMjZt1qL44bBZ1hPCSnmxd+JVt49LeASnda1qCfrLZBH4Tlhv1hxpC0ME/8V8 0R2BQePz9s2bMjtBIUrPlkgSiwiFvMEwtYTp2755mQujB7afBd4nbsTSVoo7QFmYrW54Tzeecs4 fZyaaBfq7o5acYpslmxCRNWoDh+cQayhGvjYbKF/i9OMAAk6QaCLWTqX56FhbVUVJ0HuoqfFG51 AxVQyPJfzriIiYsWX+fDPaJgz0khb8qzxZd3ESQTAa X-Received: by 2002:a05:600c:3114:b0:493:f278:ba2f with SMTP id 5b1f17b1804b1-4954a3ed46bmr179664585e9.9.1784574183734; Mon, 20 Jul 2026 12:03:03 -0700 (PDT) Received: from google.com (137.69.77.34.bc.googleusercontent.com. [34.77.69.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956537c6besm9428245e9.8.2026.07.20.12.03.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:03:03 -0700 (PDT) Date: Mon, 20 Jul 2026 20:02:59 +0100 From: Vincent Donnefort To: Fuad Tabba Cc: maz@kernel.org, oupton@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, will@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, tabba@google.com Subject: Re: [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable Message-ID: References: <20260720184850.1826630-1-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 20, 2026 at 08:01:55PM +0100, Vincent Donnefort wrote: > On Mon, Jul 20, 2026 at 07:48:50PM +0100, Fuad Tabba wrote: > > When disabling, hyp_trace_clock_enable() cancels the clock work but then > > falls through into the enable path, which re-schedules it and marks the > > clock running again, so the worker never stops. Return once the work is > > cancelled. > > > > Fixes: b22888917fa41 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp") > > Reported-by: Sashiko > > Closes: https://lore.kernel.org/all/20260720172923.E4F161F000E9@smtp.kernel.org/ > > Signed-off-by: Fuad Tabba > > Done here already https://lore.kernel.org/all/alczBmnItMwq8xj4@google.com/ sorry I meant here: https://lore.kernel.org/all/20260715105100.3178255-1-vdonnefort@google.com/ > > > --- > > arch/arm64/kvm/hyp_trace.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c > > index 2411b4c32932c..27367843fd211 100644 > > --- a/arch/arm64/kvm/hyp_trace.c > > +++ b/arch/arm64/kvm/hyp_trace.c > > @@ -116,6 +116,7 @@ static void hyp_trace_clock_enable(struct hyp_trace_clock *hyp_clock, bool enabl > > if (!enable) { > > cancel_delayed_work_sync(&hyp_clock->work); > > hyp_clock->running = false; > > + return; > > } > > > > ktime_get_snapshot_id(CLOCK_BOOTTIME, &snap); > > > > base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f > > -- > > 2.39.5 > >