From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 045DD126BF1 for ; Mon, 20 Jul 2026 19:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784574123; cv=none; b=pOmxKr/+nSk0L2tPCxFZf9WDSy1wpJpjPZNnJhbv4l7u7uiSNUJJOzD95xtGboIkd7HAxUAxsUQcnKilHaZQN2Z4PnN2SBeK1A037Ds3BCmugoWVZ0ahNPsnoFOzgthQ3jRZsgHiIxyzTmeFM75eWBbEN8942o098icKEyWmv/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784574123; c=relaxed/simple; bh=RoPMbpesKYBTM7BtVesJaXSKr9fkUeGuS8aFoUbVyeE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V/qYLyTXynaADxVzNDt8xx3MAr4GcBSF2dOCe3kI6YuRx7a0c3c4TO90zGmE/ekTmLtC9fIfw0NT21N2tP0Uyyj++hxKc1eh8DqMhIwTernMQ99tThZKBR3fWwmAJb5Q87dFVL0cHozf2xiNALGHD3yiZM3O2Kw+4RwWo5+0DfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=H/8xi3NT; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="H/8xi3NT" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso12768915e9.1 for ; Mon, 20 Jul 2026 12:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784574120; x=1785178920; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LhCePzwoaQC11f7PZvC4LXoD1/F7d5+3LH+i3bZkptQ=; b=H/8xi3NTyHaBg87GTx8+NJzciPx6PJNmiAW5EoM/yq0ycDSGgTXix91+0GawgmbdVY sRyxHK3bmvCDhc66sCF+KVk8KyX2FHytGkCKYre4aubYi8J7LGMpI6fVWk2PFnPmTJr8 hVxQa0iLpT1aq4b3MTkLEmpHycAtV9Y8oUsQyvbaRzKr7OmFsYcKeptwMDz0zhwDhJkU ihhZQIyPDCbqDNH5a6wMSfRoJm3NQNkrrNKaDj9FH2jgq1E0Xr1Vao/yq5HYg5ijYmap RJRYffqdpkYJ3yiD/vQo2Q7iUg9mdO7h6YwtmrcZiffoT2m5Qq8b9OKpg3K+sS/TRvnm MkQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784574120; x=1785178920; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LhCePzwoaQC11f7PZvC4LXoD1/F7d5+3LH+i3bZkptQ=; b=Pghtvb5O4pYGDB+cR7/nAJeCrg8sLBVhtnmzU1Nfkk8P9QseEinHJ7+EI+Delzihca F4QgU9a1a7PCuxJyAlLxnzN8BW+QgeWYO99N2u6t5QxLWjq4oi5RkWzOcPJlKRZIO7KF 3UBrlT8EaRfrpXOSrzMdZ+3+TQ8rmNWHzS6Et26Gbtq+TEc5NZeW0Pe/yU866QP2swZs rbPC1Zpe2EDPjiO9VO8mnJZ7QEKAojSZtsUNWaA9+y5sFKxPcS3Rkhzi/jLM0nI91R/i Dn4BHQCgTwQkZ0n6OM4xFShw8c80t3XNDX8vPocW4r0oo5xmbRaq5NvYZt8sjXAa5hXi OARQ== X-Forwarded-Encrypted: i=1; AHgh+Rq8DM0rlNiaP3srov4D3ALDuBSH4mRZaBNIsAehNLY9n5TxKoNkudi2FOrI0d8eEUPcoLwlvBQ1hEuzgRU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3ScUypYMPLEaZG9wIVN8GU5xq3K5U9meegO10sW3feWaKJVWK uXbQHVd5fbBCXTzMLTUK+vSvdI55npKmZmVGi7ckxhvbH4aOGUR3KVkrqVCM9M1Wnw== X-Gm-Gg: AfdE7cn3NNI2kiKopHASxJhcSgiPlZAj6vam3lILhmHaZpgRbICrwfCSwt1I7x13KZN dKDU3SexLszsdwMaND7ja20QozmIGESuT5kLRjTrRLB21QjJHQE4Sj8NAIAdIwBkJgY8TQMxxs3 DQIiupLVuAk8FvXmRVfhwh9q2oNW2vXJ7+bc0VGfNQJNhBA/J+zAJRC/SYc0UL/5THrPep1d0gt LtBqCYkG8AkgoqfXrD+lY5LB8MxkHH0UJTvfD0GLeDED7NkgsBL2QBB9h9sNcesDmKSYUEdXH6w JW1Z3C3cq1cu5K3UlPoijj4Jl/QVqJdip8/g67LPVan3yEOWDYtRfSMuv5xKPfRmvKCPpRpfZhi y54sZ4tI4y96iPkiiLXkO1Sh7XWlNW1CGSEGpJVBB6x/VLz7hfosJt0/GSCGEOYQ6ifO0UfOIsr vrFpBXNmxp9QhKRoVsERjNwvsEpRgY/SvgeAXUDWe1HkgKKFSUh0Q= X-Received: by 2002:a05:600c:3b10:b0:495:4aff:5fce with SMTP id 5b1f17b1804b1-4954aff609amr169923055e9.32.1784574119583; Mon, 20 Jul 2026 12:01:59 -0700 (PDT) Received: from google.com (137.69.77.34.bc.googleusercontent.com. [34.77.69.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63eeb360sm33723752f8f.34.2026.07.20.12.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:01:59 -0700 (PDT) Date: Mon, 20 Jul 2026 20:01:55 +0100 From: Vincent Donnefort To: Fuad Tabba Cc: maz@kernel.org, oupton@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, will@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, tabba@google.com Subject: Re: [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable Message-ID: References: <20260720184850.1826630-1-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260720184850.1826630-1-fuad.tabba@linux.dev> On Mon, Jul 20, 2026 at 07:48:50PM +0100, Fuad Tabba wrote: > When disabling, hyp_trace_clock_enable() cancels the clock work but then > falls through into the enable path, which re-schedules it and marks the > clock running again, so the worker never stops. Return once the work is > cancelled. > > Fixes: b22888917fa41 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp") > Reported-by: Sashiko > Closes: https://lore.kernel.org/all/20260720172923.E4F161F000E9@smtp.kernel.org/ > Signed-off-by: Fuad Tabba Done here already https://lore.kernel.org/all/alczBmnItMwq8xj4@google.com/ > --- > arch/arm64/kvm/hyp_trace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c > index 2411b4c32932c..27367843fd211 100644 > --- a/arch/arm64/kvm/hyp_trace.c > +++ b/arch/arm64/kvm/hyp_trace.c > @@ -116,6 +116,7 @@ static void hyp_trace_clock_enable(struct hyp_trace_clock *hyp_clock, bool enabl > if (!enable) { > cancel_delayed_work_sync(&hyp_clock->work); > hyp_clock->running = false; > + return; > } > > ktime_get_snapshot_id(CLOCK_BOOTTIME, &snap); > > base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f > -- > 2.39.5 >