From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21F343AB496 for ; Mon, 20 Jul 2026 20:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784578101; cv=none; b=lgE983gQ5pC+aj8wf+YAdBFp4eFikoydeyIqmM4KCYi5llTmFLD6qpV48jiQKDQIGI774Wglm4w+CpnIjnM4i/jHIV09ZGHmHdjq7n7YCPgUf9DN143WLqb3czlmkqBEmyunbv6cOdt5XHFfi66MGCQZd98s93g5DCi6LFa7Aew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784578101; c=relaxed/simple; bh=EYsXbupgT8p/3lXTHZn/wM30/+DPYmtje10OBPyG05M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ByXzEDmWWjenxLsff9096PcEYebv49itPNNtkKpz82r1q41oAjbNJAgsPVsZZTEXEtiiKuBUWRWHGWmTwSeHwpXGIn8p6kPFuRmyc/ABZ7gkDtBw/wKIYJ84i1D/03aDh4zc7oCTrLce/ZVv3v8WNTcNO7yMSTXVlMEHygSfQKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MCwmIF6T; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=F9joQ5GI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MCwmIF6T"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="F9joQ5GI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784578099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tJmWcK7VtygAI73hXpZCkgCwblOmQljwdFQvepVqOmU=; b=MCwmIF6TRwos4cIB4wR68p1HPBfNURBWj/n7qd2FiM7vggNxZcrEZbXpRwHXU7UHc8Pdpp PvQw6UVEpazVKIiF+tXzdSIM7jSL/uoAoeUoXtv0aL453cS0Sow0fap5/XisMxP/KOe9jE cZ1TTtWTaEttxRwsjFLiz1U7awfo+AA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-WNH8nyDwNg6BIDrZY6RneA-1; Mon, 20 Jul 2026 16:08:17 -0400 X-MC-Unique: WNH8nyDwNg6BIDrZY6RneA-1 X-Mimecast-MFC-AGG-ID: WNH8nyDwNg6BIDrZY6RneA_1784578097 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8ea75996387so109685016d6.1 for ; Mon, 20 Jul 2026 13:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784578097; x=1785182897; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tJmWcK7VtygAI73hXpZCkgCwblOmQljwdFQvepVqOmU=; b=F9joQ5GIWNC5Za28k3r1eervtdVDzuq4/mT1MOPAV6jYsdIZmAQ83Ej8KY7UQoPBZy aDdxaoESnfR25x9OwwunhZZKnWwX49WFQ0pajP3qagVS8Ks2XbYBPDhYGQDjOyEl4XTB CQWgNtUdSf6ig4QBNRDMs1SiJK6yEE8eaX7n9BjqvG8aIsBB1vZ6fN+xtIAaXOu0qdg/ dpB3dVLvcvojTTpSOOQ6RQbeoMyUoexMrH022PFb3uVIR48uzovJr0ffllcurV4nKzjh L/okXQIrrireT+mCzgeY6ep1O+aG9bwWHu0e0MqgGkeuDFfPZ+FIIdBIecGeC2rassbQ xtpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784578097; x=1785182897; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:content-type:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tJmWcK7VtygAI73hXpZCkgCwblOmQljwdFQvepVqOmU=; b=frsGbAIyVXpdtuC7qA2CZLGh8PkPSYwKx77zDtg6EDiiK8xsBlCH/7KtZOB2CXAtOj 6B1aQcpaWCj0Iag72ZiXbDfaoKFrnrRkRsYALJafCAfzbA8BNWOAt9GQBKSLwlF2Lt1K rRGhAE7eV69iYoCWqUmp6BZ6SPYbu9eUIcLKSFg9CE2bXOzZebbCNT09zlA2px595+MT E2UA3Nf40ahiVfpEzGT8FIafkjsQtpnjbwNz13j76/+7evcLdFhoBTM01zC0BMDVjau8 mkcdVxO5WWxFEcjFoFb1XI56ZpePZpULT7eZbMVjlDUoaGrp+gnxEv6PoF6TanRorxNT FjWQ== X-Forwarded-Encrypted: i=1; AHgh+RqTzX31wlRgW1FGgDYcWvqlSRpI70V+oLz8Y8OqSQv3LBCQLZqk41KnGGiz9SV/RlRoAvUj608CxIW+cGQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx86w/PQpb3CUTmMlFzcHly3AQX3zIU38nmq5goQWEZQzz0aYbA +0plggYcUHE4Cy/Zu0MpyHAt1er6xSIZ1T8a+S8cDVXT3+e1z/4vW9D+E9k4KOSjkdhmjgfIuH8 aygPxJ2/de32ZFO9aoSrg8FXVGGsZUrR4+ni2D9PN2OqCoe0bXrsC3X88AwokmXKF8Q== X-Gm-Gg: AfdE7cnaOUUQgXTCaaVdhj4TMK5sCHHf+ogJYF2WpUUu71Cejv2KE5TkmkZHtaXU4Hb VqV9/D7gw74J3/7a1EY9lhHG82ug3mI/INNpF259rQhpjtIlZBMBaAITGYwV//CXWla4fEtTJL4 sS3+Nf7UUQ2Q9ANa/dwaV8pVJinC4kTC/n1beEqbQUUjGO9Veiins+WtveZepVRx098CI9Q8Mi8 bvoMjSpba3qthAxMN4NIKGmQ8mPKqysO5RWYwU7yd6hD+Rlkd/grjGDOpY+lSWHUVbU1WVBknFN /wm2QbXRbSUfOL4HA250VdZe2FS4V96m8LGuf3n1sFzF7HIm679Nscm5qxa4VoRN21FmsvOal0p ptYlqP3MQmyKLjUWMq9aprFnslr5zOrWmHiI= X-Received: by 2002:a05:620a:2985:b0:915:94f7:55df with SMTP id af79cd13be357-930b3ed9e37mr1488515085a.20.1784578097383; Mon, 20 Jul 2026 13:08:17 -0700 (PDT) X-Received: by 2002:a05:620a:2985:b0:915:94f7:55df with SMTP id af79cd13be357-930b3ed9e37mr1488512285a.20.1784578096959; Mon, 20 Jul 2026 13:08:16 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id af79cd13be357-930b52e02desm954762485a.10.2026.07.20.13.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 13:08:15 -0700 (PDT) Date: Mon, 20 Jul 2026 16:08:12 -0400 From: Brian Masney To: Duje =?utf-8?Q?Mihanovi=C4=87?= Cc: linux-clk@vger.kernel.org, Rosen Penev , Michael Turquette , Stephen Boyd , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , open list , "moderated list:ARM/Marvell PXA1908 SOC support" , "open list:CLANG/LLVM BUILD SUPPORT:Keyword:b(?i:clang|llvm)b" Subject: Re: [PATCH] clk: mmp: allow COMPILE_TEST builds Message-ID: References: <20260719214349.734351-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.4.0 (2026-06-19) Hi Duje, On Mon, Jul 20, 2026 at 04:46:40PM +0200, Duje Mihanović wrote: > On Sunday, 19 July 2026 23:43:49 Central European Summer Time Rosen Penev > wrote: > > [...] > > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > > index 4b2c089f46a1..8383f9f1da51 100644 > > --- a/drivers/clk/Makefile > > +++ b/drivers/clk/Makefile > > @@ -130,7 +130,7 @@ obj-y += > mediatek/ > > obj-$(CONFIG_ARCH_MESON) += meson/ > > obj-y += microchip/ > > ifeq ($(CONFIG_COMMON_CLK), y) > > -obj-$(CONFIG_ARCH_MMP) += mmp/ > > +obj-$(CONFIG_COMMON_CLK_MMP) += mmp/ > > Could it be possible to select mmp unconditionally, like most of the other > subtrees are? AFAICT, that would also require creating new Kconfig symbols for > the PXA168, PXA910 and PXA1928 clocks, but I suspect it may be the more proper > choice in the long term. Just by sheer numbers, the CONFIG_COMMON_CLK_XXX approach is the most common use case right now. x1:~/src/linux/linux-next ((next-20260720) %)$ grep "CONFIG_COMMON_CLK" drivers/clk/Makefile | grep "+=" | wc -l 68 x1:~/src/linux/linux-next ((next-20260720) %)$ grep "obj-y" drivers/clk/Makefile | wc -l 25 I have no strong opinions about this either way other than to drive consistency across various drivers as much as possible. Currently the mmp directory currently only has COMMON_CLK_PXA1908 defined. When the other PXA* drivers are introduced, will there be a CONFIG_COMMON_CLK_MMA_COMMON that all of the drivers will use? If so, we could put that MMA_COMMON in the toplevel clk Makefile. If not, then yes I agree that obj-y will be fine. Brian