From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lgeamrelo13.lge.com (lgeamrelo13.lge.com [156.147.23.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C39C5312836 for ; Tue, 21 Jul 2026 04:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.147.23.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606897; cv=none; b=g+ypk3V/6QyWmI5CYW67FaLuQo+ePrnETvcLvvjacYASHYZwz2xhe6ibwSuiyIfj5S0ckuIBFNtqYwGlsH+ZCeNIqaKdUv3FOnDIRbMu296A2tnkVAeqFpGVWBpJueK5ODfAY+n+Xmx5av52jGuyw+QxQUWdsftV3/gnryeFgkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606897; c=relaxed/simple; bh=1byFVw1KKTM3PrVt/GgFW4DaFgbyeQlfNthSji9Kcmw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g/vI79hjUIl+/jVzOTycqEGFJBrEtPkOYhm7+hzZVS2GBqpbdf4pk7p9uMULHK4ZoOhjEnli8phc0mClD5sSxlf4uudQq/kTS9ckdaHQ1mtBXZiCjlaTP1eomnGltVKTzBK1UW6ONMVqSIIhfEm2L5dLh1ZgrwfWf92V6XKkhbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com; spf=pass smtp.mailfrom=lge.com; arc=none smtp.client-ip=156.147.23.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lge.com Received: from unknown (HELO lgeamrelo04.lge.com) (156.147.1.127) by 156.147.23.53 with ESMTP; 21 Jul 2026 13:07:58 +0900 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: youngjun.park@lge.com Received: from unknown (HELO yjaykim-PowerEdge-T330) (10.177.112.156) by 156.147.1.127 with ESMTP; 21 Jul 2026 13:07:58 +0900 X-Original-SENDERIP: 10.177.112.156 X-Original-MAILFROM: youngjun.park@lge.com Date: Tue, 21 Jul 2026 13:07:58 +0900 From: Youngjun Park To: Kemeng Shi Cc: chrisl@kernel.org, kasong@tencent.com, nphamcs@gmail.com, baoquan.he@linux.dev, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] mm, swap: return early from swap_extend_table_try_free() on first non-zero entry Message-ID: References: <20260720071342.50742-1-shikemeng@huaweicloud.com> <20260720071342.50742-4-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260720071342.50742-4-shikemeng@huaweicloud.com> On Mon, Jul 20, 2026 at 03:13:41PM +0800, Kemeng Shi wrote: > Return immediately when the first non-zero swap count is found as > any non-zero swap count prevents freeing extend_table and further > iteration is pointless. > > Signed-off-by: Kemeng Shi > --- > mm/swapfile.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 81c4040912be..3fcbd10c6353 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1530,20 +1530,17 @@ int swap_retry_table_alloc(swp_entry_t entry, gfp_t gfp) > static void swap_extend_table_try_free(struct swap_cluster_info *ci) > { > unsigned long i; > - bool can_free = true; > > if (!ci->extend_table) > return; > > for (i = 0; i < SWAPFILE_CLUSTER; i++) { > if (ci->extend_table[i]) > - can_free = false; > + return; > } > > - if (can_free) { > - kfree(ci->extend_table); > - ci->extend_table = NULL; > - } > + kfree(ci->extend_table); > + ci->extend_table = NULL; > } > > /* Decrease the swap count of one slot, without freeing it */ > -- > 2.36.1 > LGTM :) Thanks Reviewed-by: Youngjun Park Youngjun