From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7156C3914E4 for ; Fri, 10 Jul 2026 10:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678571; cv=none; b=aIB25nzWSesdw4A7d+OjQs5hLcu4Kvqu1f3d47nw9EbwegcOViEz8cmFRTGbhsjCFpoa7diyjk20/hdWnne+WZs8niMsJ8K+fjP69unxksJ3S7YxOZXCizoMW5sStQ+GmNhZmH7rdlCijbaRUH5Wbr2ciwTWmnOxHeAG79zw/w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678571; c=relaxed/simple; bh=NdS1SoYEHzFcC71PEE1dQpzia22T95oYq/JfF/B5Jo8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ruh8lWoIWqK+4/OJzmdIJEK+BJ7TJ92qy+pvI+EVTcjkXzIlz8DS8/3iykEQ3S7yltDXp9wP4WT11/GrXaqoLJq2D7PK8JKaqwtp/SpKp5Scj9SMYeiwPK8JQTeOIbxanmSXbIfcvPcVnsbzoO5yZcjj6AIM75dquKJvBYJLYt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dhOkQcHx; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dhOkQcHx" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493d92b7db3so6939335e9.2 for ; Fri, 10 Jul 2026 03:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783678567; x=1784283367; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1vIQWYleDgGJPSPgzFWyTV1QrDZqaDu8yW8UkA/woeQ=; b=dhOkQcHxGZ396MMQ6oIxz5zx5VpvJZq8z7uXZ0wUCryi/zbcE5Nbjj4QAjfc4Z4X8y 0ZKe+jD31FupS2G4vivief94gg+b4luJVhbTSVMU7yeZ1KeRSMAxoKFkR1GasQ22lhxw xHAmJ5lgrvWCfmkzF8x5Vj7HfItm45GR6G3QXFtlK4nkHIzlX7p6z19W+CM+hsfn/hRJ 4Mq9pnHBuP7FHhm2hOcpcsg2v8X4wIPpzE3BriwmDeIZ0ADWrxUYI68pQ7CuYVhhhGeg 5qg+1fgkx5CdQRRLzYVpGwm4KDqkmYpLOEu43eyQZ4IfIZdho85wj5SUI4Rd8JVfki7w 1N4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783678567; x=1784283367; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1vIQWYleDgGJPSPgzFWyTV1QrDZqaDu8yW8UkA/woeQ=; b=YPUwTcm9qkDTx1K+jBalUZHSLwcJ1d88y39lVi20p99fRrm6gIFa7xbgfdX4Z07bm5 k36xG4RQ4D65kQrS0/di172eRW/oxgdPQCf9EqPY1RP22YD1RkLF0sxAvc6G0uppfrYe iT6iFsqvOk7GuLiuNmPMg7CzqJZ+kz3RKMTqPvfLzhZiXvfSKYwByBtHpdfcsYfOqp/G S/sq3H/Pq6aNweSM+vuzNx9i7cm39K1UUGvDhvSBlJ2uHjVLWH/2tHiGdpENHEvr0mFS uMbCZORhtN9a11PFC89enClwtsgXyq57T4ZnTb9JL3Sc5kTElwv+qqUYUPn1tE5lziuP saZg== X-Forwarded-Encrypted: i=1; AHgh+Rp4ER96NRXkG6PUwHnktxD2vwg3rpnUQJCyEJU9JtflNUsuR0jdzcZ+nWFyxsVhYbQpm3YuzvLeCaUfncA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9O/fx766H2x8MVuoIJZAbX76YhxPrUf0DIFL+gf9O8oXzTuXz ol4W1IgsP4lzNic3Ich+zhYJHJOdhJUq9+9/ACgcxwF50coKp6vJ12yU X-Gm-Gg: AfdE7cncRxf0L3auJ/zu1FVpBfe7JYKqlQgZCuyLSTPthAtiVsu/JtKXPT7vCrmjmof uet0D5oACfo5ne17oha56971qKU8DYh1r1HV806QdvcujEjV0VJmq3rEbRqtpayuz3GITtYzHFL arz60RYg7OTFfUigw2mrgOtlHWcys7H/pZbtTj/nnX+ZyDGhaAENFyumrIj8yBUkhQQ8dVGbUuD O52DjlrIdNr/mYfpuMDRw7f1t7uNB0S9ju7QavVMR2mbfr5fIwynffdOOthpXpyleyrO3QtgT9L lwF+0pfM8zybGmO7/wQ1ovVda3x+QC2EwKVZ7WEO3zLM0AM0+BlxygLMvjRAb5ROXdXk9jBhwWI IfAZFyYPWEAadTewpzBMZ0IZWdmGgU/c8gDlqLJysL+3bUyxe6mo4lOOmmD34smrMBb41085UDV /3PqResg== X-Received: by 2002:a05:600c:828c:b0:493:bed9:b53d with SMTP id 5b1f17b1804b1-493e68ee07cmr95829375e9.31.1783678567070; Fri, 10 Jul 2026 03:16:07 -0700 (PDT) Received: from curiosity ([80.211.22.60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f49755f9sm34621525e9.8.2026.07.10.03.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 03:16:06 -0700 (PDT) Date: Fri, 10 Jul 2026 13:16:02 +0300 From: Sergey Matyukevich To: Wang Yan Cc: shuah@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, andybnac@gmail.com, andrew.jones@oss.qualcomm.com, thecharlesjenkins@gmail.com, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/riscv: ptrace: Fix memory leak of regset_data in vector tests Message-ID: References: <20260710083437.489648-1-wangyan01@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710083437.489648-1-wangyan01@kylinos.cn> > The regset_data buffer allocated with calloc() in the parent process > of several vector ptrace tests is never freed before returning, > causing memory leaks in: > > - ptrace_v_not_enabled > - ptrace_v_early_debug > - ptrace_v_syscall_clobbering > - v_csr_invalid/ptrace_v_invalid_values > - v_csr_valid/ptrace_v_valid_values > > Add free(regset_data) before kill(pid, SIGKILL) to release the > allocated buffer. > > Signed-off-by: Wang Yan > --- > .../testing/selftests/riscv/vector/validate_v_ptrace.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/riscv/vector/validate_v_ptrace.c b/tools/testing/selftests/riscv/vector/validate_v_ptrace.c > index b038e2175c80..a388b7963d47 100644 > --- a/tools/testing/selftests/riscv/vector/validate_v_ptrace.c > +++ b/tools/testing/selftests/riscv/vector/validate_v_ptrace.c > @@ -75,7 +75,7 @@ TEST(ptrace_v_not_enabled) > ASSERT_EQ(-1, ret); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -207,7 +207,7 @@ TEST(ptrace_v_early_debug) > EXPECT_EQ(vl_csr, regset_data->vl); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -331,7 +331,7 @@ TEST(ptrace_v_syscall_clobbering) > EXPECT_EQ(0UL, regset_data->vl); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -649,7 +649,7 @@ TEST_F(v_csr_invalid, ptrace_v_invalid_values) > ASSERT_EQ(ret, -1); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -911,7 +911,7 @@ TEST_F(v_csr_valid, ptrace_v_valid_values) > EXPECT_EQ(regset_data->vlenb, vlenb); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } Thanks ! Reviewed-by: Sergey Matyukevich Regards, Sergey