From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AB8834CFCF for ; Fri, 10 Jul 2026 14:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783693485; cv=none; b=ry0nGHkFts1ubVMVULOxWV06b85/Uek83dxMxBKd3T6ECP6T3dBahGaVn9Chrc3+1rFW9zNN8qRfm5YlBLgESAKgRoWEys5KfCB4pSFcc7jBP56VkRbfbMGScdM1PLEZ8LaA0Ob6T/+4G1wCORJWRreoLcKxM2vfwYHY50zMbGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783693485; c=relaxed/simple; bh=AXMaR+0eDh9oIqmXxlTjc1LKyWnAwaa8OTPl46+QRX0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ngGEoN28nm/rK1toosBjByr71VOQHDAbfmFWLph6jeaNEWwfDwm0Ts/JRK0Emncf1ZYbJyar2gN2bYCJ+alQeYfF8KRjItU0EpyspWvTTMEdwCS8YsqahSEkMkj0mUr16+YfBiZLTOtcJEsvw8/MKCQfijT/kZhVWX+qzdToOac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ah5N8r6w; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ah5N8r6w" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493f6de72faso2421095e9.0 for ; Fri, 10 Jul 2026 07:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783693483; x=1784298283; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gdDxVJG3g3cF+//c3YLjvRJpMQRofYl0dq+wVTYwMio=; b=ah5N8r6wdca9FM4fPyc4eVmdjj9GATJqqZqsk43GlOtBOWZq0N4oSpp0UDfYUOJ8du I0omzGS0IPK29oqsjb+gb3sZms+zcer613ji81Ll4XoE1rB9PnzPC/f1js/cP5enpfnH u0wcGh6F2Yo8ot/xKVn1y+yJZ1YtuGngVeoMdlhBye1Tjl4qk5DDoEoXMAn8i32I4/3W COBsXJneIeHeK7YO+3OTc3xuwxyq2GukOwBPjrULxJcHwLOkvylWdOZpVRZTTHre3MqV /AdWbT5jVfhs8bJRDNdHeOxYhkUClBx8r3q9ebgh8VW88P2oTs4EupDE1D7aicv+7dNt eDfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783693483; x=1784298283; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gdDxVJG3g3cF+//c3YLjvRJpMQRofYl0dq+wVTYwMio=; b=CYcn84N/OsWyUrYTi3N1tVA5ElX1WZt4lUfciPptzwU12h1K08mAAvdsQhkQptKSTU dodxatD4MoJDcEqR6MgN1jAEjOexsaf4czXwjnv16m9yyTgicR5curEFYOvWVKesmaMD t+5h2dX8Z7BqO46XzWBmvs4V0ssZkiLJ+krAY34nJxdjCVLAZfTxn+KtzA1hYo5Ba5ww +TY7MM9KetwwHoJ3PoQhaQEwD9cOu/p8KNVWvO0Bi5/Xy7vSr+sEDdBBo7SnomETbAqP wtkTpwH5xxVFjz8DNf+LwTQ15hG0cy5Ow5hA/bYwLW2OLZvKdCJtBM/b/OQr5GZKavja p4GQ== X-Forwarded-Encrypted: i=1; AHgh+Rr7aW3Wr81QFE9jkP3s7qXjsReKlpEZP3/cVOZI3no2E17s72C7VpIyWLeteGpKtg7+3y5aHz9HzyIsoM8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+hAzzwpofvk7Yphk0ccdBvJ6Zl+UXYQHgEzVUqJ2kH8pp7gU4 gxxu7B5RwdYVl9P8+RQvfpa/Ly3hVcdtKPOCW7GGSuswhxIzuESokqmlJ8jVE6yxYA== X-Gm-Gg: AfdE7cmpjQzKcPJ4JTckG7dS6hwEZNaliFRbNjDg4E38spjzHAZUQISBZAe1nlEG7Sv x2Oc53xrh4HUgY07hLt4W1Pp+rk2VwW8hOrm25LOqEfERGlHKZnPaSRIrkjjwRDkDgNy5wJ6V5q GPTe0fjAItI/dqj5hArx1jr2GKiJ8RUb+CKl/xEtEfWwOpArGMsL8FUT4qYjEInBuo8z2TqSwR/ si1bOH0w3f1oLC8LNoiYFOWaeBjw4v8B1gGkogzil0nyYNU+C++RrigsRswzuNnH4bbyX8z8CAN wZThwrkXe/Q5fQuVZgry5+hwWnnhPsSlEQSRY2pntxR93eWY400umqr7qK6E/MblirlA5xphgMs FH6iYwtKmwrmrlUASza59+vz8yJgS7KC7W/lBjP2DxVdo7rg2msMQu0y0PRoRr5X/oag3nUpO9Q ClzFULYa8LkDEprJUvfyqUjSAIlUJqphG4Nx7RN3X6+N9CKebK1Og= X-Received: by 2002:a05:600d:6401:10b0:493:d117:18a8 with SMTP id 5b1f17b1804b1-493f2b3376emr29088265e9.9.1783693482178; Fri, 10 Jul 2026 07:24:42 -0700 (PDT) Received: from google.com (137.69.77.34.bc.googleusercontent.com. [34.77.69.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2dad65fsm41770845e9.1.2026.07.10.07.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 07:24:41 -0700 (PDT) Date: Fri, 10 Jul 2026 15:24:36 +0100 From: Vincent Donnefort To: Mostafa Saleh Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, jgg@ziepe.ca, mark.rutland@arm.com, qperret@google.com, tabba@google.com, sebastianene@google.com, keirf@google.com Subject: Re: [PATCH v6 01/25] KVM: arm64: Generalize trace clock Message-ID: References: <20260501111928.259252-1-smostafa@google.com> <20260501111928.259252-2-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [...] > > diff --git a/arch/arm64/kvm/hyp/nvhe/trace.c b/arch/arm64/kvm/hyp/nvhe/trace.c > > index a6ca27b18e15..e30de840e6c2 100644 > > --- a/arch/arm64/kvm/hyp/nvhe/trace.c > > +++ b/arch/arm64/kvm/hyp/nvhe/trace.c > > @@ -35,7 +35,7 @@ static bool hyp_trace_buffer_loaded(struct hyp_trace_buffer *trace_buffer) > > void *tracing_reserve_entry(unsigned long length) > > { > > return simple_ring_buffer_reserve(this_cpu_ptr(trace_buffer.simple_rbs), length, > > - trace_clock()); > > + hyp_clock_ns()); > > } > > > > void tracing_commit_entry(void) > > @@ -285,7 +285,7 @@ void __tracing_update_clock(u32 mult, u32 shift, u64 epoch_ns, u64 epoch_cyc) > > } > > > > /* ...we can now override the old one and swap. */ > > - trace_clock_update(mult, shift, epoch_ns, epoch_cyc); > > + hyp_clock_update(mult, shift, epoch_ns, epoch_cyc); And also in any case we have two behaviours: one when tracing is running (sync'ed hyp_clock) and one when it is not (floating hyp_clock) So we might well do floating all the time. > > } > > > > int __tracing_reset(unsigned int cpu) > > -- > > 2.54.0.545.g6539524ca2-goog > >