From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C8336C0AB for ; Fri, 10 Jul 2026 16:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783702462; cv=none; b=IZIcCou4/cmr2WO7JfkAPBUkrWhth4KYYZ1A9k9L+pw5cvkQkzj491BFrSuFtuG34oaQiU+/J2gPQ2r1QTRB+G3yGCHMI6+WP61i3j/N/onCCTXTJZ9FjSk8rVvETKk7x6Lyhx7+7AKlTLOpPGv/b8ZDQwhobA6lXVejvCazVcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783702462; c=relaxed/simple; bh=jI/OcbOYVD0sHS6G3h2jYDflQSErX9zgXGnhGKq7Zn0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qSPbcWJ4xTKL3VQRFdCIPtk+oKWMQsyLrZO+zx2F2Juhz2yVwlpBikGYR2DebaePpR0p/grICglXBwR53+TXA7HCMUiHBppF517dbmf3YJvYYhp7jnXHz051xqLDf2QrZclzp8a0DxMHBbMYumUOGg1uCmMbS9wKcMRyalYi9Go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ey3x5DzQ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ey3x5DzQ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493e8d4f4dcso9954255e9.0 for ; Fri, 10 Jul 2026 09:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783702460; x=1784307260; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JRW82qDeqWbcTEIWdeHg6T9X6r+SnQDhkFtAVKzYK4Y=; b=ey3x5DzQoMAP/6c27gmQ1wkyDCgtjiqzHZLu0mevQjsJpQrkvPykdwmLY4dvdP7nIl 3lPVRsA50KXSIqWWE88kyRSE1HPiRbnRR+HI48IYhNtaUP78DsohZ9HIkSffG7WwRs+/ tnffgYrYFfIBS7xPlXZP93EFSE+30Sp9m1QuF/aCGCiGZh/TQzx7RY0ZLnF5NsbCr2sc 4ZFPv9AZBWVmYIi1yD1ZY5np61yVTHQtv6Ey7pD7jSqP8WvvDs9hW9nSn9C9k+iuDdq9 vt1vNg7CQ7mNv3jXJCmzewlYNu3/m0P3LTQbBep5XRUPsfTgaiMtuMnDHXopwsPc9mFK fPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783702460; x=1784307260; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JRW82qDeqWbcTEIWdeHg6T9X6r+SnQDhkFtAVKzYK4Y=; b=m5GE62rw6nPWODbZ0q6NaDR5RzaBtea7m+qQgIlWZgfWRNpLHHaHJzH6XL+M1gluF6 uD175kFJvMnrzaOKq/E7m6DaI/Kw6FW0qCRJS61yowGOxUuuwvayZGASaaZkq/QhflRy Gz1Thbgy8HKUcnlA5YVXldDawsmJIYB74Om3pMc3WghUs1A4tXzhJVd//vqJn2gSQZkl bUSUYYUwPvHzDxrEyd7BwdveVadyRo8a6p5FDidrWSrJuIzJEQZslWFNMhHuLJ4GBEgo X0IW1t50OOdzb/IYgwi5sFkBqctxC97TjbyFbj/9NLTnyzYyWjBcVUdwo/Wgc1pH3rB3 YzFA== X-Forwarded-Encrypted: i=1; AHgh+Rqi7UeRf1jSO0yIX8osKlBELCB5QIyDnuiBAywSYxXR2HRFEW/wEVLdREiXAqzAgVQmEM4Kr72S/JJ6RLQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwH3vPIlm64ijCQ3DWqssxiAJalHQgKMyPyuikGNzzlZvKoJIHW puPGnPREuNBBRq3Ap/AT5NWn9lFXSBCGZkoXrf7mkmPAUW1+xr69+YVc X-Gm-Gg: AfdE7cnz/eycwgljgOMLZLTboWdAbhUFZO6uZsQBmsUIDnMENAQKEjNPfzlnqu4oZ5L n/y3JT8aayI8N8PkSYz43WAgGeLJ6RPNVDpBWkpCZuUyWLP1G8TqGnroK8lpVStm+xLGIKNiArN 9pYWjEXuS4+Bxe3u7u6FNglk8cPSkxNHQIKjjmxX/NSniDEhxjIuzlYEG19TAjr2Du8leJZ08lu +hc1NHxPPuPbvzIAqPavdmY/cfUkqJzvDbxdKwoKPgiHK1AwSxyvMGNpkaZwFMzvKCtOdvJfjAd qVIOrnBQp3q5QOpfTopgmmQuGXjv213ZepTHldeNDQVXao1NCLus8utBf/sTOtPUHxgHIT1ngPA jnByRmDL6AGRvD7DafDNglp32/e8goA1DL7vRVDdQ+2i5BCysI8sXJXEUdzxUEhNmT7gEbE2wmg hFRBobETd8 X-Received: by 2002:a05:600c:1d16:b0:493:f73d:cc6d with SMTP id 5b1f17b1804b1-493f73dccd1mr17291625e9.24.1783702459655; Fri, 10 Jul 2026 09:54:19 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2e6607fsm54696025e9.1.2026.07.10.09.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 09:54:18 -0700 (PDT) Date: Fri, 10 Jul 2026 19:54:15 +0300 From: Dan Carpenter To: Taha Narimani Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: iio: adc: ad7816: Use devm_gpiod_get_optional() for busy GPIO Message-ID: References: <20260710160001.29856-1-tahanarimani3443@gmail.com> <20260710160001.29856-2-tahanarimani3443@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710160001.29856-2-tahanarimani3443@gmail.com> On Fri, Jul 10, 2026 at 04:00:01PM +0000, Taha Narimani wrote: > /* > * struct ad7816_chip_info - chip specific information > @@ -48,7 +48,7 @@ struct ad7816_chip_info { > struct gpio_desc *convert_pin; > struct gpio_desc *busy_pin; > u8 oti_data[AD7816_CS_MAX + 1]; > - u8 channel_id; /* 0 always be temperature */ > + u8 channel_id; /* 0 always be temperature */ What changed here?? > u8 mode; > }; > > @@ -84,10 +84,8 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data) > gpiod_set_value(chip->convert_pin, 1); > } > > -if (chip->id == ID_AD7816 || chip->id == ID_AD7817) { > - while (gpiod_get_value(chip->busy_pin)) > - cpu_relax(); This patch doesn't apply. Not sure what went wrong but maybe it's related to this? > - } > + while (gpiod_get_value(chip->busy_pin)) > + cpu_relax(); > > gpiod_set_value(chip->rdwr_pin, 0); > gpiod_set_value(chip->rdwr_pin, 1); regards, dan carpenter