From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318932264C0; Sat, 11 Jul 2026 06:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783751600; cv=none; b=MGEn2XOdUtZGEZv/EI5qpqFiZEcubQuRy15IpafqOc/34qXanRYWgVTR0AQXtiPxwCcdImBfFpsEBDb9guDxj8U4lN7N3xUDFk1hIwRiE7FwNRD0RELwOuzku8S7fD2MW01e8ZXgiUD8yKjJxuUKROOEdjD/vKdctymyJI022Oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783751600; c=relaxed/simple; bh=IhuKekt2PQXuM2aC1ZwPWPJ0ZHIWcPpVLch8ZcQ+oPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f9xD4M61lWQACoZT2MCw2gsU838xsqH7WukoO8YINH9E9ld6h/sBYYKp6pG6XzNDIBqHjfyx4d+DVjRpNlTIPRcEw+zQsRi4k5u0ZBfQUahoFf4zg8k74qlPYkTNO8VXns6sYnWvUgwGcJjhAow8ICHaOKyNP9eOI+4hNcO6XEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EPG2DeF4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EPG2DeF4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D80AA1F000E9; Sat, 11 Jul 2026 06:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783751598; bh=IhuKekt2PQXuM2aC1ZwPWPJ0ZHIWcPpVLch8ZcQ+oPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EPG2DeF4UTCSaR61iBwMXCgHQEn643ddtwajqsHEeGX2acXFY9ki43vFQ7gy8Bl0W BuXOW3LXg2kAEBfh13Hs0ZYMFR91r8JsrHpYYyQ3iVnNER02xUYKPYy+XAphOKNsC9 WxQoVUhR1TUlCSyiEB/VspCyJtQW/GzjedFjyCgZJPJ6Q/gQG6rVW2boHGQqSDe7fZ b4ZROnX7C4o1b1i8MbQJXaxv8hBq+sorHlvvkjlhjEhEf1cNal0kos9Dmx4MMB3uPX +caq0W8QPJajr44BSXmfelnlwPZUxmrKpz84RfDbyY5pbBa8+xpkhUS3UCT0amuC6h 49Cf5nI8dBADw== Date: Sat, 11 Jul 2026 07:32:51 +0100 From: Lorenzo Stoakes To: Gregory Price Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Jann Horn , Lance Yang , Pedro Falcato , Russell King , Dinh Nguyen , Simon Schuster , "James E.J. Bottomley" , Helge Deller , Alexander Viro , Christian Brauner , Jan Kara , Dan Williams , Matthew Wilcox , Muchun Song , Oscar Salvador , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Miaohe Lin , Naoya Horiguchi , Xu Xin , Chengming Zhou , SJ Park , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Hugh Dickins , Peter Xu , Kees Cook , Marek Szyprowski , Robin Murphy , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Steven Rostedt , Mathieu Desnoyers , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Huang Rui , Matthew Auld , Jason Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Ankit Agrawal , Alex Williamson , Paolo Bonzini , Shakeel Butt , Usama Arif , linux-mm@kvack.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, Russell King Subject: Re: [PATCH v2 33/33] tools/testing/vma: output compared expression on ASSERT_[EQ, NE]() Message-ID: References: <20260710-b4-pre-scalable-cow-v2-0-2a5aa403d977@kernel.org> <20260710-b4-pre-scalable-cow-v2-33-2a5aa403d977@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jul 10, 2026 at 05:09:54PM -0400, Gregory Price wrote: > On Fri, Jul 10, 2026 at 09:17:14PM +0100, Lorenzo Stoakes wrote: > > Update the macros to output the compared values at hex for easier debugging > > when test asserts fail. > > > > We have to be careful not to re-evaluate expressions as they may have > > side-effects. So update the code to take local copies and use these for > > both the test and the debug output. > > Aw you found it before i reported it :] Claude did :) I take no credit for it :P I guess I thought the re-eval wouldn't be an issue but obviously when it's a side-effect and the userland tests do do that, it's very important you DON'T re-evaluate :P Human 'meh that'll probably be fine-ish' vs. robot/Gregory laser-focused vision doing the whole 'Sorry Dave I'm afraid I can't do that' ;) > > > > > Also remove unused IS_SET() macro. > > > > Signed-off-by: Lorenzo Stoakes > > > Reviewed-by: Gregory Price > Cheers, Lorenzo