From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EB672EBDE9 for ; Sat, 11 Jul 2026 09:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783761403; cv=none; b=qWQ45hA3CUUYDpGOT5UJC8ppRCgbkpUjnoTxfQs9zixtJ7deLadB8qhXc7dzD2/5zg2hogb+X89+PboFyvwz5NgIuNUI2zG4tok0Va5KndQd3Nsg1bHWsX6K+JLTQkhTPMMnOwZhn+2WFP/LZljLBaPDR87AhHUHEezIu1UjGag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783761403; c=relaxed/simple; bh=uaK4E2NN338KW60VTHBVG2Nge1niyLZtTyuoJn6LktE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GvtI3WfPaVS/OIntSLv81aOaXaMGjhAAcHEHjkrCxvKOrvK4oC86FCpiK7uIPIId3tNfFqf7Ss0UqoSdd5qLxoxJBC+m7eEdoJKfhk2A3Z0ayP51SPSleQHqG5YQGcLxQmISmYWm2fS9rqrF4DDHaPJ77hQd1NqMseb9zturxLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ku/GG7aM; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ku/GG7aM" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4938d5f86f3so12300905e9.1 for ; Sat, 11 Jul 2026 02:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783761400; x=1784366200; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gsR0+1V67dKoDon9Zt9yFSPL0W+9/ofIZEZlGwU2kRs=; b=ku/GG7aM35wGiuxNHga4yE7PZFD1mx/hF0rcqMPmvxuhgciIx+26zEVmA4/5P0G0nj 2qCaYIgurttvgr/wzQCo1DNvKXmMu7RAC4XWbRMjD9LEpC3hgLw3clvm+v8oLCd+qNEf L/wqbrLcgKwmJLl2FxrFx3vOA1SbFq8t0eqTog8JwNcVskU1oXrxKNbJxIes6JR9BasL s00fRa6uYVIyhI7m1QOCSHy+NNxT1sGF/osyKAaB9ZaokF+2OQ+ReExPyyJsvB+6gh5s uGt2IHUWCTCK+/ayU3sPgwZLruFO1Vxfx4jFiLjtbCIbULqU2aTWInZql+m+IFM7OqJa wClw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783761400; x=1784366200; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gsR0+1V67dKoDon9Zt9yFSPL0W+9/ofIZEZlGwU2kRs=; b=ROqhddoW7fo4cLI3i396b2/xgsinunYS+q4kaEqZ2b01MHidSqydAq2prtoWp0Agzv 5eI4VEYeu6jwBFKpNWks7kvedccEN64cmCWFPTwZtKX++DH94lDR1i5zP+60/cHW0BuG RWzvGHwaH+GZ6a7wCmWtGT249G2kkYHRuiLWNUZTFrajvubFxYuXhiEASWulq52pWwOM xcJH3GGuJdHa4VYOaprcvzK4R/0c71ATfew3Dzlak3CAz5STrA/qJe5ZSxVzzMuZxxXl D1EGEjFIRPLTYcWnethdUi5NvyQqPykJsEqKisafGk5bnYNRd4Nqq8IxNrtVb3LrcyiC I+hA== X-Forwarded-Encrypted: i=1; AHgh+RrXV/RFgMcHLjx6pjWIQVGrsugVrptyJ8PU69UJZScPaWTCwX7NCAQokAAjToQq6oCJhSYCGtQukQ0sJik=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/QyH2F0pCwkVQdNFM0mP/GFuNxN0BVYKVND+RqegMOCg2cvHB FgzUSV1SD3eqJanO7VDdU/y/i1xHAKkLM7CLV/Fvs/OYxhtYs7pSO6dg X-Gm-Gg: AfdE7ckGLxyCIgNoz2NL0aFtky9o3KzzrL6Z4v3OF6zSZuVvHBNDPaGIIEoZ0DRowKw Iji9ESwX6mu/Zr4npLYodUm65hoPDnBqrYUDMNy58WoXog86R9/Cd9sfT8IoCOXiNLr0ocscipb BYoaarao2sYCjRoOQhyw/dVNYKyW/LDSMB/fN3C/zfWKhpFW5JsJ5AxGYt09fxTMd39nRT+vaa4 7J7JHiLJv7XvhvHBgav2sKO7wdRj358KB3mo7B+oyz7ahNe0kgGc2mxTr16YH4Ms8zNYhZGm77K RQRb8y3a4jFe1LYx0pCXkx/A4jlRQTZ5IhXP0ktTq2aJ8d7sH94d+WyQG5XOSxNg7iHp58cYPfb hLw4DKG1jJosmfwo07CjXQEwFld4pGe8ayLVcuT9CGCkmVzEuKD+r1SKMsTYndf3UMkOFSZ//l0 S2BuzDgp7L X-Received: by 2002:a05:600c:3492:b0:492:714d:8c4 with SMTP id 5b1f17b1804b1-493fb0450bfmr9365165e9.11.1783761399743; Sat, 11 Jul 2026 02:16:39 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb670a41sm193656215e9.0.2026.07.11.02.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 02:16:39 -0700 (PDT) Date: Sat, 11 Jul 2026 12:16:35 +0300 From: Dan Carpenter To: erqeons Cc: gregkh@linuxfoundation.org, hansg@kernel.org, andy@kernel.org, mchehab@kernel.org, sakari.ailus@intel.com, linux-staging@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: atomisp: fix indentation and remove dead return Message-ID: References: <20260711081657.37117-1-erqeon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260711081657.37117-1-erqeon@gmail.com> On Sat, Jul 11, 2026 at 12:16:57PM +0400, erqeons wrote: > Fix style issues reported by checkpatch.pl: > - Remove unnecessary return statement in void function. > - Convert spaces to tabs for function arguments indentation. Split this into two patches. > > Signed-off-by: erqeons Real name, please. > --- > drivers/staging/media/atomisp/pci/atomisp_cmd.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > index 6cd500d9f..fb1ae146b 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > @@ -1419,7 +1419,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd, > > err: > atomisp_css_free_stat_buffers(asd); > - return; > } > > static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd, > @@ -1885,8 +1884,8 @@ int atomisp_calculate_real_zoom_region(struct atomisp_sub_device *asd, > * Function to check the zoom region whether is effective > */ > static bool atomisp_check_zoom_region( > - struct atomisp_sub_device *asd, > - struct ia_css_dz_config *dz_config) > + struct atomisp_sub_device *asd, > + struct ia_css_dz_config *dz_config) Normally we would align it like this: static bool atomisp_check_zoom_region(struct atomisp_sub_device *asd, struct ia_css_dz_config *dz_config) { regards, dan carpenter