From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2B6925393E; Sat, 11 Jul 2026 17:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783791473; cv=none; b=klFc+yWEZ17y0zVKUZI2TbAICHWpKbmtibcpt+rS7mpFeDEfO7RXGYxDlV8E1hR3hW/HFLZ+mt58/4FgE8DNgtSKM4hLnTGjKy1LdeiLxoTXD7Ajc2mqzoUOYYl3WRfss4dBLRPY9iCTV3IxpFJtiCFq5aMeDbqsSdnBRjLH6rI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783791473; c=relaxed/simple; bh=n0/EUOoOHqSAXfrX07L+kInmiHfaohwVQqSJk2mMY5E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ghvgCdtJG0xYLYMJ5oR5UTXlc6CL8YIhG+rmIcpCxNbp4gkJr7LTNrm2bSw/pByrmXMYPM7oPuJCT1qzMBIIR9k6+VWoD1ZeT7HJrI9F0Pm55W3DHufBojckJn8C2WRVQDC2wshPTx8rHhdenWT6aVZ6v2eNuBWLuaQa5Uep9C0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UYmDMp2b; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UYmDMp2b" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id E88E41F000E9; Sat, 11 Jul 2026 17:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783791471; bh=imctzIE4E9ZAuGXTf6dnldu/7y/pOSeNFQ9iOKnUE1k=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=UYmDMp2bpN8vE8NPugFK1T3X4mkmghfwypIv8UYq5Me5auG/cG29svUMCRMfvIunG qjBgtln4a5STuTAbkvlASXcWaBB3Fqpeiv1pd7Rg49BYNgQsVsSoSjTr2a+CI5yAOe lDYdVQ9r0Znj0uQv2l2cJ+A4DyqXkEu5f4OPFU+NnQB3LuHfvYftM1ZCwoT1ZLNkWV WlMCdsVrm0WnA5/lnAg/5YS3pbyhZw5ir9oDNpKXhlhUZBbvLp5dKrhEUhslash4DK Hft62JY34i6F0HHEJ0KI8GjEAdnhoEKqGPjElZ5TBYUhYTnEEeEcwKJiVT+gidc1t3 vU2qmWCZIAtmw== Date: Sat, 11 Jul 2026 20:37:47 +0300 From: Jarkko Sakkinen To: Pan Chuang Cc: Peter Huewe , Jason Gunthorpe , Stefano Garzarella , Alper Ak , "open list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 2/3] tpm: Remove redundant dev_err() Message-ID: References: <20260710105318.376496-1-panchuang@vivo.com> <20260710105318.376496-3-panchuang@vivo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710105318.376496-3-panchuang@vivo.com> On Fri, Jul 10, 2026 at 06:53:07PM +0800, Pan Chuang wrote: > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), devm_request_irq() automatically logs > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() calls. > > Signed-off-by: Pan Chuang Reviewed-by: Jarkko Sakkinen Applied: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/ > --- > drivers/char/tpm/st33zp24/st33zp24.c | 5 +---- > drivers/char/tpm/tpm_i2c_nuvoton.c | 2 -- > drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 +--- > 3 files changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c > index e2b7451ea7cc..8d5179367eac 100644 > --- a/drivers/char/tpm/st33zp24/st33zp24.c > +++ b/drivers/char/tpm/st33zp24/st33zp24.c > @@ -506,11 +506,8 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops, > ret = devm_request_irq(dev, irq, tpm_ioserirq_handler, > IRQF_TRIGGER_HIGH, "TPM SERIRQ management", > chip); > - if (ret < 0) { > - dev_err(&chip->dev, "TPM SERIRQ signals %d not available\n", > - irq); > + if (ret < 0) > goto _tpm_clean_answer; > - } > > intmask |= TPM_INTF_CMD_READY_INT > | TPM_INTF_STS_VALID_INT > diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_nuvoton.c > index aa3673002f3a..c84afb29d548 100644 > --- a/drivers/char/tpm/tpm_i2c_nuvoton.c > +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c > @@ -576,8 +576,6 @@ static int i2c_nuvoton_probe(struct i2c_client *client) > dev_name(&chip->dev), > chip); > if (rc) { > - dev_err(dev, "%s() Unable to request irq: %d for use\n", > - __func__, priv->irq); > priv->irq = 0; > } else { > chip->flags |= TPM_CHIP_FLAG_IRQ; > diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c > index b48cacacc066..7f828fae70d3 100644 > --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c > +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c > @@ -751,10 +751,8 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client) > rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler, > IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN, > dev->driver->name, chip); > - if (rc < 0) { > - dev_err(dev, "Failed to probe IRQ %d\n", client->irq); > + if (rc < 0) > return rc; > - } > > priv->irq = client->irq; > } else { > -- > 2.34.1 > BR, Jarkko