The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: David Gall <david.ccm.gall@googlemail.com>
Cc: Ignat Korchagin <ignat@linux.win>,
	Greg KH <gregkh@linuxfoundation.org>,
	Eric Biggers <ebiggers@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: rsassa-pkcs1: use constant-time comparison for digest and signature verification
Date: Sat, 11 Jul 2026 17:17:32 +0200	[thread overview]
Message-ID: <alJejMW5JwNQWw7C@wunner.de> (raw)
In-Reply-To: <alInuM5TquLTv5QE@fudgebox>

On Sat, Jul 11, 2026 at 01:23:36PM +0200, David Gall wrote:
> That said, this function [rsassa_pkcs1_verify()] already uses
> crypto_memneq() for the hash-prefix check a few lines above.
> I'd argue for consistency it's worth using it for the digest
> comparison too.

I'd prefer the other way round, i.e. to use memcmp() for the hash_prefix
comparison.

Thanks,

Lukas

      reply	other threads:[~2026-07-11 15:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 17:29 [PATCH] crypto: rsassa-pkcs1: use constant-time comparison for digest and signature verification David C.C.M. Gall
2026-07-10 21:37 ` Eric Biggers
2026-07-11  5:19   ` Greg KH
2026-07-11  8:00     ` Ignat Korchagin
2026-07-11 11:23       ` David Gall
2026-07-11 15:17         ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alJejMW5JwNQWw7C@wunner.de \
    --to=lukas@wunner.de \
    --cc=davem@davemloft.net \
    --cc=david.ccm.gall@googlemail.com \
    --cc=ebiggers@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@linux.win \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox