From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B7693043B2; Sat, 11 Jul 2026 18:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783793916; cv=none; b=O0WR/PqatJUME555ThqUTLVDkgv1qjCBclFkq3jlFVbYEfGEKCD49w1JF1j7U/PeUb5QzVsRsgAZ7yqx9JH15XItLJeNm6twOaSDkafZUj7sOV0u7UQKDGfcVA586qtXXz97uDTeBjOEEiLe9dC54f+tqyInbSZ2CNHve2OXVjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783793916; c=relaxed/simple; bh=qKKIsCXcVUBZU3uc3zUUqOctHFwHaU2JVITvx17odJU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CgqiB5IzFxYgs5jX6VKy12oAdrvbAAYukKmNQGUld3y6wQNCOiIv16rbpNR1xi9cc8UhM1fvhHSIGHqHAm4i/TFn8obH6WN07B5mviqZukh66d6shYZiDUWRUnlMqjt5OVdH+9eC80UFjgcKdloZNhM+q+W4MOPwjJ0eNqrOTpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Quytj4KT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Quytj4KT" Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 20AD21F000E9; Sat, 11 Jul 2026 18:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783793913; bh=E7vKDBmC/PLx4EQvGKIBYk7PhCr0DaSZmFLJOx/Zqbs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Quytj4KTWKdnH9uKdTwsNQ4KefbEakv1Wx88va+TEzqspyUHDuwu6GnN+kw+ia2U3 NzLALeG5absvJmH4BdKeBq2cXvs+VgmeZHf2xhQxTiPGmVgyg6aGe9UeG/p8PWiCOT Vy2y4jNgNwGDhptMPEPchRpkiTyGwJ4NdoRhCU9mJtYsIZOrhUmoGvpqKqidIETr24 yiULYY6iXdCZx/GMqr6GkXM/KfMG0sedYDjqO+j1gbIOhy7pDb6iv443tRMM3ejoDZ gE8uAaJywn817DGq18OMltwvFUMrC0H/bJyMAHJq1h07+SktQeTbFnN85qKJmoluvZ a5nydifpMh5Cg== Date: Sat, 11 Jul 2026 21:18:30 +0300 From: Jarkko Sakkinen To: Ross Philipson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org, linux-efi@vger.kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, dave.hansen@linux.intel.com, ardb@kernel.org, mjg59@srcf.ucam.org, James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de, luto@amacapital.net, herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net, kanth.ghatraju@oracle.com, daniel.kiper@oracle.com, andrew.cooper3@citrix.com, trenchboot-devel@googlegroups.com Subject: Re: [PATCH v2 10/10] tpm-buf: Add TPM buffer support header for standalone reuse Message-ID: References: <20260711160110.267780-1-ross.philipson@gmail.com> <20260711160110.267780-11-ross.philipson@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260711160110.267780-11-ross.philipson@gmail.com> On Sat, Jul 11, 2026 at 09:01:10AM -0700, Ross Philipson wrote: > Extract all the functions and definitions for TPM buffer handling > and separate them into their own header. > > Signed-off-by: Ross Philipson > --- > drivers/char/tpm/tpm-buf.c | 3 +- > include/linux/tpm.h | 34 +-------------------- > include/linux/tpm_buf.h | 60 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 63 insertions(+), 34 deletions(-) > create mode 100644 include/linux/tpm_buf.h > > diff --git a/drivers/char/tpm/tpm-buf.c b/drivers/char/tpm/tpm-buf.c > index 1e5c11c312a8..233e81d3f149 100644 > --- a/drivers/char/tpm/tpm-buf.c > +++ b/drivers/char/tpm/tpm-buf.c > @@ -4,7 +4,8 @@ > */ > > #include > -#include > +#include > +#include > > static void __tpm_buf_size_invariant(struct tpm_buf *buf, u16 buf_size) > { > diff --git a/include/linux/tpm.h b/include/linux/tpm.h > index 598dd53a10d8..0db277af45c3 100644 > --- a/include/linux/tpm.h > +++ b/include/linux/tpm.h > @@ -26,6 +26,7 @@ > #include > > #include > +#include > > struct tpm_chip; > struct trusted_key_payload; > @@ -200,44 +201,11 @@ enum tpm_chip_flags { > > #define to_tpm_chip(d) container_of(d, struct tpm_chip, dev) > > -enum tpm_buf_flags { > - /* TPM2B format: */ > - TPM_BUF_TPM2B = BIT(0), > - /* The buffer is in invalid and unusable state: */ > - TPM_BUF_INVALID = BIT(1), > -}; > - > -/* > - * A buffer for constructing and parsing TPM commands, responses and sized > - * (TPM2B) buffers. > - */ > -struct tpm_buf { > - u8 flags; > - u16 length; > - u16 capacity; > - u8 handles; > - u8 data[]; > -}; > - > struct tpm2_hash { > unsigned int crypto_id; > unsigned int tpm_id; > }; > > -void tpm_buf_init(struct tpm_buf *buf, u16 buf_size); > -void tpm_buf_init_sized(struct tpm_buf *buf, u16 buf_size); > -void tpm_buf_reset(struct tpm_buf *buf, u16 tag, u32 ordinal); > -void tpm_buf_reset_sized(struct tpm_buf *buf); > -u16 tpm_buf_length(struct tpm_buf *buf); > -void tpm_buf_append(struct tpm_buf *buf, const u8 *new_data, u16 new_length); > -void tpm_buf_append_u8(struct tpm_buf *buf, const u8 value); > -void tpm_buf_append_u16(struct tpm_buf *buf, const u16 value); > -void tpm_buf_append_u32(struct tpm_buf *buf, const u32 value); > -u8 tpm_buf_read_u8(struct tpm_buf *buf, off_t *offset); > -u16 tpm_buf_read_u16(struct tpm_buf *buf, off_t *offset); > -u32 tpm_buf_read_u32(struct tpm_buf *buf, off_t *offset); > -void tpm_buf_append_handle(struct tpm_buf *buf, u32 handle); > - > /* > * Check if TPM device is in the firmware upgrade mode. > */ > diff --git a/include/linux/tpm_buf.h b/include/linux/tpm_buf.h > new file mode 100644 > index 000000000000..f8c105d8b8bf > --- /dev/null > +++ b/include/linux/tpm_buf.h > @@ -0,0 +1,60 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Following copyright information was take from the original file > + * where the definitions were moved from: > + * > + * Copyright (C) 2004,2007,2008 IBM Corporation > + * > + * Authors: > + * Leendert van Doorn > + * Dave Safford > + * Reiner Sailer > + * Kylene Hall > + * Debora Velarde > + * > + * Maintained by: > + * > + * Device driver for TCG/TCPA TPM (trusted platform module). > + * Specifications at www.trustedcomputinggroup.org > + */ > + > +#ifndef __LINUX_TPM_BUF_H__ > +#define __LINUX_TPM_BUF_H__ > + > +#include > +#include > + > +enum tpm_buf_flags { > + /* TPM2B format: */ > + TPM_BUF_TPM2B = BIT(0), > + /* The buffer is in invalid and unusable state: */ > + TPM_BUF_INVALID = BIT(1), > +}; > + > +/* > + * A buffer for constructing and parsing TPM commands, responses and sized > + * (TPM2B) buffers. > + */ > +struct tpm_buf { > + u8 flags; > + u8 handles; > + u16 length; > + u16 capacity; > + u8 data[]; > +}; > + > +void tpm_buf_init(struct tpm_buf *buf, u16 buf_size); > +void tpm_buf_init_sized(struct tpm_buf *buf, u16 buf_size); > +void tpm_buf_reset(struct tpm_buf *buf, u16 tag, u32 ordinal); > +void tpm_buf_reset_sized(struct tpm_buf *buf); > +u16 tpm_buf_length(struct tpm_buf *buf); > +void tpm_buf_append(struct tpm_buf *buf, const u8 *new_data, u16 new_length); > +void tpm_buf_append_u8(struct tpm_buf *buf, const u8 value); > +void tpm_buf_append_u16(struct tpm_buf *buf, const u16 value); > +void tpm_buf_append_u32(struct tpm_buf *buf, const u32 value); > +u8 tpm_buf_read_u8(struct tpm_buf *buf, off_t *offset); > +u16 tpm_buf_read_u16(struct tpm_buf *buf, off_t *offset); > +u32 tpm_buf_read_u32(struct tpm_buf *buf, off_t *offset); > +void tpm_buf_append_handle(struct tpm_buf *buf, u32 handle); > + > +#endif > -- > 2.55.0 > I would probably ack them all as I've seen these many times and there's not much anything new. Just waiting for additional feedback before applying them. BR, Jarkko