From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FFDC25B0B3 for ; Sat, 11 Jul 2026 22:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783807918; cv=none; b=LrDRJ/S32oFHlhd4BBIlIqOVvvarnM4jpyoiO6mPTvCJmZjgg2GCoBjOSwcNrMlXIfzSk8LaW9T0UpZJQ3CwWfrx0bYysM1wFl07bSwPJ1eNBt6BQqnZY2nKWOHVBavZOm51ot3pBY3uS309tX9sapCw6UtWBHMp5HO7vB0/ceU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783807918; c=relaxed/simple; bh=4Sn7R6YVdoHQ95dqj0ZspkmI8xnHHeUwvOuh8g27vj8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oj4SmfkOeOA6qiLPsDw4iSwBXZjYeJWlx7MpifzrKPNWV/u6MG8vfbBq4jo6cjREiAbup1TqRg0aTvgXrEo8pf8hYJ4STh5BeVm79gWW5twTfzVZ4vtU8v4IcsEvOKR2x11nbpeXOC4llRAPXwt8xseynE1oQTcP06f6DDkqJL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=THlRNAcQ; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="THlRNAcQ" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-84536ecfc5bso2270633b3a.2 for ; Sat, 11 Jul 2026 15:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783807917; x=1784412717; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pe0jcb6EYD+fFbLyURVUHtob9a1cFR2K5bbV214XWLI=; b=THlRNAcQq2VgxMmumD7+Zbyv+YgFxEz/OoeFFhb0gKnCyw7M9+mLFce+pR39FCyc5x 5LF+evxKaPSpSw9mSzCEtvisfvHzZfiP1izl5g5yLUtUb3e+E/2KwC/EbtLbPdB3Atwy 17nNBXVKY651Ro670GFJVfgaao8oQXQ9w2rv2VXcoTN8mj3xOkVMzRStBPsgrG2yI2yK 8LJjtPNERKKmVrwVSUSEe7AN3EsFCODbiJl8ekt9+h2QVEQ1TLEMWZrB0w0E5w7SG4QG 07393EqrPj/X4hQpNtwjW0j79BJlpE1ROEOPbqulhRiriyetoINA33DPGV690QRLf7QC actA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783807917; x=1784412717; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pe0jcb6EYD+fFbLyURVUHtob9a1cFR2K5bbV214XWLI=; b=dWx7XIXOASIq4/JFAf+ET4DBFyqKlYta6dp1I4Tk6WWMlWS1Me/dHwToqbID+gx+EE wl3RZB8XIB5RcNFgmPIDWkoJuPVmP4cYoFgw0dTvlLtprgAHRt8bI8D0yjH2ZiObRqkN QHBY0RejDyqTXczH18I3KHfoLhgcKiERmYKc9nedmDDAbmxQZ2L8XajKeWu4Skhsgam/ N401cg7dsPkMVAqAcjIBvOCir6j28jfdWuE6WbI+tK3zoqYofA0vT2SxFs+uWD4XowLs M+Vqx02MtFq1hKia5KKHsuyfja8AhmdhEgG/XCcmBAmT8XZjgPMC6dQkbSvyUI0Y1dCZ afVA== X-Forwarded-Encrypted: i=1; AHgh+RoVrD00aj5r650PWmBo2MuugjA/AWINv56FKs0Apwq/y0hVWiJ7D/Zk4T6zMhVswWwI2VrDKF3mKM6sqVU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4x06znKBKajgG5fUyEsZX+N8JaIZqOnx/xImIauo7gyznls6k N3Xp6w59S5oqlHU8GrKmGC9Hb3dTnQpyAdZDUxuKLDdkSzyxSwUt10Ac X-Gm-Gg: AfdE7cl6Nrkt1pcdvi5n3PzihbM7zd0+lqWXgRnTXpzrlKdKVHlCxJBOzBbwcSI6Cu7 rlHJdl308cxeodR78+NuDvPQRB3+zCN2HPqIohdpGz6t3/PQ0Vbd0PMDDmzdx/4ngbJ9pp09eOy IdK0msBSDIf2IUY3Lpx0ko+220dnhW8ZvQoxRoAJKAlxlT2bcK3g487YovdJO4Y2nma+N4OeF6f s9O6iPAKEAFbyfVs9DL2HBKazuCxvgiAEvoUOssqSuOgugpsHGJbVf3ntKHI1A+q1L1EXhCfcBM 58wayOUj7frWyC7g3u9t4wkhcM5+ZipXfc9eZ9hMByRLeGOSgnZx6VJHBuCWqEV+gYw25wKctfH J/xHRRKXTcWS3KRZVcjMS+c7T0/jGlsp7+lzlQEJEz4OPN15Qfpoj0fXUJjoG7q6n0DPH1ewsyQ ywkItwY6eyAvlAY5ucqvh/u7JJPK7eK5nN4F71Ybn7W+N3G9jenTn7cTcjxeQDdBE= X-Received: by 2002:a05:6a21:3995:b0:3b1:cce5:9140 with SMTP id adf61e73a8af0-3c1104e576fmr4101076637.33.1783807916929; Sat, 11 Jul 2026 15:11:56 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:c63e:9756:a95c:c75]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b9ca880fsm14324115eec.23.2026.07.11.15.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 15:11:56 -0700 (PDT) Date: Sat, 11 Jul 2026 15:11:53 -0700 From: Dmitry Torokhov To: Luis Chamberlain , Russ Weight , Danilo Krummrich Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] firmware_loader: builtin: ignore 0-size firmware Message-ID: References: <20260426043041.649202-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260426043041.649202-1-dmitry.torokhov@gmail.com> On Sat, Apr 25, 2026 at 09:30:38PM -0700, Dmitry Torokhov wrote: > Currently, the builtin firmware loader allows 0-size firmware to be > returned successfully to drivers. This differs from all other loading > mechanisms (filesystem, sysfs fallback) which reject 0-byte files, and > forces drivers to add boilerplate size checks. > > Modify firmware_request_builtin() to reject 0-size firmware. This will > also result in firmware loader falling back to other mechanisms if an > empty built-in firmware is present. > > Signed-off-by: Dmitry Torokhov > --- Gentle ping on this and the next one... > drivers/base/firmware_loader/builtin/main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/base/firmware_loader/builtin/main.c b/drivers/base/firmware_loader/builtin/main.c > index d36befebb1b9..1dcebe8e7f8e 100644 > --- a/drivers/base/firmware_loader/builtin/main.c > +++ b/drivers/base/firmware_loader/builtin/main.c > @@ -53,6 +53,8 @@ bool firmware_request_builtin(struct firmware *fw, const char *name) > > for (b_fw = __start_builtin_fw; b_fw != __end_builtin_fw; b_fw++) { > if (strcmp(name, b_fw->name) == 0) { > + if (b_fw->size == 0) > + return false; > fw->size = b_fw->size; > fw->data = b_fw->data; > return true; -- Dmitry