From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFCAF53E0B for ; Sun, 12 Jul 2026 00:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783815840; cv=none; b=ZLrXd7vUktAs7mv+NuPXtxcdU0wj2aTP80rdmKDNpDRhbaApr0UvHv9TCrMwW9wNcjwzmOrik3pn+GIRDsoTgSzOpCkFk5r5OHaM8U7c59wrTiYlgJLf8AsnnyqtoBZ7lN8uxwrWYJExDhipNFWulbPMgquAmxcRoV9+CFVxAng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783815840; c=relaxed/simple; bh=bAEX6IrgDDFkv2APR0+bCQv7uhaJbAiYg7bB5M6IjJI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VC2E50+0Li2fPenre+AgcIHUMyyT8OONCqrzrZSMmn7nVnJj8iQzRQHeu8NWcbo0l7KNGi2EWosBMsANgSS3OcTxYPKkFp6iTtpAOdq3KLJVNBxqoLuNDgf3SNzMtqCUOBIgy4ahwWmnMKQ91rBoT4HEKEDjoUYP3i9FGP2jdKs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m+P5Amow; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m+P5Amow" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ccdb73f0e1so17294825ad.3 for ; Sat, 11 Jul 2026 17:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783815839; x=1784420639; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3ix8TBK7GOyTp1WMmZekQKMguwcNzpi3wCbkHSbHtB4=; b=m+P5AmowLZysu2r6/U5f5zY8vczF1bpjC+UvOHEhtRK7pf7GNB17QejI7EOVGNbZTM jztgSRcdew+BPgbvb1pNAIM94BrmsytXOPDdMDNfHRWgvTs2icElqOnPdlj0FsUjlhld vkLiqZN0pO3VtKwvhzdeBdk5pVGOCnEghpFXCgDGk/ApPDRe+2ZkLBPwZY5L8fGpakcg pLzfgnoSWH2cckxmcpMTWCindsr36GGI57zZVmLW5CETTb6LzxYSq7e3ldHkivbab0Wh 3iMTu8JCjAOfN3KlWgu7egfgJCatYZHrYzYU23OnxbiVSrvM686JBYEpDZo+gLNqBeE2 tLPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783815839; x=1784420639; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3ix8TBK7GOyTp1WMmZekQKMguwcNzpi3wCbkHSbHtB4=; b=a9xLUEpVbQpQJDXDdprBq8J0gak/bo2A3EGhvoelHGDg3WghMB5ByRoeVSp7PuRKsW 4CaapOYpXG479krXi8oFAYHAc2oP9ks1Ga1fRX1ffoFdIOMSF8g1ShXteEdlAezbUcer V2tQuYzjE7D7AhIuDfD6CCHtwAcpol+OA8o2oMSX8nWQ2M+7rchG88GZcdzz2jRVj+Z/ o3tisNkK+xOBU5r+XEpJwNMf9d4W/aTC5JDhCaTaWiqYnShCMbsE15Zsej31eiyk+VYx fP5GU9x5JdgLyrJekVoULbMQtJ269p+skglKiSIZ8aDMxfPJFtW9aC/madU1Zixqy3CR weJQ== X-Forwarded-Encrypted: i=1; AHgh+RpJHpo9/jWfBQdqAAybSVlBpMqQ9wVrxEBSIcb9qHuKKPzGXoE0bzkE2QR87sk3uNo9TzqMIUSp8LnbLrY=@vger.kernel.org X-Gm-Message-State: AOJu0YwuxpdJcXTt0fuNccjFTHTIULFeRQmUn2d/ATeNB7j8nZd0DaiB aNpAGfk5oPJtD+RohayqpDk9QOOP9XUXStN3u76ME/dte5BiVDKxBLHXOi8f6A== X-Gm-Gg: AfdE7cnPbockrerg7pp1OEwsS2GS9BtYmGt/CScOGqgFxhO9xJGzJmwLnxTFjAJxAdb 0PODsrVQZcP7vy64xFLPFuXqz1/IdWJ3pa/IzC7ltb3fmuhowiZkKLYEpGKcW+zYyYQf/LmXK4J sWBjZ1+VWM7VA1sRMiOrorXaHnfhVlY0O94A4zlYQs0xO7SxgqgKIzGsdXvFFsvmUgr5uelKQfD sBaxjcRRCAlx+Cq4AxrlJZLalz4+TY0JWWYCcKZAXgpWjbXTpWmQPg4CDyFGvddW4+NJWh8Rl1Z 6VPCqfFodow8Q5tDmRqwz6S9Vv+Vptj0e5a6Z5BZwPK9h9YeIZH4HViH18ziOMPydxDgx6SBoJd SnRf5zWkPxKN56qKtQ4ICXnSz0WE4O39Yp5q7QqRK197caqiVZw9ZbxTKz2425eYUDrVly0UlJg rCtrTkfP7dM+EyxqZH5Rx0bAzw1P31sy2oAcpR48q1TLYUpvBDjSr/jqjhAA4xlVc= X-Received: by 2002:a05:6a21:4d8f:b0:3c0:9c1a:894f with SMTP id adf61e73a8af0-3c110b33403mr4710043637.71.1783815839033; Sat, 11 Jul 2026 17:23:59 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:c63e:9756:a95c:c75]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659c865asm59615501c88.11.2026.07.11.17.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 17:23:58 -0700 (PDT) Date: Sat, 11 Jul 2026 17:23:55 -0700 From: Dmitry Torokhov To: Danilo Krummrich Cc: Luis Chamberlain , Russ Weight , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] firmware_loader: builtin: fail build on empty firmware Message-ID: References: <20260426043041.649202-1-dmitry.torokhov@gmail.com> <20260426043041.649202-2-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Jul 12, 2026 at 01:58:26AM +0200, Danilo Krummrich wrote: > On Sun Apr 26, 2026 at 6:30 AM CEST, Dmitry Torokhov wrote: > > + if [ ! -s "$(fwdir)/$(FWNAME)" ]; then \ > > + echo "error: empty firmware: $(fwdir)/$(FWNAME)" >&2 ;\ > > + exit ;\ > > Shouldn't this be 'exit 1' to actually fail the build? Yes, you are absolutely right. Do you want me to resend or you can fix it up on your end? Thanks. -- Dmitry