From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F41E3352C35 for ; Sun, 12 Jul 2026 08:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783844858; cv=none; b=F3bqIkNJMMHIekAxlILY+KF5nwGgWZwU0VnXUj66EOiCxdrAlsAulxvfgGo6WvUjGICiqx5IRChLR7nUbTgKJVWnwRt/iu9k2kCCx24TzhNeNwcG+fE+XN8f2uAxJa4tWaQs8Gq+cXTSShI6EVSRK/zP+fjCc2ztJolsa8wOb80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783844858; c=relaxed/simple; bh=626fGE8b9M+WOiUN5juPo4lBClPmSkP2wYtStJIhWjY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c0N/JI6j2JpvYWR71HAVqJfwktdDbCDtaT2pxKPq56F+6dDDhsLoqHku9Ezn33QQ/voD3powWVAiHqAw+UB2pp6FjFsN35tnVatU7Dsh4Eg5cTW51R4wQKF0S4dgpR96OHV6VT98JzXQw1MQTAjBsyD/0MpOXso6GRNFLGDCLiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YpiLFbDb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YpiLFbDb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 844B11F000E9; Sun, 12 Jul 2026 08:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783844856; bh=enyWtChxLifT9CO1+iCJe3PI3c5SIL5ZQ7wN+THBh48=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YpiLFbDbz0bHYo0Nbd3BrGFfnFO4xG8aecNSUO1DIa7bjBaf9hmAzUdvqCQnhexG9 hlMpdqz3ofJIC6nqqLWRG42hdIckXAL6I+GZJugsXIUWQhGQrLv2mfppOLribndjsG YNg1PwAhBhq/YeeqUPBH2Ec6tZ65DKH3rsGbm9ijvbRCx4ZcgS4z0m2VLkbFHp/mmk X8cVMfVHIeYXPWXxec354SXLL38/PhHyemE6WcxuRJqQUiOtNqOn2H/4a0suxjgchm bXIEEvgR3eZYM3MtRI3CVCktl8o/JtKc1TG5VezFBpdIsVhGF4V0P3JC6BbVg1q0Mf 2VAy7TNmEoKUA== Date: Sun, 12 Jul 2026 09:27:22 +0100 From: Lorenzo Stoakes To: Mike Rapoport Cc: Andrew Morton , Suren Baghdasaryan , "Liam R. Howlett" , Vlastimil Babka , Shakeel Butt , David Hildenbrand , Michal Hocko , Uladzislau Rezki , Toshi Kani , Catalin Marinas , Will Deacon , David Carlier , Dev Jain , Ryan Roberts , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] Revert "arm64: Enable vmalloc-huge with ptdump" Message-ID: References: <20260710-series-vmap-race-fix-v1-0-5b3794c113fe@kernel.org> <20260710-series-vmap-race-fix-v1-2-5b3794c113fe@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jul 11, 2026 at 01:15:45PM +0300, Mike Rapoport wrote: > On Fri, Jul 10, 2026 at 11:49:19AM +0100, Lorenzo Stoakes wrote: > > Subject: [PATCH 2/2] Revert "arm64: Enable vmalloc-huge with ptdump" > > Without reading the full changelog this sounds like you are disabling > vmalloc-huge with ptdump ;-) > > How about "remove redundant locking guarding ptdump against vmalloc-huge"? I'm just following the standard convention when it comes to partial reverts, as I revert the majority of the patch and I ran 'git revert' to do it ;) But then again I do remove the arm64 ifdeffery in the same commit and you're right it does suggest I revert more than I do so will fix it up! > > > This partially reverts commit fa93b45fd397 ("arm64: Enable vmalloc-huge > > with ptdump"), retaining vmalloc-huge support but eliminating the now > > redundant mitigation against a race between huge vmap page table freeing > > and ptdump, as this issue has now been fixed at core. > > > > We also simultaneously remove the arm64 ifdeffery when acquiring the mmap > > read lock upon vmap huge page table promotion as it is no longer required. > > > > Signed-off-by: Lorenzo Stoakes B > > Acked-by: Mike Rapoport (Microsoft) Thanks! > > > --- > > arch/arm64/include/asm/ptdump.h | 2 -- > > arch/arm64/mm/mmu.c | 43 ++++------------------------------------- > > arch/arm64/mm/ptdump.c | 11 ++--------- > > mm/vmalloc.c | 15 +++----------- > > 4 files changed, 9 insertions(+), 62 deletions(-) > > -- > Sincerely yours, > Mike. Thanks, Lorenzo