The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: add debug information
Date: Sun, 12 Jul 2026 11:37:18 +0200	[thread overview]
Message-ID: <alNgTmkDHpYHVCVM@1wt.eu> (raw)
In-Reply-To: <20260707-nolibc-debug-v1-1-31619ec94bbd@weissschuh.net>

Hi Thomas,

On Tue, Jul 07, 2026 at 06:42:30PM +0200, Thomas Weißschuh wrote:
> When working on nolibc, debug information is very valuable.
> I find myself adding this flag in many patchsets.
> 
> Enable debug information unconditionally, as there is no downside to it.

Indeed, I would have thought we already had it.

> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Acked-by: Willy Tarreau <w@1wt.eu>

Thanks!
Willy

> ---
>  tools/testing/selftests/nolibc/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/nolibc/Makefile.include b/tools/testing/selftests/nolibc/Makefile.include
> index c30ca3a9ef14..ea520eac64a6 100644
> --- a/tools/testing/selftests/nolibc/Makefile.include
> +++ b/tools/testing/selftests/nolibc/Makefile.include
> @@ -5,7 +5,7 @@ _CFLAGS_STACKPROTECTOR ?= $(call try-run, \
>  	echo 'void foo(void) {}' | $(CC) -x c - -o - -S $(CLANG_CROSS_FLAGS) $(__CFLAGS_STACKPROTECTOR) | grep -q __stack_chk_guard, \
>  	$(__CFLAGS_STACKPROTECTOR))
>  _CFLAGS_SANITIZER ?= $(call cc-option,-fsanitize=undefined -fsanitize-trap=all)
> -CFLAGS_NOLIBC_TEST  ?= -Os -fno-ident -fno-asynchronous-unwind-tables -std=c89 \
> +CFLAGS_NOLIBC_TEST  ?= -Os -fno-ident -fno-asynchronous-unwind-tables -std=c89 -ggdb \
>  		-W -Wall -Wextra -Wundef -Wwrite-strings \
>  		$(call cc-option,-fno-stack-protector) $(call cc-option,-Wmissing-prototypes) \
>  		$(_CFLAGS_STACKPROTECTOR) $(_CFLAGS_SANITIZER)
> 
> ---
> base-commit: a3b2181459a2c74c03ddbad585f884eefc8ff8ff
> change-id: 20260707-nolibc-debug-04c9cedd3eaf
> 
> Best regards,
> --  
> Thomas Weißschuh <linux@weissschuh.net>

      reply	other threads:[~2026-07-12  9:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 16:42 [PATCH] selftests/nolibc: add debug information Thomas Weißschuh
2026-07-12  9:37 ` Willy Tarreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alNgTmkDHpYHVCVM@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox