The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Balbir Singh <balbirs@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Usama Arif <usama.arif@linux.dev>,
	apopple@nvidia.com,  baohua@kernel.org,
	baolin.wang@linux.alibaba.com, byungchul@sk.com,
	 david@kernel.org, dev.jain@arm.com, gourry@gourry.net,
	jannh@google.com,  joshua.hahnjy@gmail.com, lance.yang@linux.dev,
	liam@infradead.org,  linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, ljs@kernel.org, matthew.brost@intel.com,
	 npache@redhat.com, rakie.kim@sk.com, ryan.roberts@arm.com,
	vbabka@kernel.org,  ying.huang@linux.alibaba.com, ziy@nvidia.com,
	shakeel.butt@linux.dev, hannes@cmpxchg.org
Subject: Re: [PATCH v3 0/3] mm: handle device-private PMDs in walk callbacks
Date: Mon, 13 Jul 2026 11:33:22 +1000	[thread overview]
Message-ID: <alQ-873fbNk-FA--@parvat> (raw)
In-Reply-To: <20260710165348.cab6f58aa81b30e34d121d0d@linux-foundation.org>

On Fri, Jul 10, 2026 at 04:53:48PM -0700, Andrew Morton wrote:
> On Fri, 10 Jul 2026 03:55:20 -0700 Usama Arif <usama.arif@linux.dev> wrote:
> 
> > Since commit 368076f52ebe ("mm/huge_memory: add device-private THP support
> > to PMD operations") a PMD may hold a device-private swap entry whenever
> > an HMM-based GPU driver migrates an anonymous THP folio to device memory
> > via migrate_vma_pages().
> > 
> > pmd_trans_huge_lock() succeeds for such PMDs (pmd_is_huge() returns true
> > for any non-present, non-none huge PMD), so several MM walk callbacks
> > that used to assume present THP or migration entry are now reachable with
> > a device-private PMD. The results range from a VM_BUG_ON() firing on debug
> > kernels, to an oops on a bogus vmemmap dereference, to silently isolating
> > an unrelated live folio from LRU in the aliasing case.
> 
> Added, thanks.
>

Thanks Andrew!

> I didn't add these as hotfixes - the Fixes: commit is somewhat old. 
> Feel free to disagree with this!
> 
> Sashiko went nuts over possible pre-existing issues:
> 
> 	https://sashiko.dev/#/patchset/20260710105557.1987433-1-usama.arif@linux.dev
> 

The pointed out seems plausible? I am working on some tests to catch
more errors via hmm-tests.

Balbir

      reply	other threads:[~2026-07-13  1:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 10:55 [PATCH v3 0/3] mm: handle device-private PMDs in walk callbacks Usama Arif
2026-07-10 10:55 ` [PATCH v3 1/3] mm/mempolicy: skip non-present PMDs when queueing folios Usama Arif
2026-07-12 12:39   ` Gregory Price
2026-07-13  3:38   ` Balbir Singh
2026-07-10 10:55 ` [PATCH v3 2/3] mm/madvise: skip device-private PMDs in cold and pageout walks Usama Arif
2026-07-12 12:40   ` Gregory Price
2026-07-10 10:55 ` [PATCH v3 3/3] mm/huge_memory: skip device-private PMDs in madvise_free_huge_pmd Usama Arif
2026-07-10 12:41   ` David Hildenbrand (Arm)
2026-07-10 12:41   ` David Hildenbrand (Arm)
2026-07-12 12:47   ` Gregory Price
2026-07-10 23:53 ` [PATCH v3 0/3] mm: handle device-private PMDs in walk callbacks Andrew Morton
2026-07-13  1:33   ` Balbir Singh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alQ-873fbNk-FA--@parvat \
    --to=balbirs@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=byungchul@sk.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=jannh@google.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=npache@redhat.com \
    --cc=rakie.kim@sk.com \
    --cc=ryan.roberts@arm.com \
    --cc=shakeel.butt@linux.dev \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox