From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19FE6372055 for ; Sun, 12 Jul 2026 21:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783891391; cv=none; b=axr/hvz0MrLe4GdvqM3lzPNhgBlZWQb+lwk8f/WzWc4VYhwvQr/LuYj78HQ2HqrUeq7Lk8f1o4eie+IywV9KQs66y+o0H2sbXbMingsT0OvXMn9GKmYGjm6ONqo5aN94rv5/gmPZZhTcmd14aUucUB8EXQfnw2CK+hR8168j1M0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783891391; c=relaxed/simple; bh=uq2LxliGBRPTNUdXlsaJF47jC+6soJ82ARALMRXUVQ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type:Content-Disposition; b=o9cWCPv8zhaT5ZfcVc9Q9Az3oN57mEpxTVd2wfkhKQUBn7+HRye5Nk1zWF5tbwbR1yK3iI9gfQIlo+W7vFgqe3+7BwedzdLyuJfHSV1pCpidU2xRxaDhpRJEQcyvU6uH6Lf/+xHayKLF9EzVS+EJrVG/3XdfK0LSS5D//hg6Tfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DrhyXslj; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DrhyXslj" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-47db714766aso1700205f8f.0 for ; Sun, 12 Jul 2026 14:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783891387; x=1784496187; darn=vger.kernel.org; h=content-transfer-encoding:content-disposition:content-type :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0possHhbYWMvozQHF1jT+xcy8ymwyLPGUVqKNvmfdh8=; b=DrhyXsljlUoBfsu4QeQ+9ZyIkKxFmgO6+XUdq+ehWoNWMlzGG+z2UIHnUkyKEG34Vy lhqb0WPFkoMe5uSXZmsNrXEzh9eCQCq5wJhmTkSndcVbAh/aYdDshFojoPUKhA7DYuq4 DDdTs8uT4atP0SzRLwNO6iwxu3u5ylRc6ZYAqew71eN1Z9HiLXBjlAccjAS1VrBXnHzl FnjyuXYbc7DpBWaaHHGZjt3iNXWehDuIOg1Fu9PletrkBSKmpTwBYAlchiKMNwTNrWQ5 LL7DKX3LeNmqmo6Y6zdlU7BcvvvpCFQxUsU426uLktS/jdVvXA0M0dDb+QRzyfES3BGJ jCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783891387; x=1784496187; h=content-transfer-encoding:content-disposition:content-type :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=0possHhbYWMvozQHF1jT+xcy8ymwyLPGUVqKNvmfdh8=; b=gL1QowdaCZi1Hma81DcoBbt67zJobAkkHo1EOJB4ltjyLZ89EAvWEuo62h7KcQps73 tqqGb8YFEB5VFOvcaLwsiQTpeHEaLn6QCaZIXFosuKCDOL1FoyebVE330fA36hifl1iI teBxsJVTPYSR8mJQZbrShWgZqB2zLPzdH51ptsnsdDSSLzK3QUIe4+ppNFJFs9nRmRUk JLPWF8W+/13cThdZgz6BAaqbruNpt4By6U8eUAJesZv8EE6KPdmkGc2xZ1ipPrKpIa2f ieEWNFiwedXxcmS96+pvZHpVqnwikgHYYNwvwF40KGONJUOgevVwCz5QOmcU3NHkk0Gn fSBw== X-Forwarded-Encrypted: i=1; AHgh+RpFV89u/dgaVpp0SN4ujlzknmPlZV89GnCYsKGsjrSDkP49Lu3KPEDDhqXNT/l4nPMJTmG6okkRiKR5uZc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5SEpeKsGIGepI6GCT3S2jnNDcHJquOLvGzXNSsQn3tzcXAalT wLEvjsGkf5IRCtBbhPI1BSItRtisJla2RjLt3F8Fex8wOAkBx+OZgmeE X-Gm-Gg: AfdE7cnF2SoVx0WTL2WfjdjTqTyY/35l7PLLxoaZxQFhUY7hgvw7+rrpgZTGyKKaq9O o9xcp5dT+sedozl5yeG5JLTCIujyAFSYXUEcSZLPEAzEYBWkwVrp9kUNZxvQ91zaJLAHknXQNEN vFF4tuOLHn2S+GikU0tbSscvIgyl0/CiC0sLj5wguM+ecgGEhwzbFRcvfnOJVaKZDdMLK8fH7r6 7P7+EwWaG0D5cDBx20S7lE5keD1clWbAD2jSCGmHcgFvrNuXQUwS0GbHfO54MPlaLxh9QagVL39 xkOOepmBGIHyJ2Vv5dltRWbwXrvIasUCTqT7dQcfxJ8oyQ9LiotI6kZeKlvqgCPfjtqGZXgw2U8 Npp0+4zh3vViRfJGeEYrcOuHk6dR/93NJaqVXaJ27hJYGx7SPqAOsvGd5IDRzr+DYj9Y6lJFM0R D+cPPmIF6n4qk13X4slZ+Wmg== X-Received: by 2002:a05:6000:22ca:b0:47e:4379:a4ed with SMTP id ffacd0b85a97d-47f2dcd9e36mr7905011f8f.30.1783891387132; Sun, 12 Jul 2026 14:23:07 -0700 (PDT) Received: from WindFlash.powerhub ([2a0a:ef40:f61:3b01:d08a:833b:756:8fce]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960634sm80813963f8f.26.2026.07.12.14.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 14:23:06 -0700 (PDT) From: Leonardo Bras To: Randy Dunlap Cc: Leonardo Bras , Jonathan Corbet , Shuah Khan , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , Brendan Jackman , Johannes Weiner , Zi Yan , Harry Yoo , Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Qi Zheng , Shakeel Butt , Axel Rasmussen , Yuanchu Xie , Wei Xu , "Borislav Petkov (AMD)" , Feng Tang , Dapeng Mi , Kees Cook , Marco Elver , Jakub Kicinski , Li RongQing , Eric Biggers , "Paul E. McKenney" , Nathan Chancellor , Nicolas Schier , Miguel Ojeda , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Thomas Gleixner , Douglas Anderson , Gary Guo , Christian Brauner , Pasha Tatashin , Coiby Xu , Masahiro Yamada , Frederic Weisbecker , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rt-devel@lists.linux.dev, Marcelo Tosatti Subject: Re: [PATCH v4 1/4] Introducing pw_lock() and per-cpu queue & flush work Date: Sun, 12 Jul 2026 18:23:04 -0300 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: <20260519012754.240804-1-leobras.c@gmail.com> <20260519012754.240804-2-leobras.c@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, May 20, 2026 at 03:06:30PM -0700, Randy Dunlap wrote: > > > On 5/18/26 6:27 PM, Leonardo Bras wrote: > > diff --git a/MAINTAINERS b/MAINTAINERS > > index c2c6d79275c6..7102031207c9 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -21775,20 +21775,27 @@ QORIQ DPAA2 FSL-MC BUS DRIVER > > M: Ioana Ciornei > > L: linuxppc-dev@lists.ozlabs.org > > L: linux-kernel@vger.kernel.org > > S: Maintained > > F: Documentation/ABI/stable/sysfs-bus-fsl-mc > > F: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.yaml > > F: Documentation/networking/device_drivers/ethernet/freescale/dpaa2/overview.rst > > F: drivers/bus/fsl-mc/ > > F: include/uapi/linux/fsl_mc.h > > > > +PW Locks > > +M: Leonardo Bras > > +S: Supported > > +F: Documentation/locking/pwlocks.rst > > +F: include/linux/pwlocks.h > > +F: kernel/pwlocks.c > > MAINTAINERS entries should be in alphabetical order: PW is not in the > middle of the Q entries. Hi Randy, thank you for reviewing! Argh, sorry, it used to be called QPW. I renamed and forgot to reorder. > > > + > > QT1010 MEDIA DRIVER > > L: linux-media@vger.kernel.org > > S: Orphan > > W: https://linuxtv.org > > Q: http://patchwork.linuxtv.org/project/linux-media/list/ > > F: drivers/media/tuners/qt1010* > > > > QUALCOMM ATH12K WIRELESS DRIVER > > M: Jeff Johnson > > L: linux-wireless@vger.kernel.org > > > > diff --git a/Documentation/locking/pwlocks.rst b/Documentation/locking/pwlocks.rst > > new file mode 100644 > > index 000000000000..09f4a5417bc1 > > --- /dev/null > > +++ b/Documentation/locking/pwlocks.rst > > @@ -0,0 +1,76 @@ > > +.. SPDX-License-Identifier: GPL-2.0 > > + > > +========= > > +PW (Per-CPU Work) locks > > +========= > > Overline and underline should be at least as long as the heading text. > Noted! > > + > > +Some places in the kernel implement a parallel programming strategy > > +consisting on local_locks() for most of the work, and some rare remote > > +operations are scheduled on target cpu. This keeps cache bouncing low since > > on a target CPU. Right > > > +cacheline tends to be mostly local, and avoids the cost of locks in non-RT > > +kernels, even though the very few remote operations will be expensive due > > +to scheduling overhead. > > + > > +On the other hand, for RT workloads this can represent a problem: > > +scheduling work on remote cpu that are executing low latency tasks > > CPUs Will fix > > > +is undesired and can introduce unexpected deadline misses. > > undesirable > ? Yes > > > + > > +PW locks help to convert sites that use local_locks (for cpu local operations) > > +and queue_work_on (for queueing work remotely, to be executed > > +locally on the owner cpu of the lock) to a spinlocks. > > to spinlocks. > Right > > + > > +The lock is declared pw_lock_t type. > > +The lock is initialized with pw_lock_init. > > +The lock is locked with pw_lock (takes a lock and cpu as a parameter). > > +The lock is unlocked with pw_unlock (takes a lock and cpu as a parameter). > > + > > +The pw_lock_irqsave function disables interrupts and saves current interrupt state, > > +cpu as a parameter. > > + > > +For trylock variant, there is the pw_trylock_t type, initialized with > > +pw_trylock_init. Then the corresponding pw_trylock and pw_trylock_irqsave. > > + > > +work_struct should be replaced by pw_struct, which contains a cpu parameter > > +(owner cpu of the lock), initialized by INIT_PW. > > + > > +The queue work related functions (analogous to queue_work_on and flush_work) are: > > +pw_queue_on and pw_flush. > > + > > +The behaviour of the PW lock functions is as follows: > > + > > +* !CONFIG_PWLOCKS (or CONFIG_PWLOCKS and pwlocks=off kernel boot parameter): > > + - pw_lock: local_lock > > + - pw_lock_irqsave: local_lock_irqsave > > + - pw_trylock: local_trylock > > + - pw_trylock_irqsave: local_trylock_irqsave > > + - pw_unlock: local_unlock > > + - pw_lock_local: local_lock > > + - pw_trylock_local: local_trylock > > + - pw_unlock_local: local_unlock > > + - pw_queue_on: queue_work_on > > + - pw_flush: flush_work > > + > > +* CONFIG_PWLOCKS (and CONFIG_PWLOCKS_DEFAULT=y or pwlocks=on kernel boot parameter), > > + - pw_lock: spin_lock > > + - pw_lock_irqsave: spin_lock_irqsave > > + - pw_trylock: spin_trylock > > + - pw_trylock_irqsave: spin_trylock_irqsave > > + - pw_unlock: spin_unlock > > + - pw_lock_local: preempt_disable OR migrate_disable + spin_lock > > + - pw_trylock_local: preempt_disable OR migrate_disable + spin_trylock > > + - pw_unlock_local: preempt_enable OR migrate_enable + spin_unlock > > + - pw_queue_on: executes work function on caller cpu > > + - pw_flush: empty > > + > > +pw_get_cpu(work_struct), to be called from within per-cpu work function, > > +returns the target cpu. > > CPU. > Will fix > > + > > +On the locking functions above, there are the local locking functions > > +(pw_lock_local, pw_trylock_local and pw_unlock_local) that must only > > +be used to access per-CPU data from the CPU that owns that data, > > +and never remotely. They disable preemption/migration and don't require > > +a cpu parameter, making them a replacement for local_lock functions that > > +does not introduce overhead. > > + > > +These should only be used when accessing per-CPU data of the local CPU. > > + > > Running "make htmldocs" with this patch says: > > Documentation/locking/pwlocks.rst: WARNING: document isn't included in any toctree [toc.not_included] > Humm, I will figure out a way of including it in a relevant toctree. > > diff --git a/init/Kconfig b/init/Kconfig > > index 2937c4d308ae..3fb751dc4530 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -764,20 +764,55 @@ config CPU_ISOLATION > > depends on SMP > > default y > > help > > Make sure that CPUs running critical tasks are not disturbed by > > any source of "noise" such as unbound workqueues, timers, kthreads... > > Unbound jobs get offloaded to housekeeping CPUs. This is driven by > > the "isolcpus=" boot parameter. > > > > Say Y if unsure. > > > > +config PWLOCKS > > + bool "Per-CPU Work locks" > > + depends on SMP || COMPILE_TEST > > + default n > > + help > > + Allow changing the behavior on per-CPU resource sharing with cache, > > + from the regular local_locks() + queue_work_on(remote_cpu) to using > > + per-CPU spinlocks on both local and remote operations. > > + > > + This is useful to give user the option on reducing IPIs to CPUs, and > > to give the user Right > > > + thus reduce interruptions and context switches. On the other hand, it > > + increases generated code and will use atomic operations if spinlocks > > + are selected. > > + > > + If set, will use the default behavior set in PWLOCKS_DEFAULT unless boot > > unless the boot > Correct > > + parameter pwlocks is passed with a different behavior. > > + > > + If unset, will use the local_lock() + queue_work_on() strategy, > > + regardless of the boot parameter or PWLOCKS_DEFAULT. > > + > > + Say N if unsure. > > + > > +config PWLOCKS_DEFAULT > > + bool "Use per-CPU spinlocks by default on PWLOCKS" > > + depends on PWLOCKS > > + default n > > + help > > + If set, will use per-CPU spinlocks as default behavior for per-CPU > > + remote operations. > > + > > + If unset, will use local_lock() + queue_work_on(cpu) as default > > + behavior for remote operations. > > + > > + Say N if unsure > > unsure. > Yeap :) > > + > > source "kernel/rcu/Kconfig" > > > > config IKCONFIG > > tristate "Kernel .config support" > > help > > This option enables the complete Linux kernel ".config" file > > contents to be saved in the kernel. It provides documentation > > of which kernel options are used in a running kernel or in an > > on-disk kernel. This information can be extracted from the kernel > > image file with the script scripts/extract-ikconfig and used as > > -- > ~Randy > Thanks! Leo